[{"id":34155,"web_url":"https://patchwork.libcamera.org/comment/34155/","msgid":"","date":"2025-05-07T18:24:14","subject":"Re: [PATCH v2 1/9] utils: gen-debug-controls: Remove line number\n\tfrom control description","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Apr 11, 2025 at 02:36:29PM +0200, Stefan Klug wrote:\n> The line numbers change so often that including them in the description\n> creates too much noise in control_ids_debug.yaml. Output the path only.\n> \n> Signed-off-by: Stefan Klug \n> Acked-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> utils/gen-debug-controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\n> index 272597f4874f..53c8fa70d76d 100755\n> --- a/utils/gen-debug-controls.py\n> +++ b/utils/gen-debug-controls.py\n> @@ -107,7 +107,7 @@ def main(argv):\n> p = m.file.relative_to(root_dir)\n> desc = {'type': m.type,\n> 'direction': 'out',\n> - 'description': f'Debug control {m.name} found in {p}:{m.line}'}\n> + 'description': f'Debug control {m.name} found in {p}'}\n> if m.size is not None:\n> desc['size'] = m.size\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CD57C3200\n\tfor ;\n\tWed, 7 May 2025 18:24:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8660568B3A;\n\tWed, 7 May 2025 20:24:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC1DE68AD8\n\tfor ;\n\tWed, 7 May 2025 20:24:20 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E43556D5;\n\tWed, 7 May 2025 20:24:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"axlI2b6i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746642249;\n\tbh=aAC70selRTzN7m1YGS8p3uNACgQbHc40OCB1kRXp5Ck=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=axlI2b6inW7uawbsi11ccACchn9ziRhe7BojptkVgwKzTyqgchDrG3JLxNYVyc43m\n\tYfYjK23SgxRxbzhduByTABidnknjW4qNUwkrGq2tjwBI7ukiK6uDAbxMvAlGaJnpfN\n\tXErcYy0Eoa6/f4VlPrRIY8qKD90zbLE2xXOUkJ9I=","Date":"Wed, 7 May 2025 20:24:14 +0200","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 1/9] utils: gen-debug-controls: Remove line number\n\tfrom control description","Message-ID":"","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250411123641.2144530-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34244,"web_url":"https://patchwork.libcamera.org/comment/34244/","msgid":"<174731448159.752293.2170054959631136318@isaac-ThinkPad-T16-Gen-2>","date":"2025-05-15T13:08:01","subject":"Re: [PATCH v2 1/9] utils: gen-debug-controls: Remove line number\n\tfrom control description","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Stefan,\nThank you for the patch.\n\nQuoting Stefan Klug (2025-04-11 13:36:29)\n> The line numbers change so often that including them in the description\n> creates too much noise in control_ids_debug.yaml. Output the path only.\n> \n> Signed-off-by: Stefan Klug \n> Acked-by: Kieran Bingham \n> \n\nReviewed-by: Isaac Scott \n\n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> utils/gen-debug-controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\n> index 272597f4874f..53c8fa70d76d 100755\n> --- a/utils/gen-debug-controls.py\n> +++ b/utils/gen-debug-controls.py\n> @@ -107,7 +107,7 @@ def main(argv):\n> p = m.file.relative_to(root_dir)\n> desc = {'type': m.type,\n> 'direction': 'out',\n> - 'description': f'Debug control {m.name} found in {p}:{m.line}'}\n> + 'description': f'Debug control {m.name} found in {p}'}\n> if m.size is not None:\n> desc['size'] = m.size\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A05CC3220\n\tfor ;\n\tThu, 15 May 2025 13:08:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 524EC68B70;\n\tThu, 15 May 2025 15:08:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B482E68B4F\n\tfor ;\n\tThu, 15 May 2025 15:08:08 +0200 (CEST)","from thinkpad.ideasonboard.com (unknown\n\t[IPv6:2a01:cb16:204c:4644:3f69:4c6e:7066:a222])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61EDD886;\n\tThu, 15 May 2025 15:07:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fIEKauhr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747314471;\n\tbh=x6jh5V2uohq8X0kNedcYRXegms9MulV25H3p72lm1R0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fIEKauhriZPojtgAD6Mw+JpGRd+mA/3YtjuQq38UE2XGnxxeK8agnIBAxElLGm0bd\n\t4WY3dtV3W1RxdiTFbEQeHaFq3VOJCzRR/7G2ZrDZu8gxyGnkPAB8a8sOwSyzzxnq1X\n\tBt/4vJqw7ikRFqPjMflqtIteyII7uMqksn+++TCY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-2-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>\n\t<20250411123641.2144530-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 1/9] utils: gen-debug-controls: Remove line number\n\tfrom control description","From":"Isaac Scott ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 15 May 2025 14:08:01 +0100","Message-ID":"<174731448159.752293.2170054959631136318@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]