[{"id":33929,"web_url":"https://patchwork.libcamera.org/comment/33929/","msgid":"<20250409154413.GB10078@pendragon.ideasonboard.com>","date":"2025-04-09T15:44:13","subject":"Re: [libcamera-ci] [PATCH v1] Adapt to `v4l2` meson option type\n\tchange","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Wed, Apr 09, 2025 at 05:38:14PM +0200, Barnabás Pőcze wrote:\n> libcamera commit a945532314 (\"meson: Convert `v4l2` into a feature option\")\n> changed the type of the `v4l2` meson option from `boolean` to `feature`, and\n> while it is still possible to set boolean values, that is deprecated.\n> \n> Convert `v4l2=true` to `v4l2=enabled`, and remove `v4l2=false` as that is\n> already implied by `auto_features=disabled` specified earlier in the command.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .gitlab-ci/build-libcamera-cros.sh | 1 -\n> gitlab-ci.yml | 5 ++---\n> 2 files changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/.gitlab-ci/build-libcamera-cros.sh b/.gitlab-ci/build-libcamera-cros.sh\n> index 550f4e5..b153c2a 100755\n> --- a/.gitlab-ci/build-libcamera-cros.sh\n> +++ b/.gitlab-ci/build-libcamera-cros.sh\n> @@ -26,7 +26,6 @@ libcamera_cros_setup() {\n> \t\t-Dpipelines=ipu3,uvcvideo \\\n> \t\t-Dtest=false \\\n> \t\t-Dudev=enabled \\\n> -\t\t-Dv4l2=false \\\n> \t\tbuild\n> }\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index 0884362..11790bb 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -25,7 +25,7 @@ variables:\n> -D test=true\n> -D tracing=enabled\n> -D udev=enabled\n> - -D v4l2=true\n> + -D v4l2=enabled\n> # clang fails to link with ASan if --no-undefined is enabled.\n> MESON_CLANG_OPTIONS: >-\n> -D b_lundef=false\n> @@ -285,7 +285,6 @@ build-package:debug:\n> -D lc-compliance=enabled\n> -D test=false\n> -D tracing=enabled\n> - -D v4l2=false\n> parallel:\n> matrix:\n> - ARCH: amd64\n> @@ -409,7 +408,7 @@ test-unit:\n> -D pycamera=enabled\n> -D qcam=disabled\n> -D test=true\n> - -D v4l2=true\n> + -D v4l2=enabled\n> \n> test-lc-compliance:virtual:\n> extends:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F91BC327D\n\tfor ;\n\tWed, 9 Apr 2025 15:44:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E0D168A38;\n\tWed, 9 Apr 2025 17:44:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D70C4627F4\n\tfor ;\n\tWed, 9 Apr 2025 17:44:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 885F7455;\n\tWed, 9 Apr 2025 17:42:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lzk1jdye\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744213360;\n\tbh=g18iJkcUPo6i2XdHDHXIyoEfw5C92fczzEr8lpd5KZw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Lzk1jdyeotUiC3FvnZXGgvVKw37Df81m/hy72xrRD+mHgpVrEQUt3Y7Gv7/fRQSxJ\n\t8xIHo7Hsqgm5qiwJeTIaAvstgt+UrVJIiUx6wkeFP7XT23o0e/2a/JFgowN6QFMwn0\n\tRBAdOdDuBVZpDPUCJGKzepoYgaWZFNJzrKmHLtOw=","Date":"Wed, 9 Apr 2025 18:44:13 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-ci] [PATCH v1] Adapt to `v4l2` meson option type\n\tchange","Message-ID":"<20250409154413.GB10078@pendragon.ideasonboard.com>","References":"<20250409153814.704320-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250409153814.704320-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]