{"id":23151,"url":"https://patchwork.libcamera.org/api/patches/23151/?format=json","web_url":"https://patchwork.libcamera.org/patch/23151/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250407085639.16180-10-mzamazal@redhat.com>","date":"2025-04-07T08:56:35","name":"[v4,09/11] libcamera: simple: Don't enforce conversion with an added raw stream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"82524b17f01f93c475910b3cf719fbaad6218d7c","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23151/mbox/","series":[{"id":5117,"url":"https://patchwork.libcamera.org/api/series/5117/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5117","date":"2025-04-07T08:56:26","name":"Enable raw streams with software ISP","version":4,"mbox":"https://patchwork.libcamera.org/series/5117/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23151/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23151/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C475DC327D\n\tfor ;\n\tMon, 7 Apr 2025 08:57:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6119C68AA9;\n\tMon, 7 Apr 2025 10:57:28 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E0AC689F5\n\tfor ;\n\tMon, 7 Apr 2025 10:57:23 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-540-Idv8GO0-NnqKcYxX760W8A-1;\n\tMon, 07 Apr 2025 04:57:18 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id BC49619560A1; Mon, 7 Apr 2025 08:57:17 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.129])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DB724180176A; Mon, 7 Apr 2025 08:57:15 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"dVPIH326\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1744016242;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=yY42ccmKJug69GPMTGjCWBTt8f3GLCD1Oq9x8zvN8Ps=;\n\tb=dVPIH326Zm/McMNpQFseAXd+JPoee9712XJvJquv8xjreTQFPyBYTp4w78Pqai2RScnD6e\n\t23yJ3DJWXuRi+wm81GbzybOgf+EQ7HdfeeG/XF503gMylrhrK5PUwJFtd6ajEB1hGwpOrW\n\tFGTZ5vFSSco+rBjdWTVVtJKycC6qH50=","X-MC-Unique":"Idv8GO0-NnqKcYxX760W8A-1","X-Mimecast-MFC-AGG-ID":"Idv8GO0-NnqKcYxX760W8A_1744016237","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v4 09/11] libcamera: simple: Don't enforce conversion with an\n\tadded raw stream","Date":"Mon, 7 Apr 2025 10:56:35 +0200","Message-ID":"<20250407085639.16180-10-mzamazal@redhat.com>","In-Reply-To":"<20250407085639.16180-1-mzamazal@redhat.com>","References":"<20250407085639.16180-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"2ZgLXTM6t721WXzxxlccSoe-8DtCsueRok8qft_j09Q_1744016237","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations, so that the\nmere presence of a raw stream doesn't enforce conversion.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 313c454c..2932fb45 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1208,7 +1208,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + (data_->rawRequested_ ? 1 : 0);\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n","prefixes":["v4","09/11"]}