{"id":23147,"url":"https://patchwork.libcamera.org/api/patches/23147/?format=json","web_url":"https://patchwork.libcamera.org/patch/23147/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250407085639.16180-5-mzamazal@redhat.com>","date":"2025-04-07T08:56:30","name":"[v4,04/11] libcamera: simple: Don't use raw output formats with conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"783df6908290034ab573a8177980ff7a0b99c4ed","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23147/mbox/","series":[{"id":5117,"url":"https://patchwork.libcamera.org/api/series/5117/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5117","date":"2025-04-07T08:56:26","name":"Enable raw streams with software ISP","version":4,"mbox":"https://patchwork.libcamera.org/series/5117/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23147/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23147/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0750C3284\n\tfor ;\n\tMon, 7 Apr 2025 08:57:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BA4468A54;\n\tMon, 7 Apr 2025 10:57:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08534689B0\n\tfor ;\n\tMon, 7 Apr 2025 10:57:11 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-314-UCudccfRMCaoi7lw5775sg-1;\n\tMon, 07 Apr 2025 04:57:07 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 68966180AF57; Mon, 7 Apr 2025 08:57:06 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.129])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2E968180176A; Mon, 7 Apr 2025 08:57:03 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"HaXcGFX7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1744016230;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=d64K+K3+8Rva9LCM+PVwdvUH7J/vc6/ZROsw7RbwsY4=;\n\tb=HaXcGFX7e4x6Yx4qi0ZN//TrNGlDV/pSvI9Ge+5SnHFmCOrZR6XVa4wXpbgW+ywxWqIV2A\n\t3O2osJ4fvjCJw79xCueYToRNyWD+MiVTTPKJj2QNzHe1qGjnyA7UFGMOE5nLNEORgY7ZSa\n\taLPX1ahKnNruQ8Yec2l8dFtKSXLfwHc=","X-MC-Unique":"UCudccfRMCaoi7lw5775sg-1","X-Mimecast-MFC-AGG-ID":"UCudccfRMCaoi7lw5775sg_1744016226","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v4 04/11] libcamera: simple: Don't use raw output formats\n\twith conversions","Date":"Mon, 7 Apr 2025 10:56:30 +0200","Message-ID":"<20250407085639.16180-5-mzamazal@redhat.com>","In-Reply-To":"<20250407085639.16180-1-mzamazal@redhat.com>","References":"<20250407085639.16180-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Mk_yD_9ctPGNLZDRzN28jDYj0PM8HagcQHyiOU9e43M_1744016226","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex ab19149e..60b7e1b1 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -27,6 +27,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -1411,7 +1412,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isFormatRaw(cfg.pixelFormat))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["v4","04/11"]}