[{"id":33917,"web_url":"https://patchwork.libcamera.org/comment/33917/","msgid":"<20250404170746.GJ4845@pendragon.ideasonboard.com>","date":"2025-04-04T17:07:46","subject":"Re: [PATCH 1/2] meson: make the default value of \"documentation\"\n\tfeature explicit","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Quentin,\n\nThank you for the patch.\n\nOn Fri, Apr 04, 2025 at 06:12:34PM +0200, Quentin Schulz wrote:\n> From: Quentin Schulz \n> \n> The meson documentation on the feature build options isn't clear if a\n> missing \"value\" is legal and if it is, what its default value is.[1]\n> \n> Therefore, let's make it explicit by using what is experimentally the\n> default: auto.\n> \n> [1] https://mesonbuild.com/Build-options.html#features\n> \n> Signed-off-by: Quentin Schulz \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> meson_options.txt | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 1877d800..2104469e 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -18,6 +18,7 @@ option('cam',\n> \n> option('documentation',\n> type : 'feature',\n> + value : 'auto',\n> description : 'Generate the project documentation')\n> \n> option('doc_werror',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFDEFC3213\n\tfor ;\n\tFri, 4 Apr 2025 17:08:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2453689A1;\n\tFri, 4 Apr 2025 19:08:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3379068991\n\tfor ;\n\tFri, 4 Apr 2025 19:08:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75322129;\n\tFri, 4 Apr 2025 19:06:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xtyba9PN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743786377;\n\tbh=isUMQqJyAxPsgjnhpAIBO1kyu/4REzocNqpyDNQBmsA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xtyba9PNK79Zrf/lwbeSucIvzzsPsnG2zyenQu05rhGjVTIOJWffiFimrk/dX85q+\n\tHdmG6RjxszKol5ICx+5xdpxwKGY6bDP6DUDvr2AdOhDU5hslGGG2lKVMr8dt/Lony1\n\tAYgS8YVc3v6o3TcikYmur62oCX6m+9ZHUVWiaj0c=","Date":"Fri, 4 Apr 2025 20:07:46 +0300","From":"Laurent Pinchart ","To":"Quentin Schulz ","Cc":"libcamera-devel@lists.libcamera.org,\n\tQuentin Schulz ","Subject":"Re: [PATCH 1/2] meson: make the default value of \"documentation\"\n\tfeature explicit","Message-ID":"<20250404170746.GJ4845@pendragon.ideasonboard.com>","References":"<20250404161237.1298653-1-foss+libcamera@0leil.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250404161237.1298653-1-foss+libcamera@0leil.net>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34065,"web_url":"https://patchwork.libcamera.org/comment/34065/","msgid":"<174582566426.1397492.11766676316486623873@ping.linuxembedded.co.uk>","date":"2025-04-28T07:34:24","subject":"Re: [PATCH 1/2] meson: make the default value of \"documentation\"\n\tfeature explicit","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Quentin Schulz (2025-04-04 17:12:34)\n> From: Quentin Schulz \n> \n> The meson documentation on the feature build options isn't clear if a\n> missing \"value\" is legal and if it is, what its default value is.[1]\n> \n> Therefore, let's make it explicit by using what is experimentally the\n> default: auto.\n> \n> [1] https://mesonbuild.com/Build-options.html#features\n> \n> Signed-off-by: Quentin Schulz \n\nReviewed-by: Kieran Bingham \n\n> ---\n> meson_options.txt | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 1877d800..2104469e 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -18,6 +18,7 @@ option('cam',\n> \n> option('documentation',\n> type : 'feature',\n> + value : 'auto',\n> description : 'Generate the project documentation')\n> \n> option('doc_werror',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32742C327D\n\tfor ;\n\tMon, 28 Apr 2025 07:34:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5885768ACE;\n\tMon, 28 Apr 2025 09:34:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7571A68AC7\n\tfor ;\n\tMon, 28 Apr 2025 09:34:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A5B8475;\n\tMon, 28 Apr 2025 09:34:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D8s1Y9/d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745825662;\n\tbh=maKxl0XMSor8ZEzzH87RrsKagQ7B5qxV7a2saDotdKw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=D8s1Y9/dfJe0O7SeI6y66MJjh9OKH+wpGgLiPoGQeh0C9axFYkZoxRtOColkLvpay\n\thhvD5Hu1pKSEoh00/reQqsttlQD6ezrZLiWDZUI5ElopfuMjKVX1deEeSbE8+UWY7v\n\tjNvVBIB8sYv4CMQ+QgyEIJxUwSR3XeWuy8BVgR7w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250404161237.1298653-1-foss+libcamera@0leil.net>","References":"<20250404161237.1298653-1-foss+libcamera@0leil.net>","Subject":"Re: [PATCH 1/2] meson: make the default value of \"documentation\"\n\tfeature explicit","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tQuentin Schulz ","To":", Quentin Schulz ","Date":"Mon, 28 Apr 2025 08:34:24 +0100","Message-ID":"<174582566426.1397492.11766676316486623873@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]