[{"id":33923,"web_url":"https://patchwork.libcamera.org/comment/33923/","msgid":"<20250406180008.GA30117@pendragon.ideasonboard.com>","date":"2025-04-06T18:00:08","subject":"Re: [PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Apr 04, 2025 at 04:46:21PM +0900, Paul Elder wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> To facilitate expanding the use of a shared_ptr<MediaDevice> in\n> preference of a raw MediaDevice* pointer, add an additional\n> implementation for fromEntityName for both of v4l2_videodevice and\n> v4l2_subdevice to support this type.\n\nIs this really worth it, to just avoid a .get() call in the caller ?\n\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> ---\n>  include/libcamera/internal/v4l2_subdevice.h   |  2 ++\n>  include/libcamera/internal/v4l2_videodevice.h |  2 ++\n>  src/libcamera/v4l2_subdevice.cpp              | 15 +++++++++++++++\n>  src/libcamera/v4l2_videodevice.cpp            | 15 +++++++++++++++\n>  4 files changed, 34 insertions(+)\n> \n> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> index fa2a4a21eefb..08216cd56bc3 100644\n> --- a/include/libcamera/internal/v4l2_subdevice.h\n> +++ b/include/libcamera/internal/v4l2_subdevice.h\n> @@ -163,6 +163,8 @@ public:\n>  \n>  \tstatic std::unique_ptr<V4L2Subdevice>\n>  \tfromEntityName(const MediaDevice *media, const std::string &entity);\n> +\tstatic std::unique_ptr<V4L2Subdevice>\n> +\tfromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n>  \n>  protected:\n>  \tstd::string logPrefix() const override;\n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index ae6a76cb0209..e35fb11bc99f 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -228,6 +228,8 @@ public:\n>  \n>  \tstatic std::unique_ptr<V4L2VideoDevice>\n>  \tfromEntityName(const MediaDevice *media, const std::string &entity);\n> +\tstatic std::unique_ptr<V4L2VideoDevice>\n> +\tfromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n>  \n>  \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat) const;\n>  \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 33279654db8c..13f5316a3fc3 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -1766,6 +1766,21 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n>  \treturn std::make_unique<V4L2Subdevice>(mediaEntity);\n>  }\n>  \n> +/**\n> + * \\brief Create a new video subdevice instance from \\a entity in media device\n> + * \\a media\n> + * \\param[in] media The media device where the entity is registered\n> + * \\param[in] entity The media entity name\n> + *\n> + * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n> + */\n> +std::unique_ptr<V4L2Subdevice>\n> +V4L2Subdevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n> +\t\t\t      const std::string &entity)\n> +{\n> +\treturn fromEntityName(media.get(), entity);\n> +}\n> +\n>  std::string V4L2Subdevice::logPrefix() const\n>  {\n>  \treturn \"'\" + entity_->name() + \"'\";\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index f5b3fa09d9a0..ce7be7deb91f 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -2109,6 +2109,21 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n>  \treturn std::make_unique<V4L2VideoDevice>(mediaEntity);\n>  }\n>  \n> +/**\n> + * \\brief Create a new video device instance from \\a entity in media device\n> + * \\a media\n> + * \\param[in] media The media device where the entity is registered\n> + * \\param[in] entity The media entity name\n> + *\n> + * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n> + */\n> +std::unique_ptr<V4L2VideoDevice>\n> +V4L2VideoDevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n> +\t\t\t\tconst std::string &entity)\n> +{\n> +\treturn fromEntityName(media.get(), entity);\n> +}\n> +\n>  /**\n>   * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n>   * \\param[in] pixelFormat The PixelFormat to convert","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E359C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun,  6 Apr 2025 18:00:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12E7C689A2;\n\tSun,  6 Apr 2025 20:00:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E95A2689A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  6 Apr 2025 20:00:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6CA0564;\n\tSun,  6 Apr 2025 19:58:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IRssV5Zw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743962317;\n\tbh=qWEoOqbvL90LYnKP8VRmTSYHROUPt1ZA7xlQDQ/QHUQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IRssV5Zwf9QbtWeiBQF+lDRkxe0sJmBAakKkEZrVaAxhkqtGaSnjYlkszgL53+SOl\n\tRvcWoZqbos1kBUm1VP7RPwp0oePuJcnQwCb+g0xJAbSFpVXRvkQedz/byE4HsdQeNM\n\tnlZslKDzjAtxYA8EuGE9A98KrDqPi25r8Xb6iC1U=","Date":"Sun, 6 Apr 2025 21:00:08 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>","Message-ID":"<20250406180008.GA30117@pendragon.ideasonboard.com>","References":"<20250404074624.2975182-1-paul.elder@ideasonboard.com>\n\t<20250404074624.2975182-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250404074624.2975182-2-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":33987,"web_url":"https://patchwork.libcamera.org/comment/33987/","msgid":"<174531750316.2882969.13289554705896578050@ping.linuxembedded.co.uk>","date":"2025-04-22T10:25:03","subject":"Re: [PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-04-06 19:00:08)\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Fri, Apr 04, 2025 at 04:46:21PM +0900, Paul Elder wrote:\n> > From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > To facilitate expanding the use of a shared_ptr<MediaDevice> in\n> > preference of a raw MediaDevice* pointer, add an additional\n> > implementation for fromEntityName for both of v4l2_videodevice and\n> > v4l2_subdevice to support this type.\n> \n> Is this really worth it, to just avoid a .get() call in the caller ?\n\nI felt it was cleaner/less churn, and meant that both types could be\nsupported - with shorter lines in the case of a shared_ptr.\n\n(Note that this patch was preceeding a conversion of call locations\nfrom being a MediaDevice*  to a shared_ptr<const MediaDevice>)\n\nWould you rather see this patch dropped and have the next patch convert\nall current users of fromEntityName() call .get on MediaDevice pointers?\n\n> \n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> > ---\n> >  include/libcamera/internal/v4l2_subdevice.h   |  2 ++\n> >  include/libcamera/internal/v4l2_videodevice.h |  2 ++\n> >  src/libcamera/v4l2_subdevice.cpp              | 15 +++++++++++++++\n> >  src/libcamera/v4l2_videodevice.cpp            | 15 +++++++++++++++\n> >  4 files changed, 34 insertions(+)\n> > \n> > diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> > index fa2a4a21eefb..08216cd56bc3 100644\n> > --- a/include/libcamera/internal/v4l2_subdevice.h\n> > +++ b/include/libcamera/internal/v4l2_subdevice.h\n> > @@ -163,6 +163,8 @@ public:\n> >  \n> >       static std::unique_ptr<V4L2Subdevice>\n> >       fromEntityName(const MediaDevice *media, const std::string &entity);\n> > +     static std::unique_ptr<V4L2Subdevice>\n> > +     fromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n> >  \n> >  protected:\n> >       std::string logPrefix() const override;\n> > diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> > index ae6a76cb0209..e35fb11bc99f 100644\n> > --- a/include/libcamera/internal/v4l2_videodevice.h\n> > +++ b/include/libcamera/internal/v4l2_videodevice.h\n> > @@ -228,6 +228,8 @@ public:\n> >  \n> >       static std::unique_ptr<V4L2VideoDevice>\n> >       fromEntityName(const MediaDevice *media, const std::string &entity);\n> > +     static std::unique_ptr<V4L2VideoDevice>\n> > +     fromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n> >  \n> >       V4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat) const;\n> >  \n> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > index 33279654db8c..13f5316a3fc3 100644\n> > --- a/src/libcamera/v4l2_subdevice.cpp\n> > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > @@ -1766,6 +1766,21 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n> >       return std::make_unique<V4L2Subdevice>(mediaEntity);\n> >  }\n> >  \n> > +/**\n> > + * \\brief Create a new video subdevice instance from \\a entity in media device\n> > + * \\a media\n> > + * \\param[in] media The media device where the entity is registered\n> > + * \\param[in] entity The media entity name\n> > + *\n> > + * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n> > + */\n> > +std::unique_ptr<V4L2Subdevice>\n> > +V4L2Subdevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n> > +                           const std::string &entity)\n> > +{\n> > +     return fromEntityName(media.get(), entity);\n> > +}\n> > +\n> >  std::string V4L2Subdevice::logPrefix() const\n> >  {\n> >       return \"'\" + entity_->name() + \"'\";\n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index f5b3fa09d9a0..ce7be7deb91f 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -2109,6 +2109,21 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n> >       return std::make_unique<V4L2VideoDevice>(mediaEntity);\n> >  }\n> >  \n> > +/**\n> > + * \\brief Create a new video device instance from \\a entity in media device\n> > + * \\a media\n> > + * \\param[in] media The media device where the entity is registered\n> > + * \\param[in] entity The media entity name\n> > + *\n> > + * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n> > + */\n> > +std::unique_ptr<V4L2VideoDevice>\n> > +V4L2VideoDevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n> > +                             const std::string &entity)\n> > +{\n> > +     return fromEntityName(media.get(), entity);\n> > +}\n> > +\n> >  /**\n> >   * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n> >   * \\param[in] pixelFormat The PixelFormat to convert\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB183C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 10:25:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5F8468ACA;\n\tTue, 22 Apr 2025 12:25:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93A70617E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 12:25:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1ACF7250;\n\tTue, 22 Apr 2025 12:22:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BBnUESsa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745317379;\n\tbh=uTg/13HHu7irzlHas9lTjyUueIrhQe2NmDdickVeZ3k=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BBnUESsatW7vtPd0s/pIPCvmhc38JBaBkcXD3Pd02msdcJg7ioYnuNSM3SvFYqkgz\n\tn2jcR4mAnKGdyQxMigoMmajYHjg52CBqOQ/GzP4H70F3UH9PqplepPHKDWGLWKfPFL\n\tmxDwLrrIq1/Ckk5PpzrH1YCZnt0G0nACS261R+wM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250406180008.GA30117@pendragon.ideasonboard.com>","References":"<20250404074624.2975182-1-paul.elder@ideasonboard.com>\n\t<20250404074624.2975182-2-paul.elder@ideasonboard.com>\n\t<20250406180008.GA30117@pendragon.ideasonboard.com>","Subject":"Re: [PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>","Date":"Tue, 22 Apr 2025 11:25:03 +0100","Message-ID":"<174531750316.2882969.13289554705896578050@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":35829,"web_url":"https://patchwork.libcamera.org/comment/35829/","msgid":"<175794753251.653594.16051569777939822467@localhost>","date":"2025-09-15T14:45:32","subject":"Re: [PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch. As commented on patch 2/2 I like this change.\n\nQuoting Paul Elder (2025-04-04 09:46:21)\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> To facilitate expanding the use of a shared_ptr<MediaDevice> in\n> preference of a raw MediaDevice* pointer, add an additional\n> implementation for fromEntityName for both of v4l2_videodevice and\n> v4l2_subdevice to support this type.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\nBest regards,\nStefan\n\n> ---\n>  include/libcamera/internal/v4l2_subdevice.h   |  2 ++\n>  include/libcamera/internal/v4l2_videodevice.h |  2 ++\n>  src/libcamera/v4l2_subdevice.cpp              | 15 +++++++++++++++\n>  src/libcamera/v4l2_videodevice.cpp            | 15 +++++++++++++++\n>  4 files changed, 34 insertions(+)\n> \n> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> index fa2a4a21eefb..08216cd56bc3 100644\n> --- a/include/libcamera/internal/v4l2_subdevice.h\n> +++ b/include/libcamera/internal/v4l2_subdevice.h\n> @@ -163,6 +163,8 @@ public:\n>  \n>         static std::unique_ptr<V4L2Subdevice>\n>         fromEntityName(const MediaDevice *media, const std::string &entity);\n> +       static std::unique_ptr<V4L2Subdevice>\n> +       fromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n>  \n>  protected:\n>         std::string logPrefix() const override;\n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index ae6a76cb0209..e35fb11bc99f 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -228,6 +228,8 @@ public:\n>  \n>         static std::unique_ptr<V4L2VideoDevice>\n>         fromEntityName(const MediaDevice *media, const std::string &entity);\n> +       static std::unique_ptr<V4L2VideoDevice>\n> +       fromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n>  \n>         V4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat) const;\n>  \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 33279654db8c..13f5316a3fc3 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -1766,6 +1766,21 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n>         return std::make_unique<V4L2Subdevice>(mediaEntity);\n>  }\n>  \n> +/**\n> + * \\brief Create a new video subdevice instance from \\a entity in media device\n> + * \\a media\n> + * \\param[in] media The media device where the entity is registered\n> + * \\param[in] entity The media entity name\n> + *\n> + * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n> + */\n> +std::unique_ptr<V4L2Subdevice>\n> +V4L2Subdevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n> +                             const std::string &entity)\n> +{\n> +       return fromEntityName(media.get(), entity);\n> +}\n> +\n>  std::string V4L2Subdevice::logPrefix() const\n>  {\n>         return \"'\" + entity_->name() + \"'\";\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index f5b3fa09d9a0..ce7be7deb91f 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -2109,6 +2109,21 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n>         return std::make_unique<V4L2VideoDevice>(mediaEntity);\n>  }\n>  \n> +/**\n> + * \\brief Create a new video device instance from \\a entity in media device\n> + * \\a media\n> + * \\param[in] media The media device where the entity is registered\n> + * \\param[in] entity The media entity name\n> + *\n> + * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n> + */\n> +std::unique_ptr<V4L2VideoDevice>\n> +V4L2VideoDevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n> +                               const std::string &entity)\n> +{\n> +       return fromEntityName(media.get(), entity);\n> +}\n> +\n>  /**\n>   * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n>   * \\param[in] pixelFormat The PixelFormat to convert\n> -- \n> 2.47.2\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7707BBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Sep 2025 14:45:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6C206936F;\n\tMon, 15 Sep 2025 16:45:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10809613A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Sep 2025 16:45:36 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:2a47:b7e5:c39c:d1b3])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 85E666DF;\n\tMon, 15 Sep 2025 16:44:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tc8i/aJD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757947458;\n\tbh=9O8VyYLjIyCwzlxyXM42LLjcwXyrV8AOtR7UuVKfjmI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tc8i/aJDP0KS/q89CHZjYxFLnxWimaDiMMqzivrNE9yxK2qN1OF3KUetOxVKCSFIX\n\tzTGXuTAJJ0osqPjyvKZaN6FjYVoh+nWOv39nIFcaRN4mCH7Iwe/nCypt3d99NJSuBS\n\tdhiI5+E8kgaUnmaKiRyiFweZ8oUJxXLbQQCJpB4I=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250404074624.2975182-2-paul.elder@ideasonboard.com>","References":"<20250404074624.2975182-1-paul.elder@ideasonboard.com>\n\t<20250404074624.2975182-2-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>","From":"Stefan Klug <stefan.klug@ideasonboard.com>","Cc":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 15 Sep 2025 16:45:32 +0200","Message-ID":"<175794753251.653594.16051569777939822467@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]