[{"id":34140,"web_url":"https://patchwork.libcamera.org/comment/34140/","msgid":"","date":"2025-05-07T15:40:17","subject":"Re: [PATCH v3 03/16] libcamera: matrix: Add a Span based constructor","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Apr 03, 2025 at 05:49:08PM +0200, Stefan Klug wrote:\n> When one wants to create a Matrix from existing data, currently the only\n> way is via std::array. Add a Span based constructor to allow creation\n> from vectors and alike.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Added this patch\n> \n> Changes in v3:\n> - Pass the Span by value\n> ---\n> include/libcamera/internal/matrix.h | 5 +++++\n> src/libcamera/matrix.cpp | 10 ++++++++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\n> index 512c1162c3bc..6d40567af0a0 100644\n> --- a/include/libcamera/internal/matrix.h\n> +++ b/include/libcamera/internal/matrix.h\n> @@ -34,6 +34,11 @@ public:\n> \t\tstd::copy(data.begin(), data.end(), data_.begin());\n> \t}\n> \n> +\tMatrix(const Span data)\n> +\t{\n> +\t\tstd::copy(data.begin(), data.end(), data_.begin());\n> +\t}\n> +\n> \tstatic constexpr Matrix identity()\n> \t{\n> \t\tMatrix ret;\n> diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\n> index e7e027225666..49e2aa3b4f2c 100644\n> --- a/src/libcamera/matrix.cpp\n> +++ b/src/libcamera/matrix.cpp\n> @@ -41,6 +41,16 @@ LOG_DEFINE_CATEGORY(Matrix)\n> * number of rows and columns of the matrix (Rows x Cols).\n> */\n> \n> +/**\n> + * \\fn Matrix::Matrix(const Span data)\n> + * \\brief Construct a matrix from supplied data\n> + * \\param[in] data Data from which to construct a matrix\n> + *\n> + * \\a data is a one-dimensional Span and will be turned into a matrix in\n> + * row-major order. The size of \\a data must be equal to the product of the\n> + * number of rows and columns of the matrix (Rows x Cols).\n> + */\n> +\n> /**\n> * \\fn Matrix::identity()\n> * \\brief Construct an identity matrix\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 585C1C3200\n\tfor ;\n\tWed, 7 May 2025 15:40:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E2BB68B30;\n\tWed, 7 May 2025 17:40:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C08268ADE\n\tfor ;\n\tWed, 7 May 2025 17:40:21 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F03E8C59;\n\tWed, 7 May 2025 17:40:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HcNkPPo8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746632410;\n\tbh=ia2/JAHPu/m/sJaFFPLZTZUoDMaLaHLHXoLr8MN2dxQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HcNkPPo8t58Jq9WHp0YhzL/JOnX24zWqEYm3Yqps+NQn48XsyEreiD0G2dTR/MdQQ\n\tH8OfqxodZG8CzO9MT7OD5eoSNL/BDamH74jf2vfrbJSWXV6Wi0k0N+DUE7e0miD+hl\n\t+AkBj7umvJdefX62mvWV8ubSyskaP5dT+/zDmym8=","Date":"Wed, 7 May 2025 17:40:17 +0200","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v3 03/16] libcamera: matrix: Add a Span based constructor","Message-ID":"","References":"<20250403154925.382973-1-stefan.klug@ideasonboard.com>\n\t<20250403154925.382973-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250403154925.382973-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]