{"id":23119,"url":"https://patchwork.libcamera.org/api/patches/23119/?format=json","web_url":"https://patchwork.libcamera.org/patch/23119/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250403154925.382973-4-stefan.klug@ideasonboard.com>","date":"2025-04-03T15:49:08","name":"[v3,03/16] libcamera: matrix: Add a Span based constructor","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cfa8d61240ee4fbab851fff4fa48b49d0b235f85","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23119/mbox/","series":[{"id":5111,"url":"https://patchwork.libcamera.org/api/series/5111/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5111","date":"2025-04-03T15:49:05","name":"Some rkisp1 awb improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5111/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23119/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23119/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98046C327D\n\tfor ;\n\tThu, 3 Apr 2025 15:49:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50537689AA;\n\tThu, 3 Apr 2025 17:49:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDD41689A4\n\tfor ;\n\tThu, 3 Apr 2025 17:49:43 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6d9d:9854:3fc1:4bb2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2845B11E9;\n\tThu, 3 Apr 2025 17:47:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DX2kuY85\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743695270;\n\tbh=BVgpPik1tU5qZTphpyFI3gMMCarUSWs3223pG75Rli8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DX2kuY85j/htvaGR9SfWLXyabHS5phnGtLRtnRyD/SgpYppZyannq7zJddbjm2shl\n\tyKHXy3IuTwAk/hKjoQ9TEHWzQuQ3u2r6XKu+L/0PTGYsB57OzH9HCMRuDNJ+VGeLBy\n\t+aVev0V9m9+FOgPEhJU6aebS6l/CXgCFiE/Yn884=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 03/16] libcamera: matrix: Add a Span based constructor","Date":"Thu, 3 Apr 2025 17:49:08 +0200","Message-ID":"<20250403154925.382973-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250403154925.382973-1-stefan.klug@ideasonboard.com>","References":"<20250403154925.382973-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When one wants to create a Matrix from existing data, currently the only\nway is via std::array. Add a Span based constructor to allow creation\nfrom vectors and alike.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n\n---\n\nChanges in v2:\n- Added this patch\n\nChanges in v3:\n- Pass the Span by value\n---\n include/libcamera/internal/matrix.h | 5 +++++\n src/libcamera/matrix.cpp | 10 ++++++++++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\nindex 512c1162c3bc..6d40567af0a0 100644\n--- a/include/libcamera/internal/matrix.h\n+++ b/include/libcamera/internal/matrix.h\n@@ -34,6 +34,11 @@ public:\n \t\tstd::copy(data.begin(), data.end(), data_.begin());\n \t}\n \n+\tMatrix(const Span data)\n+\t{\n+\t\tstd::copy(data.begin(), data.end(), data_.begin());\n+\t}\n+\n \tstatic constexpr Matrix identity()\n \t{\n \t\tMatrix ret;\ndiff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\nindex e7e027225666..49e2aa3b4f2c 100644\n--- a/src/libcamera/matrix.cpp\n+++ b/src/libcamera/matrix.cpp\n@@ -41,6 +41,16 @@ LOG_DEFINE_CATEGORY(Matrix)\n * number of rows and columns of the matrix (Rows x Cols).\n */\n \n+/**\n+ * \\fn Matrix::Matrix(const Span data)\n+ * \\brief Construct a matrix from supplied data\n+ * \\param[in] data Data from which to construct a matrix\n+ *\n+ * \\a data is a one-dimensional Span and will be turned into a matrix in\n+ * row-major order. The size of \\a data must be equal to the product of the\n+ * number of rows and columns of the matrix (Rows x Cols).\n+ */\n+\n /**\n * \\fn Matrix::identity()\n * \\brief Construct an identity matrix\n","prefixes":["v3","03/16"]}