[{"id":33916,"web_url":"https://patchwork.libcamera.org/comment/33916/","msgid":"<174378148309.2166729.5552451891463223441@ping.linuxembedded.co.uk>","date":"2025-04-04T15:44:43","subject":"Re: [PATCH] libcamera: software_isp: Add a clarification comment to\n\tAWB","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2025-04-03 13:53:55)\n> The computed AWB gains are applied when constructing LUT tables rather\n> than in awb.cpp itself. This can look confusing when reading awb.cpp,\n> let's add a clarifying comment.\n> \n> Signed-off-by: Milan Zamazal \n\nI don't object:\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/simple/algorithms/awb.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index 55719059..cf567e89 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -40,6 +40,7 @@ void Awb::prepare(IPAContext &context,\n> [[maybe_unused]] DebayerParams *params)\n> {\n> auto &gains = context.activeState.awb.gains;\n> + /* Just report, the gains are applied in LUT algorithm. */\n> frameContext.gains.red = gains.r();\n> frameContext.gains.blue = gains.b();\n> }\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC08BC3213\n\tfor ;\n\tFri, 4 Apr 2025 15:44:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E418D61867;\n\tFri, 4 Apr 2025 17:44:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78CFF61867\n\tfor ;\n\tFri, 4 Apr 2025 17:44:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EDAE7129;\n\tFri, 4 Apr 2025 17:42:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VUn80TM2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743781372;\n\tbh=C3zlDCTsZVJp8TjG9Ah4Ii/jUy0I0jZJ1kg5iuMfyVI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VUn80TM2ZgoA3N082UQ6MOmwt3992bXZ7hmZW3YdU5j+/Vo1VGPwFsIyUPrw9HGQw\n\tGJFxx77ZAxzGoDiexjCdNn4ufIo/oNpGcpx6vnpmfgKB6VNI59mZP8E6ef/3UOx12e\n\t5e+N+YLklTgcZPk+uWrzeSVSwmX6yiAbrfkEEMII=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250403125355.76062-1-mzamazal@redhat.com>","References":"<20250403125355.76062-1-mzamazal@redhat.com>","Subject":"Re: [PATCH] libcamera: software_isp: Add a clarification comment to\n\tAWB","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Fri, 04 Apr 2025 16:44:43 +0100","Message-ID":"<174378148309.2166729.5552451891463223441@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33919,"web_url":"https://patchwork.libcamera.org/comment/33919/","msgid":"<20250404172432.GL4845@pendragon.ideasonboard.com>","date":"2025-04-04T17:24:32","subject":"Re: [PATCH] libcamera: software_isp: Add a clarification comment to\n\tAWB","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 04, 2025 at 04:44:43PM +0100, Kieran Bingham wrote:\n> Quoting Milan Zamazal (2025-04-03 13:53:55)\n> > The computed AWB gains are applied when constructing LUT tables rather\n> > than in awb.cpp itself. This can look confusing when reading awb.cpp,\n> > let's add a clarifying comment.\n> > \n> > Signed-off-by: Milan Zamazal \n> \n> I don't object:\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/ipa/simple/algorithms/awb.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> > index 55719059..cf567e89 100644\n> > --- a/src/ipa/simple/algorithms/awb.cpp\n> > +++ b/src/ipa/simple/algorithms/awb.cpp\n> > @@ -40,6 +40,7 @@ void Awb::prepare(IPAContext &context,\n> > [[maybe_unused]] DebayerParams *params)\n> > {\n> > auto &gains = context.activeState.awb.gains;\n> > + /* Just report, the gains are applied in LUT algorithm. */\n> > frameContext.gains.red = gains.r();\n> > frameContext.gains.blue = gains.b();\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 930A5C3213\n\tfor ;\n\tFri, 4 Apr 2025 17:24:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7958689A1;\n\tFri, 4 Apr 2025 19:24:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36A8D68991\n\tfor ;\n\tFri, 4 Apr 2025 19:24:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 683B0581;\n\tFri, 4 Apr 2025 19:23:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S8DNJpt/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743787383;\n\tbh=FFUDH6am5IEhW+cGo9DJF22/zbH4atd8LGy/t/DekL4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=S8DNJpt//rHpCu6MfJ8GAHUueYE/xQJsCbhxZJ3tBRoqVkdoGjGOtPGYK+L9KOYhi\n\tLOZOKuW+8OAHEYaMT/6bErET8e7bvNRJ4Ds9xKwf87hbkjkrlwHx7S9p8P0OCHyUpP\n\tf0JmejmNf2eQsImORx3z/3IYGFnBl/jKMFDKut1w=","Date":"Fri, 4 Apr 2025 20:24:32 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: software_isp: Add a clarification comment to\n\tAWB","Message-ID":"<20250404172432.GL4845@pendragon.ideasonboard.com>","References":"<20250403125355.76062-1-mzamazal@redhat.com>\n\t<174378148309.2166729.5552451891463223441@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174378148309.2166729.5552451891463223441@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]