[{"id":33902,"web_url":"https://patchwork.libcamera.org/comment/33902/","msgid":"<174366767396.4065590.17986469377184820208@ping.linuxembedded.co.uk>","date":"2025-04-03T08:07:53","subject":"Re: [PATCH v7 2/5] pipeline: simple: Connect/disconnect frameStart\n\tsignal at start/stop time","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stanislaw Gruszka (2025-04-03 08:45:48)\n> The frameStart signal from the frame start emitter is connected in the\n> configure() function, and is never disconnected. This means that each\n> time the camera is configured a new connection is made, causing the\n> DelayedControls::applyControls() to be called multiple times. Fix it by\n> connecting and disconnecting the signal when starting and stopping the\n> camera.\n> \n> Reviewed-by: Stefan Klug # v6\n> Co-developed-by: Hans de Goede \n> Signed-off-by: Hans de Goede \n> Co-developed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Stanislaw Gruszka \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index fd0ccdca8ebe..06e805d89caa 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1371,8 +1371,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> data->delayedCtrls_ =\n> std::make_unique(data->sensor_->device(),\n> params);\n> - data->video_->frameStart.connect(data->delayedCtrls_.get(),\n> - &DelayedControls::applyControls);\n> \n> StreamConfiguration inputCfg;\n> inputCfg.pixelFormat = pipeConfig->captureFormat;\n> @@ -1440,6 +1438,9 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n> \n> video->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n> \n> + data->video_->frameStart.connect(data->delayedCtrls_.get(),\n> + &DelayedControls::applyControls);\n> +\n> ret = video->streamOn();\n> if (ret < 0) {\n> stop(camera);\n> @@ -1472,6 +1473,9 @@ void SimplePipelineHandler::stopDevice(Camera *camera)\n> SimpleCameraData *data = cameraData(camera);\n> V4L2VideoDevice *video = data->video_;\n> \n> + data->video_->frameStart.disconnect(data->delayedCtrls_.get(),\n> + &DelayedControls::applyControls);\n> +\n> if (data->useConversion_) {\n> if (data->converter_)\n> data->converter_->stop();\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1987BC327D\n\tfor ;\n\tThu, 3 Apr 2025 08:07:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE45068996;\n\tThu, 3 Apr 2025 10:07:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 128E068967\n\tfor ;\n\tThu, 3 Apr 2025 10:07:56 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96EDA11E9;\n\tThu, 3 Apr 2025 10:06:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l+xpH+Fz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743667562;\n\tbh=4mWbhi71LpoAGW7mPPcJ6lzsghrHgIPpaXgyuM+R3ZU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=l+xpH+FzFxZWrnY1p9XwDltLKA96uhYJUIo14ljgW8u7eF535ybD9wk9uxz0iR1Um\n\tcqXS18NX+ohqd7jDKUdDWKcecGmbgUud/AJGjE8mMmu9sox4Wm8PtMmh7oNDfN5BSR\n\tb52L3vZAdfh1w+gvxBwLNBUqzY07WL61nggvDVNU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250403074551.263496-3-stanislaw.gruszka@linux.intel.com>","References":"<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>\n\t<20250403074551.263496-3-stanislaw.gruszka@linux.intel.com>","Subject":"Re: [PATCH v7 2/5] pipeline: simple: Connect/disconnect frameStart\n\tsignal at start/stop time","From":"Kieran Bingham ","Cc":"Milan Zamazal , Hans de Goede ,\n\tLaurent Pinchart ,\n\tSakari Ailus ,\n\tStefan Klug ","To":"Stanislaw Gruszka ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 03 Apr 2025 09:07:53 +0100","Message-ID":"<174366767396.4065590.17986469377184820208@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]