[{"id":33896,"web_url":"https://patchwork.libcamera.org/comment/33896/","msgid":"<20250402155448.GH13762@pendragon.ideasonboard.com>","date":"2025-04-02T15:54:48","subject":"Re: [PATCH v2] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Apr 02, 2025 at 05:11:58PM +0200, Barnabás Pőcze wrote:\n> The `AeEnable` control is handled by the `Camera` class directly, but it\n> still has to be added because `ControlInfoMap`s are not easily modifiable.\n> \n> See 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\n> for more details and a similar change in rkisp1.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> changes in v2:\n> * only report control if it can actually do something\n> \n> v1: https://patchwork.libcamera.org/patch/23106/\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 5adc89fdb..a7e0fcfbc 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -590,6 +590,11 @@ int UVCCameraData::init(MediaDevice *media)\n> \t\taddControl(cid, info, &ctrls);\n> \t}\n> \n> +\tif (autoExposureMode_ && manualExposureMode_) {\n> +\t\t/* \\todo Move this to the Camera class */\n> +\t\tctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n> +\t}\n> +\n> \tcontrolInfo_ = ControlInfoMap(std::move(ctrls), controls::controls);\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF44DC323E\n\tfor ;\n\tWed, 2 Apr 2025 15:55:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E84168985;\n\tWed, 2 Apr 2025 17:55:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63CB868979\n\tfor ;\n\tWed, 2 Apr 2025 17:55:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D0EC63B;\n\tWed, 2 Apr 2025 17:53:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gGHFj9nN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743609199;\n\tbh=ka5KBYIBkfh/6yanpU98DXMgw01TXa5i0+Nvkr0qoj4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gGHFj9nNkN+mUW80Vgycg9wuHhr7blxd0P+d6clQ/bMrIoUFwx11JXfANZa8eOJ+3\n\ttMA4Be6uJjErm7wnm6u/X1Aux28tsQoWJ7yk/xQT9xscC6b6ESgm0jgoSN/Tzo6xN5\n\tw9h+dqtDmcPKm2kL1hA8+lHpFnfbFKKh9snxCSDM=","Date":"Wed, 2 Apr 2025 18:54:48 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","Message-ID":"<20250402155448.GH13762@pendragon.ideasonboard.com>","References":"<20250402151158.968707-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250402151158.968707-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33897,"web_url":"https://patchwork.libcamera.org/comment/33897/","msgid":"<174360982670.494853.7700901145881183692@ping.linuxembedded.co.uk>","date":"2025-04-02T16:03:46","subject":"Re: [PATCH v2] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-02 16:11:58)\n> The `AeEnable` control is handled by the `Camera` class directly, but it\n> still has to be added because `ControlInfoMap`s are not easily modifiable.\n> \n> See 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\n> for more details and a similar change in rkisp1.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Jacopo Mondi \n> ---\n> changes in v2:\n> * only report control if it can actually do something\n\nThat was my only worry on v1!\n\nReviewed-by: Kieran Bingham \n\n> \n> v1: https://patchwork.libcamera.org/patch/23106/\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 5adc89fdb..a7e0fcfbc 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -590,6 +590,11 @@ int UVCCameraData::init(MediaDevice *media)\n> addControl(cid, info, &ctrls);\n> }\n> \n> + if (autoExposureMode_ && manualExposureMode_) {\n> + /* \\todo Move this to the Camera class */\n> + ctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n> + }\n> +\n> controlInfo_ = ControlInfoMap(std::move(ctrls), controls::controls);\n> \n> /*\n> --\n> 2.49.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B4B4C323E\n\tfor ;\n\tWed, 2 Apr 2025 16:03:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66D6768996;\n\tWed, 2 Apr 2025 18:03:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8691168979\n\tfor ;\n\tWed, 2 Apr 2025 18:03:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 745F46A2;\n\tWed, 2 Apr 2025 18:01:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lb6epiXl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743609716;\n\tbh=NKcu1BiKMJCUkktJnVi+cehA7qGUVWtRSIOf5q9xzJw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lb6epiXlSo1I59RsVbDL0PI6oxp0vc8vaqdb/oSBFa/u+LCtSCSawFFCr7dWX/2Zu\n\tmnIro24BQehzFQg886Q2yqwuA9FfZt/8Rk9Wxhn7LB7monM2Y7uWSd/dfHD69kxbKG\n\t4RIUZtA2TLFVt24q2/UliTGwx2PlkQ6PNw4WnZD8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250402151158.968707-1-barnabas.pocze@ideasonboard.com>","References":"<20250402151158.968707-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","From":"Kieran Bingham ","Cc":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 02 Apr 2025 17:03:46 +0100","Message-ID":"<174360982670.494853.7700901145881183692@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]