[{"id":33886,"web_url":"https://patchwork.libcamera.org/comment/33886/","msgid":"","date":"2025-04-02T12:57:42","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Wed, Apr 02, 2025 at 01:49:28PM +0200, Barnabás Pőcze wrote:\n> The `AeEnable` control is handled by the `Camera` class directly, but it\n> still has to be added because `ControlInfoMap`s are not easily modifiable.\n>\n> See 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\n> for more details and a similar change in rkisp1.\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 5adc89fdb..ab180e820 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -583,6 +583,9 @@ int UVCCameraData::init(MediaDevice *media)\n> \t/* Initialise the supported controls. */\n> \tControlInfoMap::Map ctrls;\n>\n> +\t/* \\todo Move this to the Camera class */\n> +\tctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n> +\n\nThe patch is fine, I wonder however if we shouldn't just be adding\nthis to all pipelines. My understanding is that we can't do it in the\nCamera class a controls is a const, so once populated by the pipeline\nit can't be modified. However at the moment 4 pipeline handlers (mali,\nrkisp1, rpi and now uvc) registers this, other pipelines (the ipu3 one\nin particular) only expose ExposureTimeMode and AnalogueGainMode.\n\nFor this patch\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \tfor (const auto &ctrl : video_->controls()) {\n> \t\tuint32_t cid = ctrl.first->id();\n> \t\tconst ControlInfo &info = ctrl.second;\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C35C5C3213\n\tfor ;\n\tWed, 2 Apr 2025 12:57:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 859E96897E;\n\tWed, 2 Apr 2025 14:57:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CC0C68979\n\tfor ;\n\tWed, 2 Apr 2025 14:57:45 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8656763B;\n\tWed, 2 Apr 2025 14:55:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aKmCkPcm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743598552;\n\tbh=mRmSnIYujaugp2BTjri7y3lxsPqLMyRwTOrTepq3rIA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aKmCkPcm7f244U3cQhbW4YT9UE12ss3GMPw6/FZ7m6aAY7vrcjKJpVmBadcf4H2UT\n\t1rHOHapxs/ZhYkD7Yl6k2OjKlMR2dWIPxBs205MzKV/4k4Qlmv3ylPCQuEMRlpgJ8S\n\t7xg5L5+4IoM3xCnzKDauGydT5cGXSaPQy02tn8/c=","Date":"Wed, 2 Apr 2025 14:57:42 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","Message-ID":"","References":"<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33889,"web_url":"https://patchwork.libcamera.org/comment/33889/","msgid":"<20250402144002.GD13762@pendragon.ideasonboard.com>","date":"2025-04-02T14:40:02","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Apr 02, 2025 at 01:49:28PM +0200, Barnabás Pőcze wrote:\n> The `AeEnable` control is handled by the `Camera` class directly, but it\n> still has to be added because `ControlInfoMap`s are not easily modifiable.\n> \n> See 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\n> for more details and a similar change in rkisp1.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 5adc89fdb..ab180e820 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -583,6 +583,9 @@ int UVCCameraData::init(MediaDevice *media)\n> \t/* Initialise the supported controls. */\n> \tControlInfoMap::Map ctrls;\n> \n> +\t/* \\todo Move this to the Camera class */\n> +\tctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n\nShouldn't this be done only for camera that support the\nV4L2_CID_EXPOSURE_AUTO control ?\n\n> +\n> \tfor (const auto &ctrl : video_->controls()) {\n> \t\tuint32_t cid = ctrl.first->id();\n> \t\tconst ControlInfo &info = ctrl.second;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D111C323E\n\tfor ;\n\tWed, 2 Apr 2025 14:40:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4B716898E;\n\tWed, 2 Apr 2025 16:40:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73A6F68979\n\tfor ;\n\tWed, 2 Apr 2025 16:40:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B60B63B;\n\tWed, 2 Apr 2025 16:38:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O1TQ5QS4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743604713;\n\tbh=dFbfyYN+3/s4AKK5oCWBduTLJHmFtxdyIFP15ipEfLg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=O1TQ5QS43WZFCEPJelC5YCnZASSs0LTaO38jOlSSZzxNChPHHwBiruL/+K43q1ZtF\n\tDLL/SfnczyJFguh0wENizpXTqb2cu0ylGsYIK8jg2P/4xPuIcG/jmXXcXOTOYRW6fK\n\tS3T6OMvg+NvO9BRYH1XqkRSO73y1Rj6gJgHPd8WU=","Date":"Wed, 2 Apr 2025 17:40:02 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","Message-ID":"<20250402144002.GD13762@pendragon.ideasonboard.com>","References":"<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33893,"web_url":"https://patchwork.libcamera.org/comment/33893/","msgid":"","date":"2025-04-02T15:12:03","subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 04. 02. 16:40 keltezéssel, Laurent Pinchart írta:\n> On Wed, Apr 02, 2025 at 01:49:28PM +0200, Barnabás Pőcze wrote:\n>> The `AeEnable` control is handled by the `Camera` class directly, but it\n>> still has to be added because `ControlInfoMap`s are not easily modifiable.\n>>\n>> See 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\n>> for more details and a similar change in rkisp1.\n>>\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n>> 1 file changed, 3 insertions(+)\n>>\n>> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> index 5adc89fdb..ab180e820 100644\n>> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> @@ -583,6 +583,9 @@ int UVCCameraData::init(MediaDevice *media)\n>> \t/* Initialise the supported controls. */\n>> \tControlInfoMap::Map ctrls;\n>> \n>> +\t/* \\todo Move this to the Camera class */\n>> +\tctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n> \n> Shouldn't this be done only for camera that support the\n> V4L2_CID_EXPOSURE_AUTO control ?\n\nAhh, yes, indeed, you're right.\n\n\n> \n>> +\n>> \tfor (const auto &ctrl : video_->controls()) {\n>> \t\tuint32_t cid = ctrl.first->id();\n>> \t\tconst ControlInfo &info = ctrl.second;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC6AFC3285\n\tfor ;\n\tWed, 2 Apr 2025 15:12:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 466D368998;\n\tWed, 2 Apr 2025 17:12:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4E336897E\n\tfor ;\n\tWed, 2 Apr 2025 17:12:06 +0200 (CEST)","from [192.168.33.20] (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D30177E0;\n\tWed, 2 Apr 2025 17:10:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J7UXGnw0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743606614;\n\tbh=vjyHFBkFEeqeSyQ7mkanpYmFF5ODKUW/Cto4mVlFAGM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=J7UXGnw0iwW+K1DBOr7GSFg7teCHj2QQoMZTZMRn8mU525mfh+B/M9yLfNp6GYOXH\n\tU0pdHC+9SZOeNFkp+ePN7GpJvn0x9/+xzlngFc6JQh+DsZhWXkO630Zo1hH/FD7JnN\n\tNkA4n0LljhltXe+s8GaLnHx69LQxVwWmFb6+iDoU=","Message-ID":"","Date":"Wed, 2 Apr 2025 17:12:03 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>\n\t<20250402144002.GD13762@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250402144002.GD13762@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]