[{"id":33854,"web_url":"https://patchwork.libcamera.org/comment/33854/","msgid":"","date":"2025-04-01T14:18:54","subject":"Re: [PATCH v2] ipa: simple: Initialize ccmEnabled to false","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/people/211/","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"content":"On Tue, Apr 01, 2025 at 04:14:55PM +0200, Stanislaw Gruszka wrote:\n> ccmEnabled variable is not initialized by default, which results in\n> usage of CCM when the algorithm itself is not enabled and configured.\n> \n> The bug manifests itself as seldom reproducible corrupted video stream.\n> Fix by initialize the variable in IPAContext class initialization list.\n\nForgot to fix \"initialization list\" here, will post v3\n\n> Reviewed-by: Milan Zamazal \n> Reviewed-by: Laurent Pinchart \n> Fixes: ac3068655643 (\"libcamera: software_isp: Track whether CCM is enabled\")\n> Signed-off-by: Stanislaw Gruszka \n> ---\n> v1 -> v2:\n> - initialize on declaration \n> - fix spelling\n> \n> src/ipa/simple/ipa_context.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n> index 7dc2cd7ae828..51522720ab98 100644\n> --- a/src/ipa/simple/ipa_context.h\n> +++ b/src/ipa/simple/ipa_context.h\n> @@ -91,7 +91,7 @@ struct IPAContext {\n> \tIPAActiveState activeState;\n> \tFCQueue frameContexts;\n> \tControlInfoMap::Map ctrlMap;\n> -\tbool ccmEnabled;\n> +\tbool ccmEnabled = false;\n> };\n> \n> } /* namespace ipa::soft */\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEBEEC323E\n\tfor ;\n\tTue, 1 Apr 2025 14:19:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAE6368962;\n\tTue, 1 Apr 2025 16:19:02 +0200 (CEST)","from mgamail.intel.com (mgamail.intel.com [192.198.163.13])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C178668947\n\tfor ;\n\tTue, 1 Apr 2025 16:18:59 +0200 (CEST)","from orviesa002.jf.intel.com ([10.64.159.142])\n\tby fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t01 Apr 2025 07:18:58 -0700","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.112.43]) by orviesa002-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 07:18:57 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"ClWuS6lc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743517140; x=1775053140;\n\th=date:from:to:cc:subject:message-id:references:\n\tmime-version:in-reply-to;\n\tbh=dA1LqpJlyK/dV/7HB+h3ISh1aAIUKBkYvFMY02cdQa0=;\n\tb=ClWuS6lc8kasHSUHkvpPpsopAZhTtkIYBbcvWaY93d/876RE7QdY20ge\n\tSB3i7I9PM3VpzvZVOGiYBte2RxXvlxzT/n1CngJyPCfK9NGEf/wMDUSOX\n\tderIWu57RmMzwNPyPnS677pKvnaa/3PoNOC8rgbtzYLdu2U8SmDLPfx2J\n\t88devgDqp/MRbPxbTq85u/msKuoh+grm0UGVOcCI4F/H+Qp4vmdy8I8QM\n\tKcOKZdGa1eCk3RDaoI6hjScOrxDkEKw02FIauwZO6GspcQ3f+HU9EcHRk\n\ttY+cyZyTvB2sNv9VVCHq1EGLlPSrnYOLKF/5ulrWO+2siwjoNA6sH/VY4 A==;","X-CSE-ConnectionGUID":["0+r8jjcvQbaFoq3XrQHdCg==","KYb5l64WTRCw4iEyVR4axw=="],"X-CSE-MsgGUID":["5P9ZpjDTTzyvPh76+ps+tA==","U4BOh/GbTCuffPtdd5Iogw=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11391\"; a=\"47563401\"","E=Sophos;i=\"6.14,293,1736841600\"; d=\"scan'208\";a=\"47563401\"","E=Sophos;i=\"6.14,293,1736841600\"; d=\"scan'208\";a=\"157344178\""],"X-ExtLoop1":"1","Date":"Tue, 1 Apr 2025 16:18:54 +0200","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Hans de Goede ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tSakari Ailus ","Subject":"Re: [PATCH v2] ipa: simple: Initialize ccmEnabled to false","Message-ID":"","References":"<20250401141455.492231-1-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250401141455.492231-1-stanislaw.gruszka@linux.intel.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]