[{"id":33852,"web_url":"https://patchwork.libcamera.org/comment/33852/","msgid":"<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>","date":"2025-04-01T14:03:28","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n> `AeEnable` control from gen-gst-controls.py. However, the patch\n> set it was part of did not end up removing the `AeEnable`\n> control after all. So restore it for gstreamer users.\n> \n> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n> \n\nDoes this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\nautomatics\" ?\n\nIf so, lets add:\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=261\n\n> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n> Signed-off-by: Barnabás Pőcze \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> utils/codegen/gen-gst-controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> index 07af7653b..4ca76049e 100755\n> --- a/utils/codegen/gen-gst-controls.py\n> +++ b/utils/codegen/gen-gst-controls.py\n> @@ -19,7 +19,7 @@ from controls import Control\n> \n> \n> exposed_controls = [\n> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A443C323E\n\tfor ;\n\tTue, 1 Apr 2025 14:03:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A73168962;\n\tTue, 1 Apr 2025 16:03:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7984B68947\n\tfor ;\n\tTue, 1 Apr 2025 16:03:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28F786F9;\n\tTue, 1 Apr 2025 16:01:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I6FHlVET\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743516099;\n\tbh=ZkR0IDyQDVf6AVNz885l8sbaAGKkRSSzriPhC1YkT2w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=I6FHlVETmp9/CzFStDmB3bsHfGitgp4MSmQI2mgn3+R1Se38EYC2rY0oCdKmJlpwz\n\trPWaF3rboBoxnhxb6GQxYQJ6qR+xpD+sFk6qunGA/4UAwFR386aJyufYBueDxQHunz\n\tgJXeH9auTxqL+vmiAh9Fc1khTc/M8aU+InwWZJLQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 01 Apr 2025 15:03:28 +0100","Message-ID":"<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33853,"web_url":"https://patchwork.libcamera.org/comment/33853/","msgid":"","date":"2025-04-01T14:05:27","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 04. 01. 16:03 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n>> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n>> `AeEnable` control from gen-gst-controls.py. However, the patch\n>> set it was part of did not end up removing the `AeEnable`\n>> control after all. So restore it for gstreamer users.\n>>\n>> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n>>\n> \n> Does this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\n> automatics\" ?\n\nNo, I don't think so. The \"removal\" has not been in any libcamera release yet.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> If so, lets add:\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=261\n> \n>> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n>> Signed-off-by: Barnabás Pőcze \n> \n> \n> Reviewed-by: Kieran Bingham \n> \n>> ---\n>> utils/codegen/gen-gst-controls.py | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n>> index 07af7653b..4ca76049e 100755\n>> --- a/utils/codegen/gen-gst-controls.py\n>> +++ b/utils/codegen/gen-gst-controls.py\n>> @@ -19,7 +19,7 @@ from controls import Control\n>> \n>> \n>> exposed_controls = [\n>> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n>> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n>> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n>> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n>> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n>> -- \n>> 2.49.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB90CC323E\n\tfor ;\n\tTue, 1 Apr 2025 14:05:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DF9D68987;\n\tTue, 1 Apr 2025 16:05:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B2EA68947\n\tfor ;\n\tTue, 1 Apr 2025 16:05:30 +0200 (CEST)","from [192.168.33.14] (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E99676F9;\n\tTue, 1 Apr 2025 16:03:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JF+LzCQx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743516218;\n\tbh=md83XMRrkCgcfk+VXob7Ockca1LdMzYxQj5uQXxoEBI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=JF+LzCQxzPeAXMP7h5/MW5/FIKBOsgbaSK97uAGmSngNkT+z0qi0anCjYVuPSUtt0\n\tGvc4LpfYcIJCYPr+06mdoCpbJvpKExIlKInZ/vGKQ+MwQgMe3PqzGdWEi9g3JXvTNs\n\tlnqOWs1r/xHRyT9ghtXBBvYbKULEyZksE3kymLZc=","Message-ID":"","Date":"Tue, 1 Apr 2025 16:05:27 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>\n\t<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33856,"web_url":"https://patchwork.libcamera.org/comment/33856/","msgid":"<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>","date":"2025-04-01T15:41:44","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-04-01 15:05:27)\n> Hi\n> \n> 2025. 04. 01. 16:03 keltezéssel, Kieran Bingham írta:\n> > Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n> >> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n> >> `AeEnable` control from gen-gst-controls.py. However, the patch\n> >> set it was part of did not end up removing the `AeEnable`\n> >> control after all. So restore it for gstreamer users.\n> >>\n> >> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n> >>\n> > \n> > Does this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\n> > automatics\" ?\n> \n> No, I don't think so. The \"removal\" has not been in any libcamera release yet.\n> \n\nOk, no worries - so lets get this in to stop it being a mistake :-)\n\nThanks\n--\nKieran\n\n> \n> Regards,\n> Barnabás Pőcze\n> \n> > \n> > If so, lets add:\n> > \n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=261\n> > \n> >> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n> >> Signed-off-by: Barnabás Pőcze \n> > \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> >> ---\n> >> utils/codegen/gen-gst-controls.py | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> >> index 07af7653b..4ca76049e 100755\n> >> --- a/utils/codegen/gen-gst-controls.py\n> >> +++ b/utils/codegen/gen-gst-controls.py\n> >> @@ -19,7 +19,7 @@ from controls import Control\n> >> \n> >> \n> >> exposed_controls = [\n> >> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> >> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> >> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> >> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> >> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> >> -- \n> >> 2.49.0\n> >>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5AD6C323E\n\tfor ;\n\tTue, 1 Apr 2025 15:41:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E75168981;\n\tTue, 1 Apr 2025 17:41:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9626A68947\n\tfor ;\n\tTue, 1 Apr 2025 17:41:47 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3412A741;\n\tTue, 1 Apr 2025 17:39:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zx+cNDVM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743521995;\n\tbh=7IUcEQfrzrWwsGrmt41Jk9PYSp+K6TrgAWHEn3Eqels=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Zx+cNDVM3HgJHu7yqAwKkNgZ552a8Xp4LG4XT0cDCA2Kgi8gVNU26UW/oSdVD0Vua\n\t4Z72PlSwy24R8QxdNR8oaQPq54R9i0GfC0/gi5e9/iMxDLOICaSfp3UU9n2UpBs0cH\n\tjol+AGnZ7xW8WTgId49bW3yITGL6wxBTQn5Jk89c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>\n\t<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>\n\t","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 01 Apr 2025 16:41:44 +0100","Message-ID":"<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33858,"web_url":"https://patchwork.libcamera.org/comment/33858/","msgid":"<20250401182123.GA3494@pendragon.ideasonboard.com>","date":"2025-04-01T18:21:23","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 01, 2025 at 04:41:44PM +0100, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2025-04-01 15:05:27)\n> > 2025. 04. 01. 16:03 keltezéssel, Kieran Bingham írta:\n> > > Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n> > >> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n> > >> `AeEnable` control from gen-gst-controls.py. However, the patch\n> > >> set it was part of did not end up removing the `AeEnable`\n> > >> control after all. So restore it for gstreamer users.\n> > >>\n> > >> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n> > > \n> > > Does this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\n> > > automatics\" ?\n> > \n> > No, I don't think so. The \"removal\" has not been in any libcamera release yet.\n> \n> Ok, no worries - so lets get this in to stop it being a mistake :-)\n\nIf I recall correctly, libcamerasrc mistakenly feeds back metadata into\ncontrols at the moment. This has to be fixed and the issue is unrelated\nto this patch, but I'm wondering if adding back AeEnable could cause\nhorrible feedback loops. If you've tested this carefully and\nsuccessfully,\n\nReviewed-by: Laurent Pinchart \n\n> > > If so, lets add:\n> > > \n> > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=261\n> > > \n> > >> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n> > >> Signed-off-by: Barnabás Pőcze \n> > > \n> > > Reviewed-by: Kieran Bingham \n> > > \n> > >> ---\n> > >> utils/codegen/gen-gst-controls.py | 2 +-\n> > >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >>\n> > >> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> > >> index 07af7653b..4ca76049e 100755\n> > >> --- a/utils/codegen/gen-gst-controls.py\n> > >> +++ b/utils/codegen/gen-gst-controls.py\n> > >> @@ -19,7 +19,7 @@ from controls import Control\n> > >> \n> > >> \n> > >> exposed_controls = [\n> > >> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > >> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > >> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> > >> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> > >> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1750CC323E\n\tfor ;\n\tTue, 1 Apr 2025 18:21:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5345868981;\n\tTue, 1 Apr 2025 20:21:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2300468947\n\tfor ;\n\tTue, 1 Apr 2025 20:21:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E2C96F9;\n\tTue, 1 Apr 2025 20:19:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fVnKUfRn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743531596;\n\tbh=1gjK5PZtrpnPqVyH+jbfb0izUM5MOcJvt25SIZNWZyo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fVnKUfRnL+ETcLUszn6RfULUjdKSj3tjLtzWeLRcggoqPVqIHVgE2J/xijBoFh5c5\n\tZbGxo+kWvcluhFuLKv+kN/aSR1YU0l7oqKkgl3Ot87ITZFDfu/eRnnmXvXFtiQsJLS\n\t9PQIUay1/wygF7TwX25q1P3KLPf23uXGgIMxXIRQ=","Date":"Tue, 1 Apr 2025 21:21:23 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","Message-ID":"<20250401182123.GA3494@pendragon.ideasonboard.com>","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>\n\t<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>\n\t\n\t<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33861,"web_url":"https://patchwork.libcamera.org/comment/33861/","msgid":"","date":"2025-04-01T18:26:32","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 04. 01. 20:21 keltezéssel, Laurent Pinchart írta:\n> On Tue, Apr 01, 2025 at 04:41:44PM +0100, Kieran Bingham wrote:\n>> Quoting Barnabás Pőcze (2025-04-01 15:05:27)\n>>> 2025. 04. 01. 16:03 keltezéssel, Kieran Bingham írta:\n>>>> Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n>>>>> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n>>>>> `AeEnable` control from gen-gst-controls.py. However, the patch\n>>>>> set it was part of did not end up removing the `AeEnable`\n>>>>> control after all. So restore it for gstreamer users.\n>>>>>\n>>>>> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n>>>>\n>>>> Does this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\n>>>> automatics\" ?\n>>>\n>>> No, I don't think so. The \"removal\" has not been in any libcamera release yet.\n>>\n>> Ok, no worries - so lets get this in to stop it being a mistake :-)\n> \n> If I recall correctly, libcamerasrc mistakenly feeds back metadata into\n> controls at the moment. This has to be fixed and the issue is unrelated\n> to this patch, but I'm wondering if adding back AeEnable could cause\n> horrible feedback loops. If you've tested this carefully and\n> successfully,\n\nIs it reported in metadata? As far as I can see it has `direction: in` since\n85cb179f289d29 (\"controls: Redefine AeEnable\"). But I'll double check.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n>>>> If so, lets add:\n>>>>\n>>>> Bug: https://bugs.libcamera.org/show_bug.cgi?id=261\n>>>>\n>>>>> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n>>>>> Signed-off-by: Barnabás Pőcze \n>>>>\n>>>> Reviewed-by: Kieran Bingham \n>>>>\n>>>>> ---\n>>>>> utils/codegen/gen-gst-controls.py | 2 +-\n>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>>\n>>>>> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n>>>>> index 07af7653b..4ca76049e 100755\n>>>>> --- a/utils/codegen/gen-gst-controls.py\n>>>>> +++ b/utils/codegen/gen-gst-controls.py\n>>>>> @@ -19,7 +19,7 @@ from controls import Control\n>>>>> \n>>>>> \n>>>>> exposed_controls = [\n>>>>> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n>>>>> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n>>>>> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n>>>>> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n>>>>> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4B0DC3213\n\tfor ;\n\tTue, 1 Apr 2025 18:26:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C2B568981;\n\tTue, 1 Apr 2025 20:26:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE0ED68947\n\tfor ;\n\tTue, 1 Apr 2025 20:26:54 +0200 (CEST)","from [192.168.33.14] (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 579208DB;\n\tTue, 1 Apr 2025 20:25:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l3FTMq00\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743531902;\n\tbh=P6sfvOCkCq4fsR4dZF56tMIottzDVFfICLpmlyaqg/U=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=l3FTMq0019g5/FS8f+OSOSZiyhKqeOazskhuJTs9oO0+VOxwYViO5t4yYUOSa6qQa\n\tfH0tzEPgDeSwmVb72EO9P1tK/TcRmdaRM3hFUgl4ZVulkmWtV1lwEl/F9RJINZ0+u1\n\tpBMC/J2jCN1grK19+Z17Tex+DnuYKeq+b/ttXv/E=","Message-ID":"","Date":"Tue, 1 Apr 2025 20:26:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","To":"Laurent Pinchart ,\n\tKieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>\n\t<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>\n\t\n\t<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>\n\t<20250401182123.GA3494@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250401182123.GA3494@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33862,"web_url":"https://patchwork.libcamera.org/comment/33862/","msgid":"<20250401183522.GD3494@pendragon.ideasonboard.com>","date":"2025-04-01T18:35:22","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 01, 2025 at 08:26:32PM +0200, Barnabás Pőcze wrote:\n> 2025. 04. 01. 20:21 keltezéssel, Laurent Pinchart írta:\n> > On Tue, Apr 01, 2025 at 04:41:44PM +0100, Kieran Bingham wrote:\n> >> Quoting Barnabás Pőcze (2025-04-01 15:05:27)\n> >>> 2025. 04. 01. 16:03 keltezéssel, Kieran Bingham írta:\n> >>>> Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n> >>>>> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n> >>>>> `AeEnable` control from gen-gst-controls.py. However, the patch\n> >>>>> set it was part of did not end up removing the `AeEnable`\n> >>>>> control after all. So restore it for gstreamer users.\n> >>>>>\n> >>>>> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n> >>>>\n> >>>> Does this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\n> >>>> automatics\" ?\n> >>>\n> >>> No, I don't think so. The \"removal\" has not been in any libcamera release yet.\n> >>\n> >> Ok, no worries - so lets get this in to stop it being a mistake :-)\n> > \n> > If I recall correctly, libcamerasrc mistakenly feeds back metadata into\n> > controls at the moment. This has to be fixed and the issue is unrelated\n> > to this patch, but I'm wondering if adding back AeEnable could cause\n> > horrible feedback loops. If you've tested this carefully and\n> > successfully,\n> \n> Is it reported in metadata? As far as I can see it has `direction: in` since\n> 85cb179f289d29 (\"controls: Redefine AeEnable\"). But I'll double check.\n\nI think you're right. Hopefully it will be safe then.\n\n> > Reviewed-by: Laurent Pinchart \n> > \n> >>>> If so, lets add:\n> >>>>\n> >>>> Bug: https://bugs.libcamera.org/show_bug.cgi?id=261\n> >>>>\n> >>>>> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n> >>>>> Signed-off-by: Barnabás Pőcze \n> >>>>\n> >>>> Reviewed-by: Kieran Bingham \n> >>>>\n> >>>>> ---\n> >>>>> utils/codegen/gen-gst-controls.py | 2 +-\n> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>>>\n> >>>>> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> >>>>> index 07af7653b..4ca76049e 100755\n> >>>>> --- a/utils/codegen/gen-gst-controls.py\n> >>>>> +++ b/utils/codegen/gen-gst-controls.py\n> >>>>> @@ -19,7 +19,7 @@ from controls import Control\n> >>>>> \n> >>>>> \n> >>>>> exposed_controls = [\n> >>>>> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> >>>>> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> >>>>> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> >>>>> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> >>>>> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72949C323E\n\tfor ;\n\tTue, 1 Apr 2025 18:35:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D16E068985;\n\tTue, 1 Apr 2025 20:35:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D667168947\n\tfor ;\n\tTue, 1 Apr 2025 20:35:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C2046F9;\n\tTue, 1 Apr 2025 20:33:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pViJ2QGz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743532435;\n\tbh=s6QdcURnhKORkXFfq4Jc+YGgF5gAu97ZsdSe1XT6AjQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pViJ2QGzGRvwvW7RDLwxJO8z4WwLy+zTaEpRb1KUwGu9nKpNAEqfcVElszwTKfz5Z\n\tHvE78kRD4sH0P9o2zPPwDwDjuq5CHZTkUcFtGdhVLHNgkDUzYYByJX4i+EJHhVBu2p\n\tJy48TdoESmaQuQnsoMDSs1PL4VLxDs9qGoc1zxKQ=","Date":"Tue, 1 Apr 2025 21:35:22 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","Message-ID":"<20250401183522.GD3494@pendragon.ideasonboard.com>","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>\n\t<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>\n\t\n\t<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>\n\t<20250401182123.GA3494@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33881,"web_url":"https://patchwork.libcamera.org/comment/33881/","msgid":"<196ffcc1-78be-48e0-b638-05bd7eae7159@ideasonboard.com>","date":"2025-04-02T08:55:57","subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. 04. 01. 20:35 keltezéssel, Laurent Pinchart írta:\n> On Tue, Apr 01, 2025 at 08:26:32PM +0200, Barnabás Pőcze wrote:\n>> 2025. 04. 01. 20:21 keltezéssel, Laurent Pinchart írta:\n>>> On Tue, Apr 01, 2025 at 04:41:44PM +0100, Kieran Bingham wrote:\n>>>> Quoting Barnabás Pőcze (2025-04-01 15:05:27)\n>>>>> 2025. 04. 01. 16:03 keltezéssel, Kieran Bingham írta:\n>>>>>> Quoting Barnabás Pőcze (2025-04-01 14:52:57)\n>>>>>>> Commit \"gstreamer: Generate the new AEGC controls\" removed the\n>>>>>>> `AeEnable` control from gen-gst-controls.py. However, the patch\n>>>>>>> set it was part of did not end up removing the `AeEnable`\n>>>>>>> control after all. So restore it for gstreamer users.\n>>>>>>>\n>>>>>>> See 85cb179f289d29 (\"controls: Redefine AeEnable\").\n>>>>>>\n>>>>>> Does this also relate to Bugzilla 261 \"IMX296 on PI 4 / CM4 have no wb\n>>>>>> automatics\" ?\n>>>>>\n>>>>> No, I don't think so. The \"removal\" has not been in any libcamera release yet.\n>>>>\n>>>> Ok, no worries - so lets get this in to stop it being a mistake :-)\n>>>\n>>> If I recall correctly, libcamerasrc mistakenly feeds back metadata into\n>>> controls at the moment. This has to be fixed and the issue is unrelated\n>>> to this patch, but I'm wondering if adding back AeEnable could cause\n>>> horrible feedback loops. If you've tested this carefully and\n>>> successfully,\n>>\n>> Is it reported in metadata? As far as I can see it has `direction: in` since\n>> 85cb179f289d29 (\"controls: Redefine AeEnable\"). But I'll double check.\n> \n> I think you're right. Hopefully it will be safe then.\n\nI don't see any obvious places where it would be reported. The documentation\nalso states \"The AeEnable control is not returned in metadata.\", so I think\neven if it was, that would probably be a bug in libcamera.\n\n\nRegards,\nBarnabás PŐcze\n\n\n> \n>>> Reviewed-by: Laurent Pinchart \n>>>\n>>>>>> If so, lets add:\n>>>>>>\n>>>>>> Bug: https://bugs.libcamera.org/show_bug.cgi?id=261\n>>>>>>\n>>>>>>> Fixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\n>>>>>>> Signed-off-by: Barnabás Pőcze \n>>>>>>\n>>>>>> Reviewed-by: Kieran Bingham \n>>>>>>\n>>>>>>> ---\n>>>>>>> utils/codegen/gen-gst-controls.py | 2 +-\n>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>>>>\n>>>>>>> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n>>>>>>> index 07af7653b..4ca76049e 100755\n>>>>>>> --- a/utils/codegen/gen-gst-controls.py\n>>>>>>> +++ b/utils/codegen/gen-gst-controls.py\n>>>>>>> @@ -19,7 +19,7 @@ from controls import Control\n>>>>>>> \n>>>>>>> \n>>>>>>> exposed_controls = [\n>>>>>>> - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n>>>>>>> + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n>>>>>>> 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n>>>>>>> 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n>>>>>>> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFB3CC3213\n\tfor ;\n\tWed, 2 Apr 2025 08:56:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9F0A68981;\n\tWed, 2 Apr 2025 10:56:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D2D768979\n\tfor ;\n\tWed, 2 Apr 2025 10:56:02 +0200 (CEST)","from [192.168.33.20] (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F1D863B;\n\tWed, 2 Apr 2025 10:54:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b4qr/iQt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743584049;\n\tbh=A0dZsOrg8H0oYO8ceSkFqOeeeu4e+43AXz3c/h1HY7s=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=b4qr/iQt52aVsNN3qHfKutgZWJqr/224ee3yTqtYKVEJ6p7Umk0dvIPVa/AfMDqcK\n\ttSkQfmv3reY8Soih74pOQWCE/o74sFJX5TNmtzz2e43plGgbtqcbDr2T9aj4Vxw2L7\n\tZTkOoNsct3wpHK0pCN9LcVaLnfV26MCY+/G+iJWE=","Message-ID":"<196ffcc1-78be-48e0-b638-05bd7eae7159@ideasonboard.com>","Date":"Wed, 2 Apr 2025 10:55:57 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] gstreamer: Restore `AeEnable` control","To":"Laurent Pinchart ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>\n\t<174351620861.12877.18101346767475504963@ping.linuxembedded.co.uk>\n\t\n\t<174352210444.1342434.1484825149771853755@ping.linuxembedded.co.uk>\n\t<20250401182123.GA3494@pendragon.ideasonboard.com>\n\t\n\t<20250401183522.GD3494@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250401183522.GD3494@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]