[{"id":33867,"web_url":"https://patchwork.libcamera.org/comment/33867/","msgid":"<20250401213308.GF3494@pendragon.ideasonboard.com>","date":"2025-04-01T21:33:08","subject":"Re: [PATCH v1 1/4] libcamera: controls: Simplify SFINAE template\n\tparameter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Apr 01, 2025 at 03:19:36PM +0200, Barnabás Pőcze wrote:\n> Just use `void` instead of `std::void_t<>`.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/controls.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 4bfe9615c..c1919d864 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -43,7 +43,7 @@ enum ControlType {\n> \n> namespace details {\n> \n> -template>\n> +template\n> struct control_type {\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 842ECC3213\n\tfor ;\n\tTue, 1 Apr 2025 21:33:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A60F168947;\n\tTue, 1 Apr 2025 23:33:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47D9468947\n\tfor ;\n\tTue, 1 Apr 2025 23:33:35 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 386CF741;\n\tTue, 1 Apr 2025 23:31:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DDuJvmiD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743543102;\n\tbh=0fscOxQL/vV5o6Mog+rMvaoBLVr6D15lFCgyBeQptQE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DDuJvmiDDLXM1pV6QHYbV/tWXPiDowKeC99I4aLARpDR1lucdqh5Hw3Xeuzmo8MAw\n\tfDwJ96Gnm6XKXMFh8DitI9F7Weq5w7keyQTgPihHhsW3D4/iG02FQ3wAhvtdz4JbtF\n\trwGbfXu5bFJSXA4ZUyK3y7IZculaHPievSiLdZq8=","Date":"Wed, 2 Apr 2025 00:33:08 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/4] libcamera: controls: Simplify SFINAE template\n\tparameter","Message-ID":"<20250401213308.GF3494@pendragon.ideasonboard.com>","References":"<20250401131939.749583-1-barnabas.pocze@ideasonboard.com>\n\t<20250401131939.749583-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250401131939.749583-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]