{"id":23085,"url":"https://patchwork.libcamera.org/api/patches/23085/?format=json","web_url":"https://patchwork.libcamera.org/patch/23085/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250331160301.534243-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-31T16:03:01","name":"[v1] libcamera: base: bound_method: Simplify `invokePack()`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cfaae377b8815c6de3f5955a0096795018863f2a","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23085/mbox/","series":[{"id":5097,"url":"https://patchwork.libcamera.org/api/series/5097/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5097","date":"2025-03-31T16:03:01","name":"[v1] libcamera: base: bound_method: Simplify `invokePack()`","version":1,"mbox":"https://patchwork.libcamera.org/series/5097/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23085/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23085/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E6F2C323E\n\tfor ;\n\tMon, 31 Mar 2025 16:03:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 916F368981;\n\tMon, 31 Mar 2025 18:03:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1AC868967\n\tfor ;\n\tMon, 31 Mar 2025 18:03:05 +0200 (CEST)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CD7F725\n\tfor ;\n\tMon, 31 Mar 2025 18:01:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qEBC4qz9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743436874;\n\tbh=qCR4xxZ9EEZMq8hcisMpPI3tIH0AeY/xwfM345wnlpw=;\n\th=From:To:Subject:Date:From;\n\tb=qEBC4qz9ozG5sqsHKyTYLkZyJPueaSAXngxE0cis8h0yuykOqOUMfMdTCC7p2L4WN\n\tAXDNJyytJnb+DN3uiRMq5XuP1/ZszLSa5CquQKurImW20n68tjXu7G6fkfZn9viAOg\n\tKj3FFZ18wwa388lB+ex+zFBvCNDa4mmziskxWa2c=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: base: bound_method: Simplify `invokePack()`","Date":"Mon, 31 Mar 2025 18:03:01 +0200","Message-ID":"<20250331160301.534243-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use `if constexpr` instead of SFINAE to handle return values of type `void`.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/bound_method.h | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)","diff":"diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\nindex dd3488eeb..aad75c02a 100644\n--- a/include/libcamera/base/bound_method.h\n+++ b/include/libcamera/base/bound_method.h\n@@ -98,21 +98,16 @@ public:\n \tusing PackType = BoundMethodPack;\n \n private:\n-\ttemplate\n-\tstd::enable_if_t::value, void>\n+\ttemplate\n+\tvoid\n \tinvokePack(BoundMethodPackBase *pack, std::index_sequence)\n \t{\n \t\tPackType *args = static_cast(pack);\n-\t\targs->ret_ = invoke(std::get(args->args_)...);\n-\t}\n \n-\ttemplate\n-\tstd::enable_if_t::value, void>\n-\tinvokePack(BoundMethodPackBase *pack, std::index_sequence)\n-\t{\n-\t\t/* args is effectively unused when the sequence I is empty. */\n-\t\tPackType *args [[gnu::unused]] = static_cast(pack);\n-\t\tinvoke(std::get(args->args_)...);\n+\t\tif constexpr (!std::is_void_v)\n+\t\t\targs->ret_ = invoke(std::get(args->args_)...);\n+\t\telse\n+\t\t\tinvoke(std::get(args->args_)...);\n \t}\n \n public:\n","prefixes":["v1"]}