[{"id":33771,"web_url":"https://patchwork.libcamera.org/comment/33771/","msgid":"<20250331153040.GA14432@pendragon.ideasonboard.com>","date":"2025-03-31T15:30:40","subject":"Re: [PATCH v1] libcamera: camera_manager: Simplify camera lookup","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Mar 31, 2025 at 05:06:11PM +0200, Barnabás Pőcze wrote:\n> `std::find()` works just fine because `std::shared_ptr` has\n> `operator==()` with the expected semantics.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_manager.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 400109f12..b28bd0bd2 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -239,10 +239,7 @@ void CameraManager::Private::removeCamera(std::shared_ptr camera)\n> \t{\n> \t\tMutexLocker locker(mutex_);\n> \n> -\t\tauto iter = std::find_if(cameras_.begin(), cameras_.end(),\n> -\t\t\t\t\t [camera](std::shared_ptr &c) {\n> -\t\t\t\t\t\t return c.get() == camera.get();\n> -\t\t\t\t\t });\n> +\t\tauto iter = std::find(cameras_.begin(), cameras_.end(), camera);\n> \t\tif (iter == cameras_.end())\n> \t\t\treturn;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B29FBC3213\n\tfor ;\n\tMon, 31 Mar 2025 15:31:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65D1C68981;\n\tMon, 31 Mar 2025 17:31:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DE0268967\n\tfor ;\n\tMon, 31 Mar 2025 17:31:05 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E83D703;\n\tMon, 31 Mar 2025 17:29:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ovOjasKh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743434953;\n\tbh=6AZ6hulWazOhBEC7vzKMvwUadKuE4izL+f9fRadrZPI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ovOjasKh1rAUvHrrMXrRukKhkHh/bjZSgkzqXhbpMzbRTW4Uq1Fdd1TSyGEAHrQ0y\n\ter92hWx2SIfCSquqHO12D768bpHwNiB19fatjkIzBtdvHoL0RTTiMdMMD77O5mr5TS\n\tu9W5/Fs6VoWkp9dj/srZd4yTe9ZFbJP+8Ih4u7JM=","Date":"Mon, 31 Mar 2025 18:30:40 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: camera_manager: Simplify camera lookup","Message-ID":"<20250331153040.GA14432@pendragon.ideasonboard.com>","References":"<20250331150611.523218-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250331150611.523218-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33789,"web_url":"https://patchwork.libcamera.org/comment/33789/","msgid":"<174344010679.3394313.5758917775514993496@ping.linuxembedded.co.uk>","date":"2025-03-31T16:55:06","subject":"Re: [PATCH v1] libcamera: camera_manager: Simplify camera lookup","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-31 16:06:11)\n> `std::find()` works just fine because `std::shared_ptr` has\n> `operator==()` with the expected semantics.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/camera_manager.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 400109f12..b28bd0bd2 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -239,10 +239,7 @@ void CameraManager::Private::removeCamera(std::shared_ptr camera)\n> {\n> MutexLocker locker(mutex_);\n> \n> - auto iter = std::find_if(cameras_.begin(), cameras_.end(),\n> - [camera](std::shared_ptr &c) {\n> - return c.get() == camera.get();\n> - });\n> + auto iter = std::find(cameras_.begin(), cameras_.end(), camera);\n> if (iter == cameras_.end())\n> return;\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A8AEC3213\n\tfor ;\n\tMon, 31 Mar 2025 16:55:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BEB568985;\n\tMon, 31 Mar 2025 18:55:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37CE068967\n\tfor ;\n\tMon, 31 Mar 2025 18:55:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC6EE725;\n\tMon, 31 Mar 2025 18:53:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kYfJoR5d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743439997;\n\tbh=MA1KZC1/IWbTRmplGnSYJMUxNggaUZyPsRKVAqHB/uw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=kYfJoR5d+xmrTTIM6YA6jeXyfQtDArNFp6fe51PIoor1m+vhB4Dv3Ax3IwXgfO5vx\n\t0OvGTwwn2MtEK4bNGk2cKR3GTkHPlVDtdMhY2R9hRPt30bkn7R6YYo3cQuFXfk+JFi\n\tfQJQLAU6ay+VKluml44XImIrP9maE39lmCMviJKk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250331150611.523218-1-barnabas.pocze@ideasonboard.com>","References":"<20250331150611.523218-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: camera_manager: Simplify camera lookup","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 17:55:06 +0100","Message-ID":"<174344010679.3394313.5758917775514993496@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]