[{"id":33785,"web_url":"https://patchwork.libcamera.org/comment/33785/","msgid":"<174343920833.3394313.3998087068756235587@ping.linuxembedded.co.uk>","date":"2025-03-31T16:40:08","subject":"Re: [PATCH 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-31 15:43:46)\n> The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\n> applied correctly. Add the color space to the debug log output to be\n> able to detect that now and later.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 132ab40fdbf7..bd74b73d1e68 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \n> LOG(RkISP1, Debug)\n> << \"ISP output pad configured with \" << format\n> - << \" crop \" << outputCrop;\n> + << \" crop \" << outputCrop\n> + << \" color space \" << ColorSpace::toString(format.colorSpace);\n\nReviewed-by: Kieran Bingham \n\n> \n> IPACameraSensorInfo sensorInfo;\n> ret = data->sensor_->sensorInfo(&sensorInfo);\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64455C3213\n\tfor ;\n\tMon, 31 Mar 2025 16:40:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15B0768981;\n\tMon, 31 Mar 2025 18:40:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F96D6897A\n\tfor ;\n\tMon, 31 Mar 2025 18:40:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9054725;\n\tMon, 31 Mar 2025 18:38:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ibYlaHbU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743439099;\n\tbh=oWk+d9Ku65EnXOw3fn3bShCwIhWS4MIs7GzEpg4Xqx0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ibYlaHbUh0K8yNcXAZmmw3o4bmGdO3rUGOd04/9PFvDzui08ChzZ765PsxQfh1CkA\n\tx/MrcBkD+rcYeMbknWIEirCgkg/KMpbDo6YNDYocclM2cOHu8uscuw12JC8uTNCLX4\n\tOaZuQbXNtzYfImJJHM6nJAdJWp5cpw6MaADfmOrU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250331144352.736700-8-stefan.klug@ideasonboard.com>","References":"<20250331144352.736700-1-stefan.klug@ideasonboard.com>\n\t<20250331144352.736700-8-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 17:40:08 +0100","Message-ID":"<174343920833.3394313.3998087068756235587@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]