[{"id":3032,"web_url":"https://patchwork.libcamera.org/comment/3032/","msgid":"<20191115165948.utwvw3jutqdj5vmw@uno.localdomain>","date":"2019-11-15T16:59:48","subject":"Re: [libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi,\n\nOn Fri, Nov 08, 2019 at 10:53:57PM +0200, Laurent Pinchart wrote:\n> In order to inspect planes of a const Buffer, add a const accessor.\n\nIs this related to this series ?\n\n>\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n> ---\n> include/libcamera/buffer.h | 1 +\n> src/libcamera/buffer.cpp | 6 ++++++\n> 2 files changed, 7 insertions(+)\n>\n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index 7b657509ab5f..7a070205f0b5 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -43,6 +43,7 @@ private:\n> class BufferMemory final\n> {\n> public:\n> +\tconst std::vector &planes() const { return planes_; }\n> \tstd::vector &planes() { return planes_; }\n>\n> private:\n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index 4407201bd81c..960eeb8f7d19 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -181,6 +181,12 @@ void *Plane::mem()\n> * image format is multi-planar.\n> */\n>\n> +/**\n> + * \\fn BufferMemory::planes() const\n> + * \\brief Retrieve the planes within the buffer\n> + * \\return A const reference to a vector holding all Planes within the buffer\n> + */\n> +\n> /**\n> * \\fn BufferMemory::planes()\n> * \\brief Retrieve the planes within the buffer\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69CE36136F\n\tfor ;\n\tFri, 15 Nov 2019 17:57:47 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 09FBE200004;\n\tFri, 15 Nov 2019 16:57:46 +0000 (UTC)"],"Date":"Fri, 15 Nov 2019 17:59:48 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191115165948.utwvw3jutqdj5vmw@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-13-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"tsmtr7uetrbulzyw\"","Content-Disposition":"inline","In-Reply-To":"<20191108205409.18845-13-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 Nov 2019 16:57:47 -0000"}},{"id":3042,"web_url":"https://patchwork.libcamera.org/comment/3042/","msgid":"<20191118010539.GN4853@pendragon.ideasonboard.com>","date":"2019-11-18T01:05:39","subject":"Re: [libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Nov 15, 2019 at 05:59:48PM +0100, Jacopo Mondi wrote:\n> On Fri, Nov 08, 2019 at 10:53:57PM +0200, Laurent Pinchart wrote:\n> > In order to inspect planes of a const Buffer, add a const accessor.\n> \n> Is this related to this series ?\n\nIf I remember correctly, it's needed to translate to the C API in\nIPAContextWrapper::mapBuffers().\n\n> > Signed-off-by: Laurent Pinchart \n> > Reviewed-by: Niklas Söderlund \n> > ---\n> > include/libcamera/buffer.h | 1 +\n> > src/libcamera/buffer.cpp | 6 ++++++\n> > 2 files changed, 7 insertions(+)\n> >\n> > diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> > index 7b657509ab5f..7a070205f0b5 100644\n> > --- a/include/libcamera/buffer.h\n> > +++ b/include/libcamera/buffer.h\n> > @@ -43,6 +43,7 @@ private:\n> > class BufferMemory final\n> > {\n> > public:\n> > +\tconst std::vector &planes() const { return planes_; }\n> > \tstd::vector &planes() { return planes_; }\n> >\n> > private:\n> > diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> > index 4407201bd81c..960eeb8f7d19 100644\n> > --- a/src/libcamera/buffer.cpp\n> > +++ b/src/libcamera/buffer.cpp\n> > @@ -181,6 +181,12 @@ void *Plane::mem()\n> > * image format is multi-planar.\n> > */\n> >\n> > +/**\n> > + * \\fn BufferMemory::planes() const\n> > + * \\brief Retrieve the planes within the buffer\n> > + * \\return A const reference to a vector holding all Planes within the buffer\n> > + */\n> > +\n> > /**\n> > * \\fn BufferMemory::planes()\n> > * \\brief Retrieve the planes within the buffer","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB7F360C33\n\tfor ;\n\tMon, 18 Nov 2019 02:05:44 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 26602540;\n\tMon, 18 Nov 2019 02:05:44 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574039144;\n\tbh=TQTn70Q16Y3WAnufpt4rAzvcLXpx0kR+1j9kqFZE5Ic=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fs/E90NhaX8IT3gC6evHbElUmt3LaFGEV9A/Nw0+aJPN5RRhZhcNyR7K/vqCwvAEI\n\twQeJzESLH03sJBwSh0mXo8X4ifrdlZCfpU444sOLAu8KWACQVK1Fj+FfEvy1/IHn9V\n\tlbGx5huIC1v1dc0+oKedm3JhijZX4PpKLuyHpr8M=","Date":"Mon, 18 Nov 2019 03:05:39 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118010539.GN4853@pendragon.ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-13-laurent.pinchart@ideasonboard.com>\n\t<20191115165948.utwvw3jutqdj5vmw@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191115165948.utwvw3jutqdj5vmw@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 01:05:45 -0000"}},{"id":3086,"web_url":"https://patchwork.libcamera.org/comment/3086/","msgid":"<20191118225156.ktlfzsiqdx2ff3gn@uno.localdomain>","date":"2019-11-18T22:51:56","subject":"Re: [libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Nov 18, 2019 at 03:05:39AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Fri, Nov 15, 2019 at 05:59:48PM +0100, Jacopo Mondi wrote:\n> > On Fri, Nov 08, 2019 at 10:53:57PM +0200, Laurent Pinchart wrote:\n> > > In order to inspect planes of a const Buffer, add a const accessor.\n> >\n> > Is this related to this series ?\n\nFine! Reviewed-by: Jacopo Mondi \n>\n> If I remember correctly, it's needed to translate to the C API in\n> IPAContextWrapper::mapBuffers().\n>\n> > > Signed-off-by: Laurent Pinchart \n> > > Reviewed-by: Niklas Söderlund \n> > > ---\n> > > include/libcamera/buffer.h | 1 +\n> > > src/libcamera/buffer.cpp | 6 ++++++\n> > > 2 files changed, 7 insertions(+)\n> > >\n> > > diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> > > index 7b657509ab5f..7a070205f0b5 100644\n> > > --- a/include/libcamera/buffer.h\n> > > +++ b/include/libcamera/buffer.h\n> > > @@ -43,6 +43,7 @@ private:\n> > > class BufferMemory final\n> > > {\n> > > public:\n> > > +\tconst std::vector &planes() const { return planes_; }\n> > > \tstd::vector &planes() { return planes_; }\n> > >\n> > > private:\n> > > diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> > > index 4407201bd81c..960eeb8f7d19 100644\n> > > --- a/src/libcamera/buffer.cpp\n> > > +++ b/src/libcamera/buffer.cpp\n> > > @@ -181,6 +181,12 @@ void *Plane::mem()\n> > > * image format is multi-planar.\n> > > */\n> > >\n> > > +/**\n> > > + * \\fn BufferMemory::planes() const\n> > > + * \\brief Retrieve the planes within the buffer\n> > > + * \\return A const reference to a vector holding all Planes within the buffer\n> > > + */\n> > > +\n> > > /**\n> > > * \\fn BufferMemory::planes()\n> > > * \\brief Retrieve the planes within the buffer\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04D9F60F1C\n\tfor ;\n\tMon, 18 Nov 2019 23:49:55 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1FABA60006;\n\tMon, 18 Nov 2019 22:49:53 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 18 Nov 2019 23:51:56 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118225156.ktlfzsiqdx2ff3gn@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-13-laurent.pinchart@ideasonboard.com>\n\t<20191115165948.utwvw3jutqdj5vmw@uno.localdomain>\n\t<20191118010539.GN4853@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"gn5cntuw2np74axs\"","Content-Disposition":"inline","In-Reply-To":"<20191118010539.GN4853@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 22:49:55 -0000"}}]