{"id":2308,"url":"https://patchwork.libcamera.org/api/patches/2308/?format=json","web_url":"https://patchwork.libcamera.org/patch/2308/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191108205409.18845-13-laurent.pinchart@ideasonboard.com>","date":"2019-11-08T20:53:57","name":"[libcamera-devel,v2,12/24] libcamera: buffer: Add const accessor to Buffer planes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7958ebd827f40fe8ad1b930407f7d7292490e1c6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2308/mbox/","series":[{"id":568,"url":"https://patchwork.libcamera.org/api/series/568/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=568","date":"2019-11-08T20:53:45","name":"Control serialization and IPA C API","version":2,"mbox":"https://patchwork.libcamera.org/series/568/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2308/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2308/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D265F61518\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Nov 2019 21:54:26 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74CAC2D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Nov 2019 21:54:26 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573246466;\n\tbh=mUz2y97UlVf1Vpah379AqeKhS/xrm72J/EvsCEVFago=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=edUMUSywx2ZLFDn9x7c5+AGXKZ9mfENlqQgPaFpKkGXj9bswE5loeLauUPJVnMmI7\n\tPwf+16K674z0qdRU+dunHTk5NhrcInrUK/jDHEHl9WOIctZRfpbyYDKVDOj9FFv3VE\n\tMNMefzwaweiHfVvC1CO29vKdYZHU9aB17erdSRfM=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  8 Nov 2019 22:53:57 +0200","Message-Id":"<20191108205409.18845-13-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 12/24] libcamera: buffer: Add const\n\taccessor to Buffer planes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 08 Nov 2019 20:54:27 -0000"},"content":"In order to inspect planes of a const Buffer, add a const accessor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/buffer.h | 1 +\n src/libcamera/buffer.cpp   | 6 ++++++\n 2 files changed, 7 insertions(+)","diff":"diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex 7b657509ab5f..7a070205f0b5 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -43,6 +43,7 @@ private:\n class BufferMemory final\n {\n public:\n+\tconst std::vector<Plane> &planes() const { return planes_; }\n \tstd::vector<Plane> &planes() { return planes_; }\n \n private:\ndiff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex 4407201bd81c..960eeb8f7d19 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -181,6 +181,12 @@ void *Plane::mem()\n  * image format is multi-planar.\n  */\n \n+/**\n+ * \\fn BufferMemory::planes() const\n+ * \\brief Retrieve the planes within the buffer\n+ * \\return A const reference to a vector holding all Planes within the buffer\n+ */\n+\n /**\n  * \\fn BufferMemory::planes()\n  * \\brief Retrieve the planes within the buffer\n","prefixes":["libcamera-devel","v2","12/24"]}