[{"id":33783,"web_url":"https://patchwork.libcamera.org/comment/33783/","msgid":"<174343910736.3394313.10986712810629932437@ping.linuxembedded.co.uk>","date":"2025-03-31T16:38:27","subject":"Re: [PATCH 5/9] ipa: rkisp1: params: Check for empty parameters","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-31 15:43:44)\n> Add functions to check for empty parameter blocks. Modify the constructor\n> so that a parameter block constructed from an empty span stays empty.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/params.cpp | 3 +++\n> src/ipa/rkisp1/params.h | 13 +++++++++++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\n> index 4c0b051ce65d..b4a889e415fc 100644\n> --- a/src/ipa/rkisp1/params.cpp\n> +++ b/src/ipa/rkisp1/params.cpp\n> @@ -82,6 +82,9 @@ RkISP1ParamsBlockBase::RkISP1ParamsBlockBase(RkISP1Params *params, BlockType typ\n> const Span &data)\n> : params_(params), type_(type)\n> {\n> + if (data.empty())\n> + return;\n> +\n> if (params_->format() == V4L2_META_FMT_RK_ISP1_EXT_PARAMS) {\n> header_ = data.subspan(0, sizeof(rkisp1_ext_params_block_header));\n> data_ = data.subspan(sizeof(rkisp1_ext_params_block_header));\n> diff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\n> index 40450e34497a..e0aa04ae0f8d 100644\n> --- a/src/ipa/rkisp1/params.h\n> +++ b/src/ipa/rkisp1/params.h\n> @@ -89,6 +89,9 @@ public:\n> \n> void setEnabled(bool enabled);\n> \n> + bool isValid() const { return !data_.empty(); }\n> + explicit operator bool() const { return !data_.empty(); }\n> +\n> private:\n> LIBCAMERA_DISABLE_COPY(RkISP1ParamsBlockBase)\n> \n> @@ -109,6 +112,16 @@ public:\n> {\n> }\n> \n> + const Type *get() const\n> + {\n> + return reinterpret_cast(data().data());\n> + }\n> +\n> + Type *get()\n> + {\n> + return reinterpret_cast(data().data());\n> + }\n> +\n\nThese seem unrelated ?\n\n--\nKieran\n\n\n> const Type *operator->() const\n> {\n> return reinterpret_cast(data().data());\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D60C1C3213\n\tfor ;\n\tMon, 31 Mar 2025 16:38:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E90D68988;\n\tMon, 31 Mar 2025 18:38:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6826568981\n\tfor ;\n\tMon, 31 Mar 2025 18:38:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E137F725;\n\tMon, 31 Mar 2025 18:36:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lza7RWPL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743438999;\n\tbh=UgP0ETQ5OsE/17TGJH6NndW0VgrdOxdOvOBrWHaYpD0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lza7RWPLScky7tIUOGbZ4nYsTX06oiaN31iTx332xT1oDzM0i6rYosRXj7PI+6EFP\n\t+QkuA9iOgCLScFrUx4L48oCS4M6XnroeQrL1Cr2H/v5iWCiFxSuTYf4zTg1+lM4ZXg\n\tEj/1qjtcxhAC0V9d90qRV4x8gN33GYIUtpIfu+h0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250331144352.736700-6-stefan.klug@ideasonboard.com>","References":"<20250331144352.736700-1-stefan.klug@ideasonboard.com>\n\t<20250331144352.736700-6-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 5/9] ipa: rkisp1: params: Check for empty parameters","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 17:38:27 +0100","Message-ID":"<174343910736.3394313.10986712810629932437@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33930,"web_url":"https://patchwork.libcamera.org/comment/33930/","msgid":"","date":"2025-04-11T10:11:08","subject":"Re: [PATCH 5/9] ipa: rkisp1: params: Check for empty parameters","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the review. \n\nOn Mon, Mar 31, 2025 at 05:38:27PM +0100, Kieran Bingham wrote:\n> Quoting Stefan Klug (2025-03-31 15:43:44)\n> > Add functions to check for empty parameter blocks. Modify the constructor\n> > so that a parameter block constructed from an empty span stays empty.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/ipa/rkisp1/params.cpp | 3 +++\n> > src/ipa/rkisp1/params.h | 13 +++++++++++++\n> > 2 files changed, 16 insertions(+)\n> > \n> > diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\n> > index 4c0b051ce65d..b4a889e415fc 100644\n> > --- a/src/ipa/rkisp1/params.cpp\n> > +++ b/src/ipa/rkisp1/params.cpp\n> > @@ -82,6 +82,9 @@ RkISP1ParamsBlockBase::RkISP1ParamsBlockBase(RkISP1Params *params, BlockType typ\n> > const Span &data)\n> > : params_(params), type_(type)\n> > {\n> > + if (data.empty())\n> > + return;\n> > +\n> > if (params_->format() == V4L2_META_FMT_RK_ISP1_EXT_PARAMS) {\n> > header_ = data.subspan(0, sizeof(rkisp1_ext_params_block_header));\n> > data_ = data.subspan(sizeof(rkisp1_ext_params_block_header));\n> > diff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\n> > index 40450e34497a..e0aa04ae0f8d 100644\n> > --- a/src/ipa/rkisp1/params.h\n> > +++ b/src/ipa/rkisp1/params.h\n> > @@ -89,6 +89,9 @@ public:\n> > \n> > void setEnabled(bool enabled);\n> > \n> > + bool isValid() const { return !data_.empty(); }\n> > + explicit operator bool() const { return !data_.empty(); }\n> > +\n> > private:\n> > LIBCAMERA_DISABLE_COPY(RkISP1ParamsBlockBase)\n> > \n> > @@ -109,6 +112,16 @@ public:\n> > {\n> > }\n> > \n> > + const Type *get() const\n> > + {\n> > + return reinterpret_cast(data().data());\n> > + }\n> > +\n> > + Type *get()\n> > + {\n> > + return reinterpret_cast(data().data());\n> > + }\n> > +\n> \n> These seem unrelated ?\n\nOh, you are right. Dropped it for v2.\n\nBest regards,\nStefan\n\n> \n> --\n> Kieran\n> \n> \n> > const Type *operator->() const\n> > {\n> > return reinterpret_cast(data().data());\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A339C327D\n\tfor ;\n\tFri, 11 Apr 2025 10:11:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D45D68A9D;\n\tFri, 11 Apr 2025 12:11:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8475C689A5\n\tfor ;\n\tFri, 11 Apr 2025 12:11:11 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 26B83667;\n\tFri, 11 Apr 2025 12:09:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gntn6cxH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744366152;\n\tbh=6hppLfiqxwF0NJ0Bk6IBohYVRbP8rDHzbAnT2Ij8hc8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gntn6cxHQbNiTGsieytQLC11I+wJt7+mpZOhYertTg4DgcYL67l+HiWErQ/THHkpP\n\trtWtOLt7B556RY7uEU6ESe2G9/9NwUUgSeZf4uNzvvwHDak9tihuMs4f1zEMKW1lj1\n\tFmIXjZIXkAbYujHOn/9S3bZcvJciQTjc+ray3tds=","Date":"Fri, 11 Apr 2025 12:11:08 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 5/9] ipa: rkisp1: params: Check for empty parameters","Message-ID":"","References":"<20250331144352.736700-1-stefan.klug@ideasonboard.com>\n\t<20250331144352.736700-6-stefan.klug@ideasonboard.com>\n\t<174343910736.3394313.10986712810629932437@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<174343910736.3394313.10986712810629932437@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]