[{"id":3028,"web_url":"https://patchwork.libcamera.org/comment/3028/","msgid":"<20191115162203.hhgd5fc2egnykukb@uno.localdomain>","date":"2019-11-15T16:22:03","subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Nov 08, 2019 at 10:53:56PM +0200, Laurent Pinchart wrote:\n> V4L2 controls of type V4L2_CTRL_TYPE_BOOLEAN are incorrectly described\n> with a ControlRange of int32_t values. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n\nindeed!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/libcamera/v4l2_controls.cpp | 14 ++++++++++++--\n> 1 file changed, 12 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 2462c3e2c264..b6547a7c627c 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -118,12 +118,22 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> */\n> V4L2ControlRange::V4L2ControlRange(const struct v4l2_query_ext_ctrl &ctrl)\n> {\n> -\tif (ctrl.type == V4L2_CTRL_TYPE_INTEGER64)\n> +\tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> +\t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> +\t\t\t\t\t\t static_cast(ctrl.maximum)));\n> +\t\tbreak;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER64:\n> \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> -\telse\n> +\t\tbreak;\n> +\n> +\tdefault:\n> \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> +\t\tbreak;\n> +\t}\n> }\n>\n> } /* namespace libcamera */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D693F6136F\n\tfor ;\n\tFri, 15 Nov 2019 17:20:02 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 78DB71C0015;\n\tFri, 15 Nov 2019 16:20:02 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 15 Nov 2019 17:22:03 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191115162203.hhgd5fc2egnykukb@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"mcln662o6bhijacc\"","Content-Disposition":"inline","In-Reply-To":"<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 Nov 2019 16:20:03 -0000"}},{"id":3063,"web_url":"https://patchwork.libcamera.org/comment/3063/","msgid":"<20191118171936.GG8072@bigcity.dyn.berto.se>","date":"2019-11-18T17:19:36","subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-11-08 22:53:56 +0200, Laurent Pinchart wrote:\n> V4L2 controls of type V4L2_CTRL_TYPE_BOOLEAN are incorrectly described\n> with a ControlRange of int32_t values. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/v4l2_controls.cpp | 14 ++++++++++++--\n> 1 file changed, 12 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 2462c3e2c264..b6547a7c627c 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -118,12 +118,22 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> */\n> V4L2ControlRange::V4L2ControlRange(const struct v4l2_query_ext_ctrl &ctrl)\n> {\n> -\tif (ctrl.type == V4L2_CTRL_TYPE_INTEGER64)\n> +\tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> +\t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> +\t\t\t\t\t\t static_cast(ctrl.maximum)));\n> +\t\tbreak;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER64:\n> \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> -\telse\n> +\t\tbreak;\n> +\n> +\tdefault:\n> \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> +\t\tbreak;\n> +\t}\n> }\n> \n> } /* namespace libcamera */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC1D060F1C\n\tfor ;\n\tMon, 18 Nov 2019 18:19:37 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id l14so7802966lfh.10\n\tfor ;\n\tMon, 18 Nov 2019 09:19:37 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ty18sm8898356lja.12.2019.11.18.09.19.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2019 09:19:36 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=MeHtSnvsoxRpsAfOM0r3V7xadxEY/iJHvl1KJ7Gn7rE=;\n\tb=c41MM7HrL+1WmpWEf4D3NCKJzOgqDhDxnVC0du2tO42CV1Ub5Ok5e9ZmQo1ZEjJZ3o\n\tc3xn08o6s0TCQ/lG3E2+IDkDm5m1rJAUg8cV+WfTFU/QJltEzvuT9PopFEXiBZaQIseg\n\tGjkGF7r2GNQCOANKxZYCoFj0w/a5j3Zpz2Z2pmdQsFD/PX0d9SxItKXB9uSG5HlExBxS\n\t0uHfRNTgFcTEomJm9/MNxNTfnyjGBZlek4LOJRPNlT6aVh0atdPhi6M+4nboIGXWhYUu\n\t9mbCQqdYH6qxnfSHKVEmUNHxEGEERqxG5T1YI4YR6+IXfpySQcLujr0MM5Iy52l9kYkc\n\tvbTw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=MeHtSnvsoxRpsAfOM0r3V7xadxEY/iJHvl1KJ7Gn7rE=;\n\tb=r5uOZkitdqjm4/f+1I4rJGSMKvVU6dMe5XM/tqjUKG1N1D76HNLvvtJyJe6Bx4sw2/\n\tawYgC1fh8M3mlpViYYTsdrkGRQt0OMFYPShY87QVpqc7imKwphIaGCV+f9Tdd7KOje87\n\tG6UvZhQ6b8N8Bgmd2KPj5UtIZnlw4ofSLhoFPxCs3qq9tjlSvSj6nHCQaknbQGG5cXhg\n\tHTLlueEJ5mG8JA6uInkjzyWJy8QIU0Bs4xtwX58AIW05/LyoPj11RMdJeJ63U18RQiVs\n\t1gbZ1Gw24Vu+gEwDKGufnfjMiEnWMx5HfXDtrFhyEpx0eX3wjTxc/y9EGZAmZWptIZf9\n\tjwIw==","X-Gm-Message-State":"APjAAAXRtZ5YRUxRnLBwGhASfUfuQSDNlcjy1JdQ1P8njGkNC/oMhSR3\n\ty7ZT7ZPDy6YuoPdr1rVjjNN17g==","X-Google-Smtp-Source":"APXvYqxsUwpXNJg1P6CdRgS8HDMslB7nhphMDdZqwTKIvFlxBmAhLDEBZiXMueGIIGSHhp2b2NSWzw==","X-Received":"by 2002:ac2:4a71:: with SMTP id q17mr341271lfp.179.1574097577344;\n\tMon, 18 Nov 2019 09:19:37 -0800 (PST)","Date":"Mon, 18 Nov 2019 18:19:36 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118171936.GG8072@bigcity.dyn.berto.se>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 17:19:38 -0000"}},{"id":3104,"web_url":"https://patchwork.libcamera.org/comment/3104/","msgid":"","date":"2019-11-19T16:26:04","subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 08/11/2019 20:53, Laurent Pinchart wrote:\n> V4L2 controls of type V4L2_CTRL_TYPE_BOOLEAN are incorrectly described\n> with a ControlRange of int32_t values. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/v4l2_controls.cpp | 14 ++++++++++++--\n> 1 file changed, 12 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 2462c3e2c264..b6547a7c627c 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -118,12 +118,22 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> */\n> V4L2ControlRange::V4L2ControlRange(const struct v4l2_query_ext_ctrl &ctrl)\n> {\n> -\tif (ctrl.type == V4L2_CTRL_TYPE_INTEGER64)\n> +\tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> +\t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> +\t\t\t\t\t\t static_cast(ctrl.maximum)));\n\nHrm shouldn't the minimum and maximum of a bool control be fairly const?\n\nIf so would this be better written as:\n\n ControlRange::operator=(ControlRange(false, true));\n\nOtherwise,\n\nReviewed-by: Kieran Bingham \n\n\n\n\n> +\t\tbreak;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER64:\n> \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> -\telse\n> +\t\tbreak;\n> +\n> +\tdefault:\n> \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> +\t\tbreak;\n> +\t}\n> }\n> \n> } /* namespace libcamera */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3032B60BEA\n\tfor ;\n\tTue, 19 Nov 2019 17:26:08 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82687311;\n\tTue, 19 Nov 2019 17:26:07 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574180767;\n\tbh=/fuirMmUYPbVrGbMyC2EkKCQsfKZUh1PG18BKM8gUyA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=og82xIXYgFblBXnkyWcWhefqi6pUkdk4W+fOhW2cTvwE29kZ2Vq6paQxJPnv5bCM6\n\tllqk0P9CKrPCNSyZ26wJw+QABIEk+GJCwAdpcNUOCMke7GccS8HKRFnGA3NJBm0fAo\n\tAOyRnJxqAbEyNYEgxTETnvam9r6IOxBdSax5zJHA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 19 Nov 2019 16:26:04 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 Nov 2019 16:26:08 -0000"}},{"id":3110,"web_url":"https://patchwork.libcamera.org/comment/3110/","msgid":"<20191119223831.GJ17590@pendragon.ideasonboard.com>","date":"2019-11-19T22:38:31","subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Nov 19, 2019 at 04:26:04PM +0000, Kieran Bingham wrote:\n> On 08/11/2019 20:53, Laurent Pinchart wrote:\n> > V4L2 controls of type V4L2_CTRL_TYPE_BOOLEAN are incorrectly described\n> > with a ControlRange of int32_t values. Fix it.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/v4l2_controls.cpp | 14 ++++++++++++--\n> > 1 file changed, 12 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> > index 2462c3e2c264..b6547a7c627c 100644\n> > --- a/src/libcamera/v4l2_controls.cpp\n> > +++ b/src/libcamera/v4l2_controls.cpp\n> > @@ -118,12 +118,22 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> > */\n> > V4L2ControlRange::V4L2ControlRange(const struct v4l2_query_ext_ctrl &ctrl)\n> > {\n> > -\tif (ctrl.type == V4L2_CTRL_TYPE_INTEGER64)\n> > +\tswitch (ctrl.type) {\n> > +\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> > +\t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> > +\t\t\t\t\t\t static_cast(ctrl.maximum)));\n> \n> Hrm shouldn't the minimum and maximum of a bool control be fairly const?\n> \n> If so would this be better written as:\n> \n> ControlRange::operator=(ControlRange(false, true));\n\nA V4L2 device could decide to expose a control but only support a single\nvalue. The main use case would be read-only controls that report a\ndevice configuration, but it could also be useful to show that a feature\nis only partly implemented/supported.\n\n> Otherwise,\n> \n> Reviewed-by: Kieran Bingham \n> \n> > +\t\tbreak;\n> > +\n> > +\tcase V4L2_CTRL_TYPE_INTEGER64:\n> > \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> > \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> > -\telse\n> > +\t\tbreak;\n> > +\n> > +\tdefault:\n> > \t\tControlRange::operator=(ControlRange(static_cast(ctrl.minimum),\n> > \t\t\t\t\t\t static_cast(ctrl.maximum)));\n> > +\t\tbreak;\n> > +\t}\n> > }\n> > \n> > } /* namespace libcamera */\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05EF260BEA\n\tfor ;\n\tTue, 19 Nov 2019 23:38:41 +0100 (CET)","from pendragon.ideasonboard.com (unknown [122.147.213.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D022311;\n\tTue, 19 Nov 2019 23:38:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574203120;\n\tbh=nbxPYoDDrQvNtc67QJQRWISFm+fKyPCuOR3y7f9Sbqo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ooY7Q47xcZl5hLzk8EwgDj/ad2BOWhNiFPMhjZNaDdo045hAx0sPXse/xiDJzb3Mx\n\t9Z5QhZ2I7v5Wsgpb/j2DwTTz1bMkhO3xJNQ2IibgUjs6cTf6IGiucERBGOglAdVMc+\n\tgTfUC28SiBr0/Zhjvn6mO8icy6Z93jM+k0o+sIWc=","Date":"Wed, 20 Nov 2019 00:38:31 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191119223831.GJ17590@pendragon.ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-12-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 11/24] libcamera: v4l2_controls:\n\tFix control range construction for bool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 Nov 2019 22:38:41 -0000"}}]