{"id":23061,"url":"https://patchwork.libcamera.org/api/patches/23061/?format=json","web_url":"https://patchwork.libcamera.org/patch/23061/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250327185945.159481-4-mzamazal@redhat.com>","date":"2025-03-27T18:59:41","name":"[v6,3/6] ipa: simple: Report the ColourGains in metadata","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"708b11b063ab6a8efdb43378fa1b2d4832194032","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23061/mbox/","series":[{"id":5087,"url":"https://patchwork.libcamera.org/api/series/5087/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5087","date":"2025-03-27T18:59:38","name":"ipa: simple: Introduce metadata reporting","version":6,"mbox":"https://patchwork.libcamera.org/series/5087/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23061/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23061/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AFF1C323E\n\tfor ;\n\tThu, 27 Mar 2025 19:00:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7A1D68986;\n\tThu, 27 Mar 2025 20:00:09 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E76F36897C\n\tfor ;\n\tThu, 27 Mar 2025 20:00:06 +0100 (CET)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-210-pWnb6hbkMDeNxZE_JWiZ5Q-1;\n\tThu, 27 Mar 2025 15:00:02 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 33EC51800260; Thu, 27 Mar 2025 19:00:01 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.17])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5743930001A1; Thu, 27 Mar 2025 18:59:59 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"aHrNA3qw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1743102005;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=1HwX+yC/EoaGzGDsNjwvjuR1ZRCrHrlU4Z/RHcxItwc=;\n\tb=aHrNA3qwVY0SABD9EApjMfuphtG/SFHtRIfSMXqh1CSncs1c6ZAC35Q8J4YkWTjLopPkmB\n\tUB+MxXr5FamkMdVaqkkCCvZM4hXUrLpLfPqyAZ7/UpRkwm3DZxbZP8keanE8+KSi/Wvawe\n\teilSY5desE4k5oTJECS7xu0UU0FuWAo=","X-MC-Unique":"pWnb6hbkMDeNxZE_JWiZ5Q-1","X-Mimecast-MFC-AGG-ID":"pWnb6hbkMDeNxZE_JWiZ5Q_1743102001","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ,\n\tMilan Zamazal ","Subject":"[PATCH v6 3/6] ipa: simple: Report the ColourGains in metadata","Date":"Thu, 27 Mar 2025 19:59:41 +0100","Message-ID":"<20250327185945.159481-4-mzamazal@redhat.com>","In-Reply-To":"<20250327185945.159481-1-mzamazal@redhat.com>","References":"<20250327185945.159481-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"QLGivWH9knNc5EjfbtX-ddQJ6BnefrhWXikahmbyIqg_1743102001","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nProvide the determined colour gains back into the metadata\nto add to completed requests.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/awb.cpp | 21 ++++++++++++++++++++-\n src/ipa/simple/algorithms/awb.h | 6 +++++-\n src/ipa/simple/ipa_context.h | 4 ++++\n 3 files changed, 29 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex ec77c6e5..55719059 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -17,6 +17,8 @@\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n+#include \"control_ids.h\"\n+\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPASoftAwb)\n@@ -32,15 +34,32 @@ int Awb::configure(IPAContext &context,\n \treturn 0;\n }\n \n+void Awb::prepare(IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t [[maybe_unused]] DebayerParams *params)\n+{\n+\tauto &gains = context.activeState.awb.gains;\n+\tframeContext.gains.red = gains.r();\n+\tframeContext.gains.blue = gains.b();\n+}\n+\n void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n-\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n \t\t ControlList &metadata)\n {\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n \n+\tconst float maxGain = 1024.0;\n+\tconst float mdGains[] = {\n+\t\tstatic_cast(frameContext.gains.red / maxGain),\n+\t\tstatic_cast(frameContext.gains.blue / maxGain)\n+\t};\n+\tmetadata.set(controls::ColourGains, mdGains);\n+\n \t/*\n \t * Black level must be subtracted to get the correct AWB ratios, they\n \t * would be off if they were computed from the whole brightness range\ndiff --git a/src/ipa/simple/algorithms/awb.h b/src/ipa/simple/algorithms/awb.h\nindex db1496cd..ad993f39 100644\n--- a/src/ipa/simple/algorithms/awb.h\n+++ b/src/ipa/simple/algorithms/awb.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) 2024, Red Hat Inc.\n+ * Copyright (C) 2024-2025 Red Hat Inc.\n *\n * Auto white balance\n */\n@@ -20,6 +20,10 @@ public:\n \t~Awb() = default;\n \n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n+\tvoid prepare(IPAContext &context,\n+\t\t const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t DebayerParams *params) override;\n \tvoid process(IPAContext &context,\n \t\t const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 17bcd4ca..bfac835b 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -70,6 +70,10 @@ struct IPAFrameContext : public FrameContext {\n \t\tint32_t exposure;\n \t\tdouble gain;\n \t} sensor;\n+\tstruct {\n+\t\tdouble red;\n+\t\tdouble blue;\n+\t} gains;\n };\n \n struct IPAContext {\n","prefixes":["v6","3/6"]}