[{"id":3027,"web_url":"https://patchwork.libcamera.org/comment/3027/","msgid":"<20191115162129.prthsi3jafzgeooi@uno.localdomain>","date":"2019-11-15T16:21:29","subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi LAurent\n\nOn Fri, Nov 08, 2019 at 10:53:55PM +0200, Laurent Pinchart wrote:\n> ControlInfoMap requires the ControlId and ControlRange of each entry to\n> have identical types. Check for this and log an error if a mismatch is\n> detected.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/controls.cpp | 13 ++++++++++++-\n> 1 file changed, 12 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index eae0250a92e3..c488b2e4eb3f 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -571,8 +571,19 @@ ControlInfoMap::const_iterator ControlInfoMap::find(unsigned int id) const\n> void ControlInfoMap::generateIdmap()\n> {\n> \tidmap_.clear();\n> -\tfor (const auto &ctrl : *this)\n> +\n> +\tfor (const auto &ctrl : *this) {\n> +\t\tif (ctrl.first->type() != ctrl.second.min().type()) {\n> +\t\t\tLOG(Controls, Error)\n> +\t\t\t\t<< \"Control \" << utils::hex(ctrl.first->id())\n> +\t\t\t\t<< \" type and range type mismatch\";\n> +\t\t\tidmap_.clear();\n> +\t\t\tclear();\n> +\t\t\treturn;\n> +\t\t}\n> +\n\nShould we just skip the control or actually abort the whole id map\ngeneration ?\n\n> \t\tidmap_[ctrl.first->id()] = ctrl.first;\n> +\t}\n> }\n>\n> /**\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02AF56136F\n\tfor ;\n\tFri, 15 Nov 2019 17:19:27 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 88D541BF208;\n\tFri, 15 Nov 2019 16:19:27 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 15 Nov 2019 17:21:29 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191115162129.prthsi3jafzgeooi@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"n4b4rmh7v36slmgw\"","Content-Disposition":"inline","In-Reply-To":"<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 Nov 2019 16:19:28 -0000"}},{"id":3041,"web_url":"https://patchwork.libcamera.org/comment/3041/","msgid":"<20191118010133.GM4853@pendragon.ideasonboard.com>","date":"2019-11-18T01:01:33","subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Nov 15, 2019 at 05:21:29PM +0100, Jacopo Mondi wrote:\n> On Fri, Nov 08, 2019 at 10:53:55PM +0200, Laurent Pinchart wrote:\n> > ControlInfoMap requires the ControlId and ControlRange of each entry to\n> > have identical types. Check for this and log an error if a mismatch is\n> > detected.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/controls.cpp | 13 ++++++++++++-\n> > 1 file changed, 12 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index eae0250a92e3..c488b2e4eb3f 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -571,8 +571,19 @@ ControlInfoMap::const_iterator ControlInfoMap::find(unsigned int id) const\n> > void ControlInfoMap::generateIdmap()\n> > {\n> > \tidmap_.clear();\n> > -\tfor (const auto &ctrl : *this)\n> > +\n> > +\tfor (const auto &ctrl : *this) {\n> > +\t\tif (ctrl.first->type() != ctrl.second.min().type()) {\n> > +\t\t\tLOG(Controls, Error)\n> > +\t\t\t\t<< \"Control \" << utils::hex(ctrl.first->id())\n> > +\t\t\t\t<< \" type and range type mismatch\";\n> > +\t\t\tidmap_.clear();\n> > +\t\t\tclear();\n> > +\t\t\treturn;\n> > +\t\t}\n> > +\n> \n> Should we just skip the control or actually abort the whole id map\n> generation ?\n\nAs this is a serious error, I think we should abort it completely, in\norder to show that something went wrong. If you think we should just\nskip the control, we can discuss that.\n\n> > \t\tidmap_[ctrl.first->id()] = ctrl.first;\n> > +\t}\n> > }\n> >\n> > /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD4EE60C33\n\tfor ;\n\tMon, 18 Nov 2019 02:01:38 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37C9B540;\n\tMon, 18 Nov 2019 02:01:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574038898;\n\tbh=e97qgBsKwiMjw3GWfOnrZCko6cblyoFNVYmn86pVuWo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lqZYlg5HPska6AvK07GO3V8TJWL1iZe8GYWq61EYuPxYORRcZKIOEDZjeewC4jzKc\n\tan/OFBIy+3X4ucVUmNAlA5CASKKW1Q5IdYMDas/q//r9Dvq7a57vB+QYKi6ipiWY9X\n\t6eaP7rbOCQ3Q7nes+bTyExbr5ulN46mTmXttFkk8=","Date":"Mon, 18 Nov 2019 03:01:33 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118010133.GM4853@pendragon.ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>\n\t<20191115162129.prthsi3jafzgeooi@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191115162129.prthsi3jafzgeooi@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 01:01:39 -0000"}},{"id":3062,"web_url":"https://patchwork.libcamera.org/comment/3062/","msgid":"<20191118171617.GF8072@bigcity.dyn.berto.se>","date":"2019-11-18T17:16:17","subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-11-08 22:53:55 +0200, Laurent Pinchart wrote:\n> ControlInfoMap requires the ControlId and ControlRange of each entry to\n> have identical types. Check for this and log an error if a mismatch is\n> detected.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/controls.cpp | 13 ++++++++++++-\n> 1 file changed, 12 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index eae0250a92e3..c488b2e4eb3f 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -571,8 +571,19 @@ ControlInfoMap::const_iterator ControlInfoMap::find(unsigned int id) const\n> void ControlInfoMap::generateIdmap()\n> {\n> \tidmap_.clear();\n> -\tfor (const auto &ctrl : *this)\n> +\n> +\tfor (const auto &ctrl : *this) {\n> +\t\tif (ctrl.first->type() != ctrl.second.min().type()) {\n> +\t\t\tLOG(Controls, Error)\n> +\t\t\t\t<< \"Control \" << utils::hex(ctrl.first->id())\n> +\t\t\t\t<< \" type and range type mismatch\";\n> +\t\t\tidmap_.clear();\n> +\t\t\tclear();\n> +\t\t\treturn;\n> +\t\t}\n> +\n> \t\tidmap_[ctrl.first->id()] = ctrl.first;\n> +\t}\n> }\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3BB960F1C\n\tfor ;\n\tMon, 18 Nov 2019 18:16:19 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id m4so14909570ljj.8\n\tfor ;\n\tMon, 18 Nov 2019 09:16:19 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tg14sm9339631lfj.17.2019.11.18.09.16.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2019 09:16:18 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=oTvBgySHDt9XA9yLFwc9YnYXojom89S3BBV3/nHCOeM=;\n\tb=YnB2fExdk20/bdz1vuCeYVmZ6fqhdgWMFUpR4Rba5gijPRtYnBdv82vsuzwVO30Z+D\n\tDo1e2EQeFpu00/1WJShUPtz/0D22dj3mOKmJsx3iZhlEH9FgueR2RSEtD/ND58Gjh3Xh\n\tO3dFU6+NzX3Xavmd1WFkoximJLdWqsl7DLoSHJxCxLRlIJR+z9l4C1j5RsktXiFJs/z1\n\tGQYCHhY4GxcZlYfFJXvQaPxCfrygMOAHVVLUk7wZRo0jszQysJnhtC40N2KkwVs9Kc8E\n\tomCIwBdNZwCF9vzlvwDq5R4bD9tYH1gGGR5TPQIDoOhp7W/l4ZCrNbUhk6Flj0z/Ztsy\n\tezhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=oTvBgySHDt9XA9yLFwc9YnYXojom89S3BBV3/nHCOeM=;\n\tb=pJSEHYF5gZPw+F25/ubcoVLCYkVS8s+AQ0elokvnuuUZ/YfE+7ySeMNTGZPC1V0n+X\n\ttZ1m59AzGCEwBXpGmjtOkqWuDi/rE1TM/jw2Cywy8WNv17B190RHbv2VceKve/vAQAn2\n\t/MJkbQ1qwT0Z9L42cpSbK7Dgvs/yFfODn2y8EPCSFdDml9db0f8KiMWC5z/V8cdXKWxH\n\tepxAx+6QUy0Olv4uaAYdlOX4/6mf2Qd29EiZ5zBfbV5edLnUB8wVt9O3IO4Fq1LwXDCT\n\tNQ4xtJ1NwkvLpvri9f+gU9C/MKA1JsRlCAiEa7OV3WipHNqlQ2opcqUXU5Ea2XBecSTh\n\tE5SQ==","X-Gm-Message-State":"APjAAAWGmmgTz+fj4LWboYEKMiZwUpdjbQY296otYO+84gSvv/Eo6k4N\n\tO9crOgzNBY8txyCm3WWIc0dF3VE2ZME=","X-Google-Smtp-Source":"APXvYqzamWpbxkYL/4IA8/o2pEyqppYqqKEH4sSi8mrsIV3Mx/cBZkXLbx9kekr9mDYxPxrs7ZNi1A==","X-Received":"by 2002:a2e:8e97:: with SMTP id z23mr363724ljk.149.1574097378886;\n\tMon, 18 Nov 2019 09:16:18 -0800 (PST)","Date":"Mon, 18 Nov 2019 18:16:17 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118171617.GF8072@bigcity.dyn.berto.se>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 17:16:19 -0000"}},{"id":3088,"web_url":"https://patchwork.libcamera.org/comment/3088/","msgid":"<20191118225508.yt2pn5hzkqpbgzqi@uno.localdomain>","date":"2019-11-18T22:55:08","subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Nov 18, 2019 at 03:01:33AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Fri, Nov 15, 2019 at 05:21:29PM +0100, Jacopo Mondi wrote:\n> > On Fri, Nov 08, 2019 at 10:53:55PM +0200, Laurent Pinchart wrote:\n> > > ControlInfoMap requires the ControlId and ControlRange of each entry to\n> > > have identical types. Check for this and log an error if a mismatch is\n> > > detected.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/libcamera/controls.cpp | 13 ++++++++++++-\n> > > 1 file changed, 12 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > > index eae0250a92e3..c488b2e4eb3f 100644\n> > > --- a/src/libcamera/controls.cpp\n> > > +++ b/src/libcamera/controls.cpp\n> > > @@ -571,8 +571,19 @@ ControlInfoMap::const_iterator ControlInfoMap::find(unsigned int id) const\n> > > void ControlInfoMap::generateIdmap()\n> > > {\n> > > \tidmap_.clear();\n> > > -\tfor (const auto &ctrl : *this)\n> > > +\n> > > +\tfor (const auto &ctrl : *this) {\n> > > +\t\tif (ctrl.first->type() != ctrl.second.min().type()) {\n> > > +\t\t\tLOG(Controls, Error)\n> > > +\t\t\t\t<< \"Control \" << utils::hex(ctrl.first->id())\n> > > +\t\t\t\t<< \" type and range type mismatch\";\n> > > +\t\t\tidmap_.clear();\n> > > +\t\t\tclear();\n> > > +\t\t\treturn;\n> > > +\t\t}\n> > > +\n> >\n> > Should we just skip the control or actually abort the whole id map\n> > generation ?\n>\n> As this is a serious error, I think we should abort it completely, in\n> order to show that something went wrong. If you think we should just\n> skip the control, we can discuss that.\n>\n\nNo, it's fine.. If this happens there has been a problem during\ndevelopment, is not something a user could trigger.. In this case it's\nbetter to fail loudly\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > > \t\tidmap_[ctrl.first->id()] = ctrl.first;\n> > > +\t}\n> > > }\n> > >\n> > > /**\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AA0260F1C\n\tfor ;\n\tMon, 18 Nov 2019 23:53:06 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D789E1C0006;\n\tMon, 18 Nov 2019 22:53:05 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 18 Nov 2019 23:55:08 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118225508.yt2pn5hzkqpbgzqi@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>\n\t<20191115162129.prthsi3jafzgeooi@uno.localdomain>\n\t<20191118010133.GM4853@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"7tpcdf445tyjgq5t\"","Content-Disposition":"inline","In-Reply-To":"<20191118010133.GM4853@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 22:53:06 -0000"}},{"id":3102,"web_url":"https://patchwork.libcamera.org/comment/3102/","msgid":"<0620e37c-84b1-f7e4-0a2b-22c15215f6b1@ideasonboard.com>","date":"2019-11-19T16:19:45","subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 18/11/2019 01:01, Laurent Pinchart wrote:\n> Hi Jacopo,\n> \n> On Fri, Nov 15, 2019 at 05:21:29PM +0100, Jacopo Mondi wrote:\n>> On Fri, Nov 08, 2019 at 10:53:55PM +0200, Laurent Pinchart wrote:\n>>> ControlInfoMap requires the ControlId and ControlRange of each entry to\n>>> have identical types. Check for this and log an error if a mismatch is\n>>> detected.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> src/libcamera/controls.cpp | 13 ++++++++++++-\n>>> 1 file changed, 12 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n>>> index eae0250a92e3..c488b2e4eb3f 100644\n>>> --- a/src/libcamera/controls.cpp\n>>> +++ b/src/libcamera/controls.cpp\n>>> @@ -571,8 +571,19 @@ ControlInfoMap::const_iterator ControlInfoMap::find(unsigned int id) const\n>>> void ControlInfoMap::generateIdmap()\n>>> {\n>>> \tidmap_.clear();\n>>> -\tfor (const auto &ctrl : *this)\n>>> +\n>>> +\tfor (const auto &ctrl : *this) {\n>>> +\t\tif (ctrl.first->type() != ctrl.second.min().type()) {\n>>> +\t\t\tLOG(Controls, Error)\n>>> +\t\t\t\t<< \"Control \" << utils::hex(ctrl.first->id())\n>>> +\t\t\t\t<< \" type and range type mismatch\";\n>>> +\t\t\tidmap_.clear();\n>>> +\t\t\tclear();\n>>> +\t\t\treturn;\n>>> +\t\t}\n>>> +\n>>\n>> Should we just skip the control or actually abort the whole id map\n>> generation ?\n> \n> As this is a serious error, I think we should abort it completely, in\n> order to show that something went wrong. If you think we should just\n> skip the control, we can discuss that.\n\nIs this serious enough to be Fatal? (to be really noisy?)\n\n(Bearing in mind we still need to look at if Fatal messages are\nnon-fatal when NDEBUG is defined).\n\n--\nKieran\n\n> \n>>> \t\tidmap_[ctrl.first->id()] = ctrl.first;\n>>> +\t}\n>>> }\n>>>\n>>> /**\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5FCB60BC2\n\tfor ;\n\tTue, 19 Nov 2019 17:19:49 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE0B5311;\n\tTue, 19 Nov 2019 17:19:48 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574180389;\n\tbh=GL4oFLQF56RijOL7mIj+GKHvoNmiUv9g3RNfdLSPSsY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=s53R9PcCxsX9mLIoV8HkpYIS2dUAAbZVFxeNR1WUSoZywWVlk0zKcdL2V5nWiM7Ha\n\thUCgvOev1BQP/R9gzEfSdoG0HiQQpm+n5DYEbDSKHJNPgjRdErbx+JZ0ZHTpyuaG3k\n\tzw5I0TuSQwLSoEnvSQtnFYO5tri3gp07JK+Mp+44=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tJacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>\n\t<20191115162129.prthsi3jafzgeooi@uno.localdomain>\n\t<20191118010133.GM4853@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0620e37c-84b1-f7e4-0a2b-22c15215f6b1@ideasonboard.com>","Date":"Tue, 19 Nov 2019 16:19:45 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20191118010133.GM4853@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 Nov 2019 16:19:49 -0000"}},{"id":3109,"web_url":"https://patchwork.libcamera.org/comment/3109/","msgid":"<20191119223634.GI17590@pendragon.ideasonboard.com>","date":"2019-11-19T22:36:34","subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Nov 19, 2019 at 04:19:45PM +0000, Kieran Bingham wrote:\n> On 18/11/2019 01:01, Laurent Pinchart wrote:\n> > On Fri, Nov 15, 2019 at 05:21:29PM +0100, Jacopo Mondi wrote:\n> >> On Fri, Nov 08, 2019 at 10:53:55PM +0200, Laurent Pinchart wrote:\n> >>> ControlInfoMap requires the ControlId and ControlRange of each entry to\n> >>> have identical types. Check for this and log an error if a mismatch is\n> >>> detected.\n> >>>\n> >>> Signed-off-by: Laurent Pinchart \n> >>> ---\n> >>> src/libcamera/controls.cpp | 13 ++++++++++++-\n> >>> 1 file changed, 12 insertions(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> >>> index eae0250a92e3..c488b2e4eb3f 100644\n> >>> --- a/src/libcamera/controls.cpp\n> >>> +++ b/src/libcamera/controls.cpp\n> >>> @@ -571,8 +571,19 @@ ControlInfoMap::const_iterator ControlInfoMap::find(unsigned int id) const\n> >>> void ControlInfoMap::generateIdmap()\n> >>> {\n> >>> \tidmap_.clear();\n> >>> -\tfor (const auto &ctrl : *this)\n> >>> +\n> >>> +\tfor (const auto &ctrl : *this) {\n> >>> +\t\tif (ctrl.first->type() != ctrl.second.min().type()) {\n> >>> +\t\t\tLOG(Controls, Error)\n> >>> +\t\t\t\t<< \"Control \" << utils::hex(ctrl.first->id())\n> >>> +\t\t\t\t<< \" type and range type mismatch\";\n> >>> +\t\t\tidmap_.clear();\n> >>> +\t\t\tclear();\n> >>> +\t\t\treturn;\n> >>> +\t\t}\n> >>> +\n> >>\n> >> Should we just skip the control or actually abort the whole id map\n> >> generation ?\n> > \n> > As this is a serious error, I think we should abort it completely, in\n> > order to show that something went wrong. If you think we should just\n> > skip the control, we can discuss that.\n> \n> Is this serious enough to be Fatal? (to be really noisy?)\n> \n> (Bearing in mind we still need to look at if Fatal messages are\n> non-fatal when NDEBUG is defined).\n\nI'm in two minds about this, for this exact reason, we still need to\ndefine how to handle Fatal errors. I think I would prefer avoiding an\nabort() here until the code gets tested a bit more.\n\n> >>> \t\tidmap_[ctrl.first->id()] = ctrl.first;\n> >>> +\t}\n> >>> }\n> >>>\n> >>> /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D161260BEA\n\tfor ;\n\tTue, 19 Nov 2019 23:36:42 +0100 (CET)","from pendragon.ideasonboard.com (unknown [122.147.213.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 49C13311;\n\tTue, 19 Nov 2019 23:36:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574203002;\n\tbh=GWD4AFaUlnLHfBhfUIL0frXKowfn+jJKt45hI++ix+g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VGARW15gyUkftvDkbTaaQVZncmOMTK72Y0jve9ZpLUm1LjsW915X8h4LXiyx+kPod\n\tf/TK9gzK2Fdwf48pzOekjMYpe1Iw/0WdQ2C7wE7M58DXOpj0H7gSxCcY7P9bXkBZHQ\n\txwHesZgW68e25tQh3lnj6OyFSkHrVBjke0JrbbkM=","Date":"Wed, 20 Nov 2019 00:36:34 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20191119223634.GI17590@pendragon.ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-11-laurent.pinchart@ideasonboard.com>\n\t<20191115162129.prthsi3jafzgeooi@uno.localdomain>\n\t<20191118010133.GM4853@pendragon.ideasonboard.com>\n\t<0620e37c-84b1-f7e4-0a2b-22c15215f6b1@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<0620e37c-84b1-f7e4-0a2b-22c15215f6b1@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 10/24] libcamera: controls: Catch\n\ttype mismatch in ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 Nov 2019 22:36:43 -0000"}}]