{"id":23055,"url":"https://patchwork.libcamera.org/api/patches/23055/?format=json","web_url":"https://patchwork.libcamera.org/patch/23055/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250326134727.279393-2-stefan.klug@ideasonboard.com>","date":"2025-03-26T13:47:20","name":"[v2,1/3] ipa: rkisp1: Add debug log for the sensor controls being set","commit_ref":"94e94c6e8db65ac9f594f8d73f54d38a697fffd0","pull_url":null,"state":"accepted","archived":false,"hash":"8cdcca95dad46012191af7a1619a18cca5a6450d","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23055/mbox/","series":[{"id":5086,"url":"https://patchwork.libcamera.org/api/series/5086/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5086","date":"2025-03-26T13:47:19","name":"rkisp1: Reduce oscillations on startup","version":2,"mbox":"https://patchwork.libcamera.org/series/5086/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23055/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23055/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 155B3C323E\n\tfor ;\n\tWed, 26 Mar 2025 13:48:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C52336896E;\n\tWed, 26 Mar 2025 14:48:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5280A68964\n\tfor ;\n\tWed, 26 Mar 2025 14:48:04 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b21a:42f4:9f3:1df6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F03843A4;\n\tWed, 26 Mar 2025 14:46:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rCin/vsD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742996776;\n\tbh=BBIXwgL7wCZ3yqDdcm03SAcC3tWc9l5qtdDfFPoqbGw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rCin/vsD9OWHjNjXBXakrIYNB4QMrjtOMkAdcUwBz+CsX5qnFhBjHiD5kBLa3uAqF\n\tcZIp/UstPtbBjSkE5rSkEoKXYHaQnMHle3csm74cxqA3v1zhehLiGLlh3tBeCCRSU/\n\te5R78XMOsFVsOfDhCmoXMMWu/IzxUBkkEMRsBwt4=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v2 1/3] ipa: rkisp1: Add debug log for the sensor controls\n\tbeing set","Date":"Wed, 26 Mar 2025 14:47:20 +0100","Message-ID":"<20250326134727.279393-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250326134727.279393-1-stefan.klug@ideasonboard.com>","References":"<20250326134727.279393-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In the algorithm code a lot of information is logged in debug log level,\nbut there is no place where the values sent to the sensor get logged.\nAdd such a log message.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n\n---\n\nChanges in v2:\n- Improved commit message\n- Improved log message and formatting\n- Collected tags\n---\n src/ipa/rkisp1/rkisp1.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 7547d2f274f4..cb487ae53aef 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -455,6 +455,10 @@ void IPARkISP1::setControls(unsigned int frame)\n \tuint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);\n \tuint32_t vblank = frameContext.agc.vblank;\n \n+\tLOG(IPARkISP1, Debug)\n+\t\t<< \"Set controls for frame \" << frame << \": exposure \" << exposure\n+\t\t<< \", gain \" << frameContext.agc.gain << \", vblank \" << vblank;\n+\n \tControlList ctrls(sensorControls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain));\n","prefixes":["v2","1/3"]}