{"id":23052,"url":"https://patchwork.libcamera.org/api/patches/23052/?format=json","web_url":"https://patchwork.libcamera.org/patch/23052/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250326124856.75709-6-mzamazal@redhat.com>","date":"2025-03-26T12:48:54","name":"[v5,5/6] ipa: simple: Report contrast in metadata","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"43eb9220432a485897fd42daa3ccc89703aafe85","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23052/mbox/","series":[{"id":5085,"url":"https://patchwork.libcamera.org/api/series/5085/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5085","date":"2025-03-26T12:48:49","name":"ipa: simple: Introduce metadata reporting","version":5,"mbox":"https://patchwork.libcamera.org/series/5085/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23052/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23052/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99C9EC3213\n\tfor ;\n\tWed, 26 Mar 2025 12:49:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2937F6897E;\n\tWed, 26 Mar 2025 13:49:20 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 292756896F\n\tfor ;\n\tWed, 26 Mar 2025 13:49:17 +0100 (CET)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-106-JjS8ka2cMH6NZS0mm3cFyQ-1;\n\tWed, 26 Mar 2025 08:49:13 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 21CF21800262; Wed, 26 Mar 2025 12:49:12 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.15])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 71DF630001A1; Wed, 26 Mar 2025 12:49:10 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"SCcBmE+g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1742993356;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=07//BQUffZrBR3eUxozOFm9taj4vtZ3e2VEa1P0y3z0=;\n\tb=SCcBmE+gDzLzVEzNYMzodBQfs1kUq5SA5WxRIB8DWmt9XGUBFOBEbWVsOIPUzPlJMwp1VA\n\tK8K0czTIuV3coAA4n7kK3m8i7wenaGfppNS7ct7+VZHI/u0A86TxpBeBU4/yIZzlQp7SaU\n\tjKwFOjV/3C9amwL7+FJlSgnOSLAv+74=","X-MC-Unique":"JjS8ka2cMH6NZS0mm3cFyQ-1","X-Mimecast-MFC-AGG-ID":"JjS8ka2cMH6NZS0mm3cFyQ_1742993352","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v5 5/6] ipa: simple: Report contrast in metadata","Date":"Wed, 26 Mar 2025 13:48:54 +0100","Message-ID":"<20250326124856.75709-6-mzamazal@redhat.com>","In-Reply-To":"<20250326124856.75709-1-mzamazal@redhat.com>","References":"<20250326124856.75709-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"qbbxwXsTGdArcWD3ynCZLIni3b-ZoPUdHSkFMQbzJu4_1742993352","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide the requested contrast value, if any, in the metadata to add to\nthe completed requests.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/lut.cpp | 15 ++++++++++++++-\n src/ipa/simple/algorithms/lut.h | 5 +++++\n src/ipa/simple/ipa_context.h | 1 +\n 3 files changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex a06cdeba..e8638f27 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -87,9 +87,11 @@ int16_t Lut::ccmValue(unsigned int i, float ccm) const\n \n void Lut::prepare(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n-\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t IPAFrameContext &frameContext,\n \t\t DebayerParams *params)\n {\n+\tframeContext.contrast = context.activeState.knobs.contrast;\n+\n \t/*\n \t * Update the gamma table if needed. This means if black level changes\n \t * and since the black level gets updated only if a lower value is\n@@ -139,6 +141,17 @@ void Lut::prepare(IPAContext &context,\n \t}\n }\n \n+void Lut::process([[maybe_unused]] IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t [[maybe_unused]] const SwIspStats *stats,\n+\t\t ControlList &metadata)\n+{\n+\tconst auto &contrast = frameContext.contrast;\n+\tif (contrast)\n+\t\tmetadata.set(controls::Contrast, contrast.value());\n+}\n+\n REGISTER_IPA_ALGORITHM(Lut, \"Lut\")\n \n } /* namespace ipa::soft::algorithms */\ndiff --git a/src/ipa/simple/algorithms/lut.h b/src/ipa/simple/algorithms/lut.h\nindex 77324800..ba8b9021 100644\n--- a/src/ipa/simple/algorithms/lut.h\n+++ b/src/ipa/simple/algorithms/lut.h\n@@ -30,6 +30,11 @@ public:\n \t\t const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t DebayerParams *params) override;\n+\tvoid process(IPAContext &context,\n+\t\t const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const SwIspStats *stats,\n+\t\t ControlList &metadata) override;\n \n private:\n \tvoid updateGammaTable(IPAContext &context);\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex bfac835b..10d539f5 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -74,6 +74,7 @@ struct IPAFrameContext : public FrameContext {\n \t\tdouble red;\n \t\tdouble blue;\n \t} gains;\n+\tstd::optional contrast;\n };\n \n struct IPAContext {\n","prefixes":["v5","5/6"]}