[{"id":3060,"web_url":"https://patchwork.libcamera.org/comment/3060/","msgid":"<20191118171255.GD8072@bigcity.dyn.berto.se>","date":"2019-11-18T17:12:55","subject":"Re: [libcamera-devel] [PATCH v2 08/24] libcamera: controls: Make\n\tControList constructor public","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-11-08 22:53:53 +0200, Laurent Pinchart wrote:\n> We need to construct empty ControlList objects to serialization. Make\n> the constructor public.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 1 +\n> src/libcamera/controls.cpp | 11 +++++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 6bad36cbc369..b35e006bc046 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -188,6 +188,7 @@ private:\n> \tusing ControlListMap = std::unordered_map;\n> \n> public:\n> +\tControlList();\n> \tControlList(const ControlIdMap &idmap, ControlValidator *validator = nullptr);\n> \tControlList(const ControlInfoMap &info, ControlValidator *validator = nullptr);\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index ae6ca2a7cf7e..178ce3d99bce 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -588,6 +588,17 @@ void ControlInfoMap::generateIdmap()\n> * controls.\n> */\n> \n> +/**\n> + * \\brief Construct a ControlList not associated with any object\n> + *\n> + * This constructor is meant to support ControlList serialization and shall not\n> + * be used directly by application.\n> + */\n> +ControlList::ControlList()\n> +\t: validator_(nullptr), idmap_(nullptr)\n> +{\n> +}\n> +\n> /**\n> * \\brief Construct a ControlList with an optional control validator\n> * \\param[in] idmap The ControlId map for the control list target object\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFA6960F1C\n\tfor ;\n\tMon, 18 Nov 2019 18:12:56 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id o65so14438144lff.13\n\tfor ;\n\tMon, 18 Nov 2019 09:12:56 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\t141sm8648131ljj.37.2019.11.18.09.12.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2019 09:12:55 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=6rnqXi6j8vNkhvTCoixkAgL2jWalHbhJtmf8fkzWJks=;\n\tb=0z+F4d08lmG3xI8SoR4nzmdI+Q+SLAHiYu7rJ0VbzjApo/sIA/u9NV4PJWYQ33XWD9\n\tFFC7G69zn2K80PUdG3ShzpqfDLP4kM6oVyqZpWLD5xthVldckC8rVr09y4BxXCnSwK5B\n\tsjyVfw5J7wTxI7Bl+3tiw1ydeNx58AoXr0BmUwA6cfZl9DYkFjcqXkMYggcYsNP8cvmW\n\txvEVww4RltB999D2oJjSsGPVBJEUDeGEmHwIbhf1J5OjG98gWe0ZIZA7cQjXfHcdOWQY\n\th6fc0Zss7r6Kq1kFI6SavfyoS5vx63X5iq8JjYJKxeeGtQ4Rsn+7dWFwtuS8Uv+mQE2Z\n\tkvbw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=6rnqXi6j8vNkhvTCoixkAgL2jWalHbhJtmf8fkzWJks=;\n\tb=HiaJdIXglvCKJh3GYAv4hrXEnbHkTTypRPPw7xrX00yJR9qt2rbsmHZ6ZeFO5xtswM\n\tWw1puJe0Dxb3BHnJuwLmY55gOkjdJjsviX+EqAIqRrnDkNm55HsVBDTqlg7TwnxZSREB\n\tnIGkAN9UlHtSA2qpEZUwIfpMw/iI+dVCo9m5n1IbY4r2hsJrCxDYJLHoJpwnd4cGcx0u\n\t0OdqZo/7UYb2gpiqMPlAefHa+Cc5xggXjdjGHLUh5AB8tiRc+nDB76AxcTPDvcmCovIz\n\tlDMT8snJtNp6dUQbVeCngrTTc3p8RQq8FViGWILZ0htI17GDT+naRVRMFAgKwP5bZDlG\n\twsZA==","X-Gm-Message-State":"APjAAAXyDkPpIXmZ/7Ui94+k4s/DjAY+InSEv4mou0EKSN1tBfEfEmSN\n\tphkoUBYcgBJeV9UnC25mlR1tPw==","X-Google-Smtp-Source":"APXvYqw77vtob8JOMOxPQGrK+hcgT6Zw2FiKiWGtgbBxh4TahFBG36ZjsSSL4KpWvsgcNlbQCoBfMw==","X-Received":"by 2002:a19:6d19:: with SMTP id i25mr364538lfc.178.1574097176394;\n\tMon, 18 Nov 2019 09:12:56 -0800 (PST)","Date":"Mon, 18 Nov 2019 18:12:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118171255.GD8072@bigcity.dyn.berto.se>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108205409.18845-9-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 08/24] libcamera: controls: Make\n\tControList constructor public","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 17:12:57 -0000"}},{"id":3087,"web_url":"https://patchwork.libcamera.org/comment/3087/","msgid":"<20191118225310.hmkumemnpkuzp4uz@uno.localdomain>","date":"2019-11-18T22:53:10","subject":"Re: [libcamera-devel] [PATCH v2 08/24] libcamera: controls: Make\n\tControList constructor public","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Nov 08, 2019 at 10:53:53PM +0200, Laurent Pinchart wrote:\n> We need to construct empty ControlList objects to serialization. Make\n> the constructor public.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/controls.h | 1 +\n> src/libcamera/controls.cpp | 11 +++++++++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 6bad36cbc369..b35e006bc046 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -188,6 +188,7 @@ private:\n> \tusing ControlListMap = std::unordered_map;\n>\n> public:\n> +\tControlList();\n> \tControlList(const ControlIdMap &idmap, ControlValidator *validator = nullptr);\n> \tControlList(const ControlInfoMap &info, ControlValidator *validator = nullptr);\n>\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index ae6ca2a7cf7e..178ce3d99bce 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -588,6 +588,17 @@ void ControlInfoMap::generateIdmap()\n> * controls.\n> */\n>\n> +/**\n> + * \\brief Construct a ControlList not associated with any object\n> + *\n> + * This constructor is meant to support ControlList serialization and shall not\n> + * be used directly by application.\n> + */\n> +ControlList::ControlList()\n> +\t: validator_(nullptr), idmap_(nullptr)\n> +{\n> +}\n> +\n> /**\n> * \\brief Construct a ControlList with an optional control validator\n> * \\param[in] idmap The ControlId map for the control list target object\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 909C260F1C\n\tfor ;\n\tMon, 18 Nov 2019 23:51:14 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id C5D88200007;\n\tMon, 18 Nov 2019 22:51:13 +0000 (UTC)"],"Date":"Mon, 18 Nov 2019 23:53:10 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118225310.hmkumemnpkuzp4uz@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5id5guhcobjxj3v5\"","Content-Disposition":"inline","In-Reply-To":"<20191108205409.18845-9-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 08/24] libcamera: controls: Make\n\tControList constructor public","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 22:51:14 -0000"}}]