{"id":23039,"url":"https://patchwork.libcamera.org/api/patches/23039/?format=json","web_url":"https://patchwork.libcamera.org/patch/23039/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250326090849.15494-5-mzamazal@redhat.com>","date":"2025-03-26T09:08:41","name":"[v8,04/10] libcamera: software_isp: lut: Remove maybe_unused on a used argument","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1fa54d5e324a99c3a1ef4d83e0a4e155ee59ae26","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23039/mbox/","series":[{"id":5083,"url":"https://patchwork.libcamera.org/api/series/5083/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5083","date":"2025-03-26T09:08:37","name":"Software ISP support for CCM","version":8,"mbox":"https://patchwork.libcamera.org/series/5083/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23039/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23039/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02848C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Mar 2025 09:09:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBF9E68965;\n\tWed, 26 Mar 2025 10:09:16 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FC6F68964\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Mar 2025 10:09:14 +0100 (CET)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-103-FpqyfYiiPk2aumBgXqVILQ-1;\n\tWed, 26 Mar 2025 05:09:10 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3A57C1800260; Wed, 26 Mar 2025 09:09:09 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.15])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 3FF421801747; Wed, 26 Mar 2025 09:09:06 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ixW2esHN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1742980153;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=COnBz8zkQz+GsGEmU6FcyK7hkY8EQdVeC5F9jkipGA4=;\n\tb=ixW2esHNUblnmlQmRr5oDBtlpBLohibbsTaBc/smnWIRtxJmM/XparPGMumpgxgXmcPSrs\n\tcaN33GnbHIjcxdKWB/y6UHy+8iJ7bD9cRKD1LN3lA2Dr1qTCUf8cpAGlc/4IzZad9kwtLV\n\tpt0b5NW/sqeYUXCvc+0obSqIGPirF/8=","X-MC-Unique":"FpqyfYiiPk2aumBgXqVILQ-1","X-Mimecast-MFC-AGG-ID":"FpqyfYiiPk2aumBgXqVILQ_1742980149","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[PATCH v8 04/10] libcamera: software_isp: lut: Remove maybe_unused\n\ton a used argument","Date":"Wed, 26 Mar 2025 10:08:41 +0100","Message-ID":"<20250326090849.15494-5-mzamazal@redhat.com>","In-Reply-To":"<20250326090849.15494-1-mzamazal@redhat.com>","References":"<20250326090849.15494-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"mU1TCFmPbVeTdXq9_IWz_GjEHtVMPcAN8WWji3eOU-Y_1742980149","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"`params' argument of Lut::prepare is actually used, let's remove\nmaybe_unused from it.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/lut.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 83df71a9..063bec73 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -83,7 +83,7 @@ void Lut::updateGammaTable(IPAContext &context)\n void Lut::prepare(IPAContext &context,\n \t\t  [[maybe_unused]] const uint32_t frame,\n \t\t  [[maybe_unused]] IPAFrameContext &frameContext,\n-\t\t  [[maybe_unused]] DebayerParams *params)\n+\t\t  DebayerParams *params)\n {\n \t/*\n \t * Update the gamma table if needed. This means if black level changes\n","prefixes":["v8","04/10"]}