[{"id":3059,"web_url":"https://patchwork.libcamera.org/comment/3059/","msgid":"<20191118171107.GC8072@bigcity.dyn.berto.se>","date":"2019-11-18T17:11:07","subject":"Re: [libcamera-devel] [PATCH v2 07/24] libcamera: controls: Make\n\tControlId constructor public","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-11-08 22:53:52 +0200, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> In order to be able to create a ControlId from serialized data, make its\n> constructor public.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 9 ++++-----\n> 1 file changed, 4 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 548c06c65bb6..6bad36cbc369 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -59,16 +59,15 @@ private:\n> class ControlId\n> {\n> public:\n> -\tunsigned int id() const { return id_; }\n> -\tconst std::string &name() const { return name_; }\n> -\tControlType type() const { return type_; }\n> -\n> -protected:\n> \tControlId(unsigned int id, const std::string &name, ControlType type)\n> \t\t: id_(id), name_(name), type_(type)\n> \t{\n> \t}\n> \n> +\tunsigned int id() const { return id_; }\n> +\tconst std::string &name() const { return name_; }\n> +\tControlType type() const { return type_; }\n> +\n> private:\n> \tControlId &operator=(const ControlId &) = delete;\n> \tControlId(const ControlId &) = delete;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9E4660F1C\n\tfor ;\n\tMon, 18 Nov 2019 18:11:08 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id b20so14479089lfp.4\n\tfor ;\n\tMon, 18 Nov 2019 09:11:08 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\td17sm1809034lfm.65.2019.11.18.09.11.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2019 09:11:07 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=pRN+vgMhhNaOS+U93wNPyyLbvqCf93+XM0EnEvK493Q=;\n\tb=NbgLIwo2Y+vXzzImBcGRUO1SdN2jDIN6TAVSDM+5cV+jsxuK/VoaKfjmpy8LaK21Mg\n\tzyOtFyhIu79urhR4Z/SStpW8M+dBP0IExMvCejL+4Q0lPMi+0mG/syRUrhqF9W2IOWT+\n\t8LCnoCGaJddxEM64WRX8hR2DKR+p7QGCYkxAC75CP//nZ/uvhJrraULRXkiTIKaUvdjG\n\tPjlobVGsZCmZBalkKAp/oUgYj9e6nFVJ9UkvgEXq3OtZS7Pxwx7wyrukXOAep5QapenZ\n\t9hYiTjNr7MS8H/+1Tb3xMyLGV7wYAwirmYk6wB9g8mMNN7fTm+Zp0zNh5vRhb1cfhBFg\n\tz2VQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=pRN+vgMhhNaOS+U93wNPyyLbvqCf93+XM0EnEvK493Q=;\n\tb=YWOB6ExYbgCP5YG86GECu1VNyWPlURdai9ATWCiLB0cuW8dQpx8gsl8DuS7wQntuVF\n\tpi4YgswXOQLLyMXJgF/8MJj4b+Xg/HQ5STkHfPeycr0B+2QV1Oq2HxniWgJrSSwF9p1F\n\tudcESz6c1AXqi5f9q/x+IKbykFAk3WmYvKeSzjlQnXdsTM9e928GnDc3GjFw1TGvhB/u\n\tiaKhon46qxaqhriSlTnvYLCoMn52SZNnCR7eMk07PsSH8WBEum4XjQ4Mi7pyLCJL9HnK\n\tjegN4Ut7cAAN/+pwv5462s3xJo9x3th6Bf7NcgmZNkgCItglh05RLYjUuLiQr2ZZ0G2H\n\tyhtA==","X-Gm-Message-State":"APjAAAW5xM+vteEcBUNcW1ekA6kOps2oBjmZI3qhrPDVTprKG4F4OYFv\n\tIEHgD38IQ30F+gOtbIppzlRWd+Aa+1s=","X-Google-Smtp-Source":"APXvYqxgK6Pf3A0PkG1f+7uPzSMCIUKT+65G53pie4P5ynq/rvXJLa9gVSLurTm/Od2L4sSpwJMQGg==","X-Received":"by 2002:ac2:5f0a:: with SMTP id 10mr343962lfq.57.1574097068294; \n\tMon, 18 Nov 2019 09:11:08 -0800 (PST)","Date":"Mon, 18 Nov 2019 18:11:07 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118171107.GC8072@bigcity.dyn.berto.se>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108205409.18845-8-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 07/24] libcamera: controls: Make\n\tControlId constructor public","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 17:11:08 -0000"}}]