[{"id":33877,"web_url":"https://patchwork.libcamera.org/comment/33877/","msgid":"<20250402004042.GA8806@pendragon.ideasonboard.com>","date":"2025-04-02T00:40:42","subject":"Re: [PATCH v2 1/3] ipa: libipa: Allow retrieving the name of a\n\tCameraSensorHelperFactory","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Mar 26, 2025 at 05:00:31PM +0900, Paul Elder wrote:\n> From: Kieran Bingham \n> \n> Support the test suite iterating the factories by exposing a const\n> retriever of the factory name.\n> \n> Signed-off-by: Kieran Bingham \n> Signed-off-by: Paul Elder \n> ---\n> Changes in v2:\n> - recover from bitrot\n> ---\n> src/ipa/libipa/camera_sensor_helper.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index a9300a64f1e7..92f527108137 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -60,6 +60,8 @@ public:\n> \n> \tstatic std::vector &factories();\n> \n> +\tconst std::string &name() const { return name_; };\n\nDrop the final semicolon.\n\nReviewed-by: Laurent Pinchart \n\n> +\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D683AC323E\n\tfor ;\n\tWed, 2 Apr 2025 00:41:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9BCE68981;\n\tWed, 2 Apr 2025 02:41:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C949362C65\n\tfor ;\n\tWed, 2 Apr 2025 02:41:06 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 052DE316;\n\tWed, 2 Apr 2025 02:39:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gJgYbrO2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743554354;\n\tbh=Bc2O1clXNZynK5Eu1SqyRI6UrTHg7zEEmqhxKwjwK1M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gJgYbrO2Sx48TVvmK0XBTHTejWu8oCKYxWmQuLeGcrB8ZZvOA6zqb70sQpd7Gwqoc\n\tSDukS/u/OeIh75EdNDx57X6Oq7STU/zuvIm85AcL++xNYu5PEoU+T0KSpiQh2HI/Bm\n\t96R5oNLaAeKcGQWV1QKWTZWPBZT8vTXjNLOa3DV8=","Date":"Wed, 2 Apr 2025 03:40:42 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 1/3] ipa: libipa: Allow retrieving the name of a\n\tCameraSensorHelperFactory","Message-ID":"<20250402004042.GA8806@pendragon.ideasonboard.com>","References":"<20250326080034.1733385-1-paul.elder@ideasonboard.com>\n\t<20250326080034.1733385-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250326080034.1733385-2-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]