[{"id":33762,"web_url":"https://patchwork.libcamera.org/comment/33762/","msgid":"","date":"2025-03-28T20:43:13","subject":"Re: [PATCH 1/3] libcamera: framebuffer: Add offset field to metadata","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Hi,\n\nLe mercredi 26 mars 2025 à 16:51 +0900, Paul Elder a écrit :\n> Add an offset field to the frame metadata so that it can be reported\n> to\n> the application.\n> \n> Signed-off-by: Paul Elder \n> ---\n>  include/libcamera/framebuffer.h | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/framebuffer.h\n> b/include/libcamera/framebuffer.h\n> index ff83924300ac..f6fa1fd510a7 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -30,6 +30,7 @@ struct FrameMetadata {\n>  \n>  \tstruct Plane {\n>  \t\tunsigned int bytesused;\n> +\t\tunsigned int offset;\n>  \t};\n\nSimilar to what we did for \"bytesused\", documentation is needed in\nsrc/libcamera/buffer.cpp.\n\nNicolas\n\n>  \n>  \tStatus status;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BA3AC323E\n\tfor ;\n\tFri, 28 Mar 2025 20:43:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABE1F6897A;\n\tFri, 28 Mar 2025 21:43:16 +0100 (CET)","from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com\n\t[IPv6:2607:f8b0:4864:20::f29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77AFD614E8\n\tfor ;\n\tFri, 28 Mar 2025 21:43:15 +0100 (CET)","by mail-qv1-xf29.google.com with SMTP id\n\t6a1803df08f44-6e8ffa00555so21278056d6.0\n\tfor ;\n\tFri, 28 Mar 2025 13:43:15 -0700 (PDT)","from ?IPv6:2606:6d00:11:e976::5ac? ([2606:6d00:11:e976::5ac])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-6eec962817csm15346636d6.18.2025.03.28.13.43.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 28 Mar 2025 13:43:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"Zle3Esct\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1743194594;\n\tx=1743799394; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0qFfxOerBPxMp6lBrHByR4yc9h0lnDtKPP0wqTjAxXo=;\n\tb=Zle3EsctqDQVw4QIKMzyZ029j9bz4SfaDoHxyG/G1FgPWsFoWp9x0t55Uc9/ohOVAH\n\tKQ/9fv63uiBc24QbRyxej/EZ8iPhyX6v7ChCDHeV4VuEHQWRTZ3MDNs1o9r+0JLN5IRB\n\ttfszKuASQ3aNCMzBjgwA0YXE+p9aKWg1lGt5NRaf65q9zgsTGoW6RPZ5tCbQz6BY8d1Q\n\tAlGE17x+ZbEkL01zsvwN+eoEWN9xxd5q7i+3d3/8l7KpRDY023LWPkZYfPO+1WCmow18\n\tlFTGbftcQPZzx7NtYpzVyZEzgom3SrBM4EBSkw+0HBs8an2XPYyJ4EScfwWJqscdMFWm\n\tGFSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1743194594; x=1743799394;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=0qFfxOerBPxMp6lBrHByR4yc9h0lnDtKPP0wqTjAxXo=;\n\tb=sOvzvDBUUafuvyVKo4l8XjEsC3xKNLzF1d//krqEriDB5yKvMoYQ8Txi9UBwZLkXrh\n\tc8Urj/shORYv6mp9xbuSsWOd8dv5jLCPFyPPjq60yxUbrmeWV0r2A58g7hVm0kg+7JHa\n\tBmMLx3Fkuy4UQlP3I5GV+Tt3AbKlwMCbdC5DL/2oY/5MNMUfoVf2sVRkYFlPPHzItd4C\n\tEjNPIJq6oKlc63e5cDa0kB3KTjImdmWaSGXoORRv54+1az73R5H8Hx0IwXikmwEhqSbs\n\tRtfBMK50aoIIspokEpytkcagUOA4prrgQaxwd4ewOXWJZASFnmbQ2yhIKbpYVjrnFvoK\n\t8/FQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUQ7c5RH4rx0XdUXS6Za/1WalS1P7olc46uPOF6AqEotseliog+zhUBwsD6ReguuoLqCDMwCUZQZpwj0vbmtJg=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yz95ZxbnvznKeMyvAGW9xpOh+cM5z8I2ldztatGW6M8SCJfMAGG\n\t/EV2NsBTlXOtF2XXXlBa+uGXUCWdZjVD/IT/z1E5moZ9E40S8qsxhciWD0SyGrNhrinLRdcXe5A\n\tr","X-Gm-Gg":"ASbGnctgjrPl+aE0BSeNBIctf5VnMgSwWbZjpacQfcDuAdXqGhhqB8LFA2FcIPtZwnz\n\tQ7lC1a8nn70jMZIuOcgmgZXVt9e6mocuC7+e39kWhFaPt2Jempo8pEBiaIVi5qaaDMf0fj/yoXk\n\tSi1j1du0ngi2V5/T7UsxY2dpVaVgy+x/fXBIkmk25UyUTXAuWt06dz8Vsex7RVBqH+PRm3YekBJ\n\tIUEuiIll9QGPCkDYCwq8+/Kl+MKdvpqMSSTB53bRL8ZiJsLdMMJYyI2P45x2oKmDj6abCW1wehq\n\twpigOKKLCoPQp3Y57Tlk41CHhi1clNsuceIyV2BbrGKpM0HOPQ==","X-Google-Smtp-Source":"AGHT+IF2lu1kP3fhCB+OtBxgrqmUmj3q0wpIOnGMmlwqrc8/ed61SGIdrZZgG+TuSiVTpueFz+Rclw==","X-Received":"by 2002:ad4:5cc4:0:b0:6d9:3016:d101 with SMTP id\n\t6a1803df08f44-6eed629e7c3mr6840906d6.41.1743194594138; \n\tFri, 28 Mar 2025 13:43:14 -0700 (PDT)","Message-ID":"","Subject":"Re: [PATCH 1/3] libcamera: framebuffer: Add offset field to metadata","From":"Nicolas Dufresne ","To":"Paul Elder , \n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 28 Mar 2025 16:43:13 -0400","In-Reply-To":"<20250326075129.1705736-2-paul.elder@ideasonboard.com>","References":"<20250326075129.1705736-1-paul.elder@ideasonboard.com>\n\t<20250326075129.1705736-2-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.54.3 (3.54.3-1.fc41) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33875,"web_url":"https://patchwork.libcamera.org/comment/33875/","msgid":"<20250401234547.GP3494@pendragon.ideasonboard.com>","date":"2025-04-01T23:45:47","subject":"Re: [PATCH 1/3] libcamera: framebuffer: Add offset field to metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Mar 26, 2025 at 04:51:25PM +0900, Paul Elder wrote:\n> Add an offset field to the frame metadata so that it can be reported to\n> the application.\n\nWe need documentation here. In particular, you'll need to explain how\nthis differs from FrameBuffer::Plane::offset.\n\n> Signed-off-by: Paul Elder \n> ---\n> include/libcamera/framebuffer.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> index ff83924300ac..f6fa1fd510a7 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -30,6 +30,7 @@ struct FrameMetadata {\n> \n> \tstruct Plane {\n> \t\tunsigned int bytesused;\n> +\t\tunsigned int offset;\n> \t};\n> \n> \tStatus status;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CC3DC323E\n\tfor ;\n\tTue, 1 Apr 2025 23:46:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4578C68967;\n\tWed, 2 Apr 2025 01:46:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF16062C65\n\tfor ;\n\tWed, 2 Apr 2025 01:46:13 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF6F06D5;\n\tWed, 2 Apr 2025 01:44:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DSLG+htr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743551061;\n\tbh=NN2gYBfLclRcZPm5ndes8jbJBJB/0phPfuDHdl+wNA0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DSLG+htrUxmanYozEtcGCIUdntEZ60QHGjh2ARSF5Mnr2oE/OOQkte8ngQtSpquLc\n\twkexZY1zxyNSakiTSnnEQSF8+HNQ+Rb5Wxs9FT+hAlOgtBpP+sGR/9avC4DaX6TlSb\n\tg2X1GOomGm+oY7I44GNJvXuaT6Xlsd9P1e1qZgDI=","Date":"Wed, 2 Apr 2025 02:45:47 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] libcamera: framebuffer: Add offset field to metadata","Message-ID":"<20250401234547.GP3494@pendragon.ideasonboard.com>","References":"<20250326075129.1705736-1-paul.elder@ideasonboard.com>\n\t<20250326075129.1705736-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250326075129.1705736-2-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]