[{"id":33722,"web_url":"https://patchwork.libcamera.org/comment/33722/","msgid":"<20250326130328.GC8303@pendragon.ideasonboard.com>","date":"2025-03-26T13:03:28","subject":"Re: [RFC PATCH v3 3/9] libcamera: process: Use `pid_` member to\n\tdecide if running","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi barnabás,\n\nThank you for the patch.\n\nOn Tue, Mar 25, 2025 at 07:08:15PM +0100, Barnabás Pőcze wrote:\n> Instead of using a separate member variable, use `pid_ > 0` to determine\n> if the process is still running. Previously the value of `pid_` was not\n> reset to -1 when the process terminated, but since it is only meaningful\n> while the process is running, reset it to -1 in `Process::died()`.\n> \n> Neither `pid_` nor `running_` are exposed, so this change has no effect\n> on the public interface or observable behaviour.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/process.h | 1 -\n> src/libcamera/process.cpp | 8 +++-----\n> 2 files changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> index 58e3e41ce..030a1e66e 100644\n> --- a/include/libcamera/internal/process.h\n> +++ b/include/libcamera/internal/process.h\n> @@ -49,7 +49,6 @@ private:\n> \tvoid died(int wstatus);\n> \n> \tpid_t pid_;\n> -\tbool running_;\n> \tenum ExitStatus exitStatus_;\n> \tint exitCode_;\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 567b878d4..aa9e8f519 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -208,7 +208,7 @@ const struct sigaction &ProcessManager::oldsa() const\n> */\n> \n> Process::Process()\n> -\t: pid_(-1), running_(false), exitStatus_(NotExited), exitCode_(0)\n> +\t: pid_(-1), exitStatus_(NotExited), exitCode_(0)\n> {\n> }\n> \n> @@ -240,7 +240,7 @@ int Process::start(const std::string &path,\n> {\n> \tint ret;\n> \n> -\tif (running_)\n> +\tif (pid_ > 0)\n> \t\treturn 0;\n> \n> \tint childPid = fork();\n> @@ -252,8 +252,6 @@ int Process::start(const std::string &path,\n> \t\tpid_ = childPid;\n> \t\tProcessManager::instance()->registerProcess(this);\n> \n> -\t\trunning_ = true;\n> -\n> \t\treturn 0;\n> \t} else {\n> \t\tif (isolate())\n> @@ -327,7 +325,7 @@ int Process::isolate()\n> */\n> void Process::died(int wstatus)\n> {\n> -\trunning_ = false;\n> +\tpid_ = -1;\n> \texitStatus_ = WIFEXITED(wstatus) ? NormalExit : SignalExit;\n> \texitCode_ = exitStatus_ == NormalExit ? WEXITSTATUS(wstatus) : -1;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E000DC323E\n\tfor ;\n\tWed, 26 Mar 2025 13:03:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 328776896F;\n\tWed, 26 Mar 2025 14:03:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C57FF68967\n\tfor ;\n\tWed, 26 Mar 2025 14:03:50 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5643A57;\n\tWed, 26 Mar 2025 14:02:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DgpSqhWe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742994123;\n\tbh=4IZLGXY8CZzjMAbxQK5h3k2T/Lg2NMoo6SP3WGCu7ns=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DgpSqhWesVo/nQCW5Zcw50i4OA4flrcdI3yfoS+ykCDrzWI9UG3ZLbEkL72Aw5m2e\n\tpLk1kXUwn5u6OvGSgVNYW7eH12eqgUfealVgSOnxKhErh1llqvjdG4SeHhtzrJxnqs\n\t3OY9bZS11UkZmmL/6UQFvsnk6TOu4FYTZiXG7ekw=","Date":"Wed, 26 Mar 2025 15:03:28 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v3 3/9] libcamera: process: Use `pid_` member to\n\tdecide if running","Message-ID":"<20250326130328.GC8303@pendragon.ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-4-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250325180821.1456154-4-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]