[{"id":33721,"web_url":"https://patchwork.libcamera.org/comment/33721/","msgid":"<20250326130123.GB8303@pendragon.ideasonboard.com>","date":"2025-03-26T13:01:23","subject":"Re: [RFC PATCH v3 2/9] libcamera: process: Misc. cleanup around\n\t`execv()`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Mar 25, 2025 at 07:08:14PM +0100, Barnabás Pőcze wrote:\n> Firstly, get the number of arguments first, and use that to determine the\n> size of the allocation instead of retrieving it twice.\n> \n> Secondly, use `const_cast` instead of a C-style cast when calling `execv()`.\n> \n> Third, use `size_t` to match the type of `args.size()`.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/process.cpp | 9 +++++----\n> 1 file changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 68fad3270..567b878d4 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -265,14 +265,15 @@ int Process::start(const std::string &path,\n> \t\tif (file && strcmp(file, \"syslog\"))\n> \t\t\tunsetenv(\"LIBCAMERA_LOG_FILE\");\n> \n> -\t\tconst char **argv = new const char *[args.size() + 2];\n> -\t\tunsigned int len = args.size();\n> +\t\tsize_t len = args.size();\n\nWhile at it,\n\n\t\tconst size_t len = args.size();\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tauto argv = std::make_unique(len + 2);\n> +\n> \t\targv[0] = path.c_str();\n> -\t\tfor (unsigned int i = 0; i < len; i++)\n> +\t\tfor (size_t i = 0; i < len; i++)\n> \t\t\targv[i + 1] = args[i].c_str();\n> \t\targv[len + 1] = nullptr;\n> \n> -\t\texecv(path.c_str(), (char **)argv);\n> +\t\texecv(path.c_str(), const_cast(argv.get()));\n> \n> \t\texit(EXIT_FAILURE);\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95A4EC323E\n\tfor ;\n\tWed, 26 Mar 2025 13:01:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10A0C6896A;\n\tWed, 26 Mar 2025 14:01:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 996ED68964\n\tfor ;\n\tWed, 26 Mar 2025 14:01:46 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 702BD3A4;\n\tWed, 26 Mar 2025 13:59:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SYikq1Pb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742993998;\n\tbh=X/0dJn77GWljoemX323POiyCeOMv/Im6IDXhMcPBF0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SYikq1Pb6aRBbcsFBg7K1RlHcM3u6EYUarTHLL4+DUHuySs0+7ejv9+XhSfFAXA3P\n\t9o2M1kxnc2bXxBfjTMEfccfzD5NtSOnPb04apoB/sU6dZLAEcz9cDRY0wLLybmCIYX\n\tuN0CuXX4hYjxCjvIyhCZroSOPXXTQxfIL7Sm3H2Y=","Date":"Wed, 26 Mar 2025 15:01:23 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v3 2/9] libcamera: process: Misc. cleanup around\n\t`execv()`","Message-ID":"<20250326130123.GB8303@pendragon.ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-3-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250325180821.1456154-3-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]