{"id":23020,"url":"https://patchwork.libcamera.org/api/patches/23020/?format=json","web_url":"https://patchwork.libcamera.org/patch/23020/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250325180821.1456154-3-barnabas.pocze@ideasonboard.com>","date":"2025-03-25T18:08:14","name":"[RFC,v3,2/9] libcamera: process: Misc. cleanup around `execv()`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3cc45eb2219f9170df277784e824bf284aa00c57","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23020/mbox/","series":[{"id":5079,"url":"https://patchwork.libcamera.org/api/series/5079/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5079","date":"2025-03-25T18:08:12","name":"libcamera: process: Remove `ProcessManager` singleton","version":3,"mbox":"https://patchwork.libcamera.org/series/5079/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23020/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23020/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":["parsemail@patchwork.libcamera.org","kbingham@ideasonboard.com"],"Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4DE9C323E\n\tfor ;\n\tTue, 25 Mar 2025 19:20:38 +0000 (UTC)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56ECC353\n\tfor ;\n\tTue, 25 Mar 2025 20:18:51 +0100 (CET)","from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id KK2/Bsjw4mfwuS8A4E0KoQ\n\t(envelope-from )\n\tfor ; Tue, 25 Mar 2025 19:07:04 +0100","from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid E6E21353;\tTue, 25 Mar 2025 19:07:03 +0100 (CET)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5CCE68960;\n\tTue, 25 Mar 2025 19:08:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD97568957\n\tfor ;\n\tTue, 25 Mar 2025 19:08:43 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DC89353\n\tfor ;\n\tTue, 25 Mar 2025 19:06:55 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742930331;\n\tbh=ySDDXkgoPdzwPs6BoIxoTD3UqhqnC2eULU57oLYyKqU=;\n\th=From:To:Subject:Date:In-Reply-To:References:List-Id:\n\tList-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\tResent-From:Resent-To:From;\n\tb=n0Qf9gYmazO6F3KspIK06H3QR0KyvJqhBx2X9rUiGH1Uo6mQd49pxrnYqanNHFpLz\n\tCqGGct6cpu/jdu0l40EEBQFCOvDLw19opQlgMeRJLOT7Ojw4bijYi99Q3YCpKtr3Un\n\tUh8U40DonFx/5rEedgYpWroCz7qfsT34+5rMvaro=","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742926016;\n\tbh=fBLhKYdPjRhaI/DNIgvU+LareB5sr4B2UxeoLiLrgWI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=g4VJXIQZ2LNhHK/LlpAI4R3gFR3M1ra0k2HJrFhJ5TgBemzftF0L9LU82wSOMwJvm\n\t/R+aIydTyQ20mxvDHvEYyclzToiy2quSN30xw7yqwHc849AwWqINbVq2taCrWfS4BB\n\t+OTUgUBUOTAg8y+2ckSvrantQE8hKLY/Vnj29Yk8="],"Authentication-Results":["perceval.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.a=rsa-sha256 header.s=mail header.b=g4VJXIQZ; dkim-atps=neutral","lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"g4VJXIQZ\";\tdkim-atps=neutral"],"From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v3 2/9] libcamera: process: Misc. cleanup around\n\t`execv()`","Date":"Tue, 25 Mar 2025 19:08:14 +0100","Message-ID":"<20250325180821.1456154-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" ","X-TUID":"kdcxRDvFkBCb","Resent-From":"Kieran Bingham ","Resent-To":"parsemail@patchwork.libcamera.org"},"content":"Firstly, get the number of arguments first, and use that to determine the\nsize of the allocation instead of retrieving it twice.\n\nSecondly, use `const_cast` instead of a C-style cast when calling `execv()`.\n\nThird, use `size_t` to match the type of `args.size()`.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/process.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 68fad3270..567b878d4 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -265,14 +265,15 @@ int Process::start(const std::string &path,\n \t\tif (file && strcmp(file, \"syslog\"))\n \t\t\tunsetenv(\"LIBCAMERA_LOG_FILE\");\n \n-\t\tconst char **argv = new const char *[args.size() + 2];\n-\t\tunsigned int len = args.size();\n+\t\tsize_t len = args.size();\n+\t\tauto argv = std::make_unique(len + 2);\n+\n \t\targv[0] = path.c_str();\n-\t\tfor (unsigned int i = 0; i < len; i++)\n+\t\tfor (size_t i = 0; i < len; i++)\n \t\t\targv[i + 1] = args[i].c_str();\n \t\targv[len + 1] = nullptr;\n \n-\t\texecv(path.c_str(), (char **)argv);\n+\t\texecv(path.c_str(), const_cast(argv.get()));\n \n \t\texit(EXIT_FAILURE);\n \t}\n","prefixes":["RFC","v3","2/9"]}