[{"id":33706,"web_url":"https://patchwork.libcamera.org/comment/33706/","msgid":"<174293588681.2462359.1317994899544342326@ping.linuxembedded.co.uk>","date":"2025-03-25T20:51:26","subject":"Re: [RFC PATCH v3 5/9] libcamera: process: Ensure that file\n\tdescriptors are nonnegative","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-25 18:08:17)\n> Return `-EINVAL` from `Process::start()` if any of the file\n> descriptors are negative as those most likely signal some\n> kind of issue such as missed error checking.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/process.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 716523acc..62e63255b 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -243,6 +243,11 @@ int Process::start(const std::string &path,\n> if (pid_ > 0)\n> return -EBUSY;\n> \n> + for (int fd : fds) {\n> + if (fd < 0)\n> + return -EINVAL;\n> + }\n> +\n> int childPid = fork();\n> if (childPid == -1) {\n> ret = -errno;\n> @@ -282,6 +287,8 @@ void Process::closeAllFdsExcept(const std::vector &fds)\n> std::vector v(fds);\n> sort(v.begin(), v.end());\n> \n> + ASSERT(v.empty() || v.front() >= 0);\n> +\n> DIR *dir = opendir(\"/proc/self/fd\");\n> if (!dir)\n> return;\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8282DC323E\n\tfor ;\n\tTue, 25 Mar 2025 20:51:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B04668952;\n\tTue, 25 Mar 2025 21:51:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 871CE600EB\n\tfor ;\n\tTue, 25 Mar 2025 21:51:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1897C2C6;\n\tTue, 25 Mar 2025 21:49:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kmskb2et\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742935782;\n\tbh=eABYyCvUoydkSs6BNzdBmMZvNfDNpCQB/ZS6UwwlSCM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=kmskb2etrHbBd8DC8G4pAjcjh+l/wT0mNw+ZQHLobndJNlNYXMhsg5Zl00QxCh+Ed\n\tuBPS5pc/ENFggK8gbYxewx4kgVMfngr03JF9Q9FQ60EMRT9X63RNrLJL+vm2nNeWAs\n\tIBx3/r1QaHdvkyoLSinqkdmeDuC60thX4LZB/7QA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250325180821.1456154-6-barnabas.pocze@ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-6-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v3 5/9] libcamera: process: Ensure that file\n\tdescriptors are nonnegative","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Mar 2025 20:51:26 +0000","Message-ID":"<174293588681.2462359.1317994899544342326@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33724,"web_url":"https://patchwork.libcamera.org/comment/33724/","msgid":"<20250326130846.GE8303@pendragon.ideasonboard.com>","date":"2025-03-26T13:08:46","subject":"Re: [RFC PATCH v3 5/9] libcamera: process: Ensure that file\n\tdescriptors are nonnegative","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Mar 25, 2025 at 07:08:17PM +0100, Barnabás Pőcze wrote:\n> Return `-EINVAL` from `Process::start()` if any of the file\n> descriptors are negative as those most likely signal some\n> kind of issue such as missed error checking.\n\nFeel free to go up to the 72 columns limit :-)\n\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/process.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 716523acc..62e63255b 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -243,6 +243,11 @@ int Process::start(const std::string &path,\n> \tif (pid_ > 0)\n> \t\treturn -EBUSY;\n> \n> +\tfor (int fd : fds) {\n> +\t\tif (fd < 0)\n> +\t\t\treturn -EINVAL;\n> +\t}\n> +\n> \tint childPid = fork();\n> \tif (childPid == -1) {\n> \t\tret = -errno;\n> @@ -282,6 +287,8 @@ void Process::closeAllFdsExcept(const std::vector &fds)\n> \tstd::vector v(fds);\n> \tsort(v.begin(), v.end());\n> \n> +\tASSERT(v.empty() || v.front() >= 0);\n> +\n> \tDIR *dir = opendir(\"/proc/self/fd\");\n> \tif (!dir)\n> \t\treturn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EC84C3213\n\tfor ;\n\tWed, 26 Mar 2025 13:09:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39E186896E;\n\tWed, 26 Mar 2025 14:09:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0989568967\n\tfor ;\n\tWed, 26 Mar 2025 14:09:09 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF0C83A4;\n\tWed, 26 Mar 2025 14:07:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R/axMLGP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742994441;\n\tbh=AZgnX6zuiKuiytdr5NT+w8ANXyAt6njHgjohlliCo94=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R/axMLGPJCiVjHB5y9VmMYvx5fmcj8RLPejUVP5YLrz/aK25Yn8Sk+r5KmLgd6U4A\n\tsG40U4qOj2/udIOlzlEQVM0xpn/NJ8XcrviPWxbiAn2JS08ZugWce74dcL8S7RhAk5\n\tXPAvj9yCw8nJo34iAjdQig8ttKZg8+4AfWqqCBCo=","Date":"Wed, 26 Mar 2025 15:08:46 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v3 5/9] libcamera: process: Ensure that file\n\tdescriptors are nonnegative","Message-ID":"<20250326130846.GE8303@pendragon.ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-6-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250325180821.1456154-6-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]