[{"id":33704,"web_url":"https://patchwork.libcamera.org/comment/33704/","msgid":"<174293001198.2136573.8008725805347791531@ping.linuxembedded.co.uk>","date":"2025-03-25T19:13:31","subject":"Re: [RFC PATCH v3 4/9] libcamera: process: Return error if already\n\trunning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-25 18:08:16)\n> Returning 0 when a running process is already managed can be\n> confusing since the parameters might be completely different,\n> causing the caller to mistakenly assume that the program it\n> specified has been started.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/process.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index aa9e8f519..716523acc 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -241,7 +241,7 @@ int Process::start(const std::string &path,\n> int ret;\n> \n> if (pid_ > 0)\n> - return 0;\n> + return -EBUSY;\n\nSeems reasonable. I assume we don't hit this anywhere currently ;-)\n\n\nReviewed-by: Kieran Bingham \n\n> \n> int childPid = fork();\n> if (childPid == -1) {\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A5F9C3213\n\tfor ;\n\tTue, 25 Mar 2025 19:13:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19BDA68956;\n\tTue, 25 Mar 2025 20:13:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0DD7600EB\n\tfor ;\n\tTue, 25 Mar 2025 20:13:34 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6128B353;\n\tTue, 25 Mar 2025 20:11:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u8vCk4Xh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742929907;\n\tbh=LYonoxvsaf8hhYmTefN9JUq6DCRNCHYDFJA69I+0oGM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=u8vCk4XhOM1cdJKgglc4rXhZFhYjzpb0wshjXIkaGO3LCPHSJ2s0VYg1LHYDqwlbX\n\t+YwX9mhueHHr6f7efbY3Y3pYHuyNPMOrPIgTyRejOgw9e6mQUZeTpr5d+Ld82TLOko\n\t3XVo6/VAwSv2mu6evlvsjzeHtzVZZgVB1mIf1PHg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250325180821.1456154-5-barnabas.pocze@ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-5-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v3 4/9] libcamera: process: Return error if already\n\trunning","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Mar 2025 19:13:31 +0000","Message-ID":"<174293001198.2136573.8008725805347791531@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33723,"web_url":"https://patchwork.libcamera.org/comment/33723/","msgid":"<20250326130623.GD8303@pendragon.ideasonboard.com>","date":"2025-03-26T13:06:23","subject":"Re: [RFC PATCH v3 4/9] libcamera: process: Return error if already\n\trunning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Mar 25, 2025 at 07:08:16PM +0100, Barnabás Pőcze wrote:\n> Returning 0 when a running process is already managed can be\n> confusing since the parameters might be completely different,\n> causing the caller to mistakenly assume that the program it\n> specified has been started.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/process.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index aa9e8f519..716523acc 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -241,7 +241,7 @@ int Process::start(const std::string &path,\n> \tint ret;\n> \n> \tif (pid_ > 0)\n> -\t\treturn 0;\n> +\t\treturn -EBUSY;\n> \n> \tint childPid = fork();\n> \tif (childPid == -1) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4772BC3213\n\tfor ;\n\tWed, 26 Mar 2025 13:06:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61ED46896F;\n\tWed, 26 Mar 2025 14:06:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27ECB68967\n\tfor ;\n\tWed, 26 Mar 2025 14:06:46 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00E283A4;\n\tWed, 26 Mar 2025 14:04:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mLXgyZ8T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742994298;\n\tbh=LLVi4btv/TPhgn6Ev1MStgvwM3pUXbeYQroGuchy+V4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mLXgyZ8TPr6b0jvZ+cU+WTrf2wobXO4IQGNLJAcUqOt0YXJnG1lyAfLku6MErN/tZ\n\tXDNhaU6GuAyUCrolV9CrfL1otBwEGmxSsJ0RiFR+lOvy5yN1k8YB7PwLdciRtELjFg\n\t3PNMP7FO5NTpnSTpv7VWmQhXoK4y8fCv70PpFDzo=","Date":"Wed, 26 Mar 2025 15:06:23 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v3 4/9] libcamera: process: Return error if already\n\trunning","Message-ID":"<20250326130623.GD8303@pendragon.ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-5-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250325180821.1456154-5-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]