{"id":23016,"url":"https://patchwork.libcamera.org/api/patches/23016/?format=json","web_url":"https://patchwork.libcamera.org/patch/23016/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250325180821.1456154-5-barnabas.pocze@ideasonboard.com>","date":"2025-03-25T18:08:16","name":"[RFC,v3,4/9] libcamera: process: Return error if already running","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3cf35decd8df98f157ae4b69bc421e36632804f0","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23016/mbox/","series":[],"comments":"https://patchwork.libcamera.org/api/patches/23016/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23016/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 910C5C331F\n\tfor ;\n\tTue, 25 Mar 2025 18:08:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 964BE617F4;\n\tTue, 25 Mar 2025 19:08:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EE61617F4\n\tfor ;\n\tTue, 25 Mar 2025 19:08:45 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD69F353\n\tfor ;\n\tTue, 25 Mar 2025 19:06:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dY1dpBEO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742926018;\n\tbh=Ft53fGQESzh6DOjVPcyuR81DITUSnZVDnmKf7TSkSM0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=dY1dpBEOV+0Yn4413XH5UEYJXeamxWP0z32GLeWxXCdRXVsMq2CQA0SZ8VXStm97P\n\tFWGIklZEqcjsrgqBVNXENzV+MKWTU3/WBrqkDSGGJo8GleEWh49AoeV/ETtsYVEEdO\n\ttH0chfqmof+DsAgnzvrvoeS+qxjhRQHaHCZpzhWI=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v3 4/9] libcamera: process: Return error if already\n\trunning","Date":"Tue, 25 Mar 2025 19:08:16 +0100","Message-ID":"<20250325180821.1456154-5-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Returning 0 when a running process is already managed can be\nconfusing since the parameters might be completely different,\ncausing the caller to mistakenly assume that the program it\nspecified has been started.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/process.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex aa9e8f519..716523acc 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -241,7 +241,7 @@ int Process::start(const std::string &path,\n \tint ret;\n \n \tif (pid_ > 0)\n-\t\treturn 0;\n+\t\treturn -EBUSY;\n \n \tint childPid = fork();\n \tif (childPid == -1) {\n","prefixes":["RFC","v3","4/9"]}