[{"id":33701,"web_url":"https://patchwork.libcamera.org/comment/33701/","msgid":"<174292979585.2136573.1955069318414730189@ping.linuxembedded.co.uk>","date":"2025-03-25T19:09:55","subject":"Re: [RFC PATCH v3 1/9] libcamera: process: Disable copy/move","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-25 18:08:13)\n> A `Process` object has address identity because a pointer\n> to it is stored inside the `ProcessManager`. However, copy/move\n> special methods are still generated by the compiler. So disable\n> them to avoid potential issues and confusion.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/process.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> index b1d07a5a5..58e3e41ce 100644\n> --- a/include/libcamera/internal/process.h\n> +++ b/include/libcamera/internal/process.h\n> @@ -42,6 +42,8 @@ public:\n> Signal finished;\n> \n> private:\n> + LIBCAMERA_DISABLE_COPY_AND_MOVE(Process)\n> +\n> void closeAllFdsExcept(const std::vector &fds);\n> int isolate();\n> void died(int wstatus);\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B546AC323E\n\tfor ;\n\tTue, 25 Mar 2025 19:10:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8074A68951;\n\tTue, 25 Mar 2025 20:10:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1016617F4\n\tfor ;\n\tTue, 25 Mar 2025 20:09:58 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F6FD353;\n\tTue, 25 Mar 2025 20:08:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ToWmUrtR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742929691;\n\tbh=EYmNV0qELMVYVs26a2MrwbcLUSZpIjsHruI6xA2ojKU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ToWmUrtRQL9vaSkMSMJDn9nP5xR8zT7t5nEMigKY+w3qJSKlywHVkt2rGtGFuWhxz\n\tES/UcEfo010RZtWjIQ4zH7fwvljyvcelG+Oegms3YnMHDr8w7qjj6NrylfccSEe/Da\n\thxiu9uKHCx7MXi6h50XZ41bgA7q0mnHrXVCLH6+8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250325180821.1456154-2-barnabas.pocze@ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v3 1/9] libcamera: process: Disable copy/move","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Mar 2025 19:09:55 +0000","Message-ID":"<174292979585.2136573.1955069318414730189@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33719,"web_url":"https://patchwork.libcamera.org/comment/33719/","msgid":"<20250326125204.GA8303@pendragon.ideasonboard.com>","date":"2025-03-26T12:52:04","subject":"Re: [RFC PATCH v3 1/9] libcamera: process: Disable copy/move","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Mar 25, 2025 at 07:08:13PM +0100, Barnabás Pőcze wrote:\n> A `Process` object has address identity because a pointer\n> to it is stored inside the `ProcessManager`. However, copy/move\n> special methods are still generated by the compiler. So disable\n> them to avoid potential issues and confusion.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/internal/process.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> index b1d07a5a5..58e3e41ce 100644\n> --- a/include/libcamera/internal/process.h\n> +++ b/include/libcamera/internal/process.h\n\nYou should include libcamera/base/class.h.\n\nReviewed-by: Laurent Pinchart \n\n> @@ -42,6 +42,8 @@ public:\n> \tSignal finished;\n> \n> private:\n> +\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Process)\n> +\n> \tvoid closeAllFdsExcept(const std::vector &fds);\n> \tint isolate();\n> \tvoid died(int wstatus);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41CFEC323E\n\tfor ;\n\tWed, 26 Mar 2025 12:52:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2F106896C;\n\tWed, 26 Mar 2025 13:52:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0222C68950\n\tfor ;\n\tWed, 26 Mar 2025 13:52:26 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D54B03A4;\n\tWed, 26 Mar 2025 13:50:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"si/46mhp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742993439;\n\tbh=Ph/eYpVXIZBP+a3SqXD98/2awYCqjDg1/exBXl8tzcw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=si/46mhp67devcewAexxgtvOtNQH/42kt3ywcyLkw6y9jB77xJLBdIR3tugEbceC0\n\tLJV2czgw73xAXbSSX6sVgj7w0St9NeTLqpuCM9/Dy6BGEVwRFlqEUvfnQPwyCI442n\n\tWPjYg81NBYBwov6h4kVJyKqWBAzhr9Z6wP2Xwia0=","Date":"Wed, 26 Mar 2025 14:52:04 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v3 1/9] libcamera: process: Disable copy/move","Message-ID":"<20250326125204.GA8303@pendragon.ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>\n\t<20250325180821.1456154-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250325180821.1456154-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]