[{"id":33807,"web_url":"https://patchwork.libcamera.org/comment/33807/","msgid":"<174344418126.3394313.6572398886484913346@ping.linuxembedded.co.uk>","date":"2025-03-31T18:03:01","subject":"Re: [PATCH 5/5] test: ipa: libipa: histogram: Add tests for small\n\tinter quantile mean ranges","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-24 17:07:40)\n> Add tests for small inter quantile mean ranges. These cases were\n> fixed in the last commit.\n> \n\nExcellent, tests to prove the series works :D\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Stefan Klug \n> ---\n> test/ipa/libipa/histogram.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\n> index b96626054af0..b0f9644cebc7 100644\n> --- a/test/ipa/libipa/histogram.cpp\n> +++ b/test/ipa/libipa/histogram.cpp\n> @@ -55,6 +55,10 @@ protected:\n> /* Test quantile means that are in the middle of the bins */\n> ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);\n> \n> + /* Test small ranges at the borders of the histogram */\n> + ASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1);\n> + ASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9);\n> +\n> return TestPass;\n> }\n> };\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B94C9C323E\n\tfor ;\n\tMon, 31 Mar 2025 18:03:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DB6B68989;\n\tMon, 31 Mar 2025 20:03:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EC2268967\n\tfor ;\n\tMon, 31 Mar 2025 20:03:04 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6B4E703;\n\tMon, 31 Mar 2025 20:01:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dzly0BRh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743444072;\n\tbh=qdN6rm1waMaPqLG7VBvon9cmkKS8zS/MfCZFG5WRVhI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Dzly0BRhrCsRsWIKXpRrGbXwtTPoEp0SEFcL/lsuHzEl8DHDPO8JZKtOhEAYw1bVz\n\t9iN/TmCnZMAkMVhxS5lNnBTa0X9g4V8mNkr7E5ws0do8B87ZhZJbTWMEOtzQXRKTnZ\n\t7kQkqZhQrPzo69YK47ASkHfk14OMdfjH7Bz3EYv8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250324170803.103296-6-stefan.klug@ideasonboard.com>","References":"<20250324170803.103296-1-stefan.klug@ideasonboard.com>\n\t<20250324170803.103296-6-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 5/5] test: ipa: libipa: histogram: Add tests for small\n\tinter quantile mean ranges","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 19:03:01 +0100","Message-ID":"<174344418126.3394313.6572398886484913346@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33821,"web_url":"https://patchwork.libcamera.org/comment/33821/","msgid":"<20250331220927.GM14432@pendragon.ideasonboard.com>","date":"2025-03-31T22:09:27","subject":"Re: [PATCH 5/5] test: ipa: libipa: histogram: Add tests for small\n\tinter quantile mean ranges","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Mon, Mar 24, 2025 at 06:07:40PM +0100, Stefan Klug wrote:\n> Add tests for small inter quantile mean ranges. These cases were\n> fixed in the last commit.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> test/ipa/libipa/histogram.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\n> index b96626054af0..b0f9644cebc7 100644\n> --- a/test/ipa/libipa/histogram.cpp\n> +++ b/test/ipa/libipa/histogram.cpp\n> @@ -55,6 +55,10 @@ protected:\n> \t\t/* Test quantile means that are in the middle of the bins */\n> \t\tASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);\n> \n> +\t\t/* Test small ranges at the borders of the histogram */\n\ns/histogram/histogram./\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1);\n> +\t\tASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9);\n> +\n> \t\treturn TestPass;\n> \t}\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C58EC3213\n\tfor ;\n\tMon, 31 Mar 2025 22:09:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5ED168981;\n\tTue, 1 Apr 2025 00:09:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96AC66897A\n\tfor ;\n\tTue, 1 Apr 2025 00:09:53 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-147-224-nat.elisa-mobile.fi\n\t[85.76.147.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F648E8D;\n\tTue, 1 Apr 2025 00:08:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ednSV1G7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743458882;\n\tbh=77JZ2yZ6bG2indo7uDkC3XEJytcTerSJNIAh0PJEqlA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ednSV1G789yEOwDaJKKWucTHEGxvPIbugoN1SbuFTBC2O3x8wXeNow1gbIrVhHVAx\n\tyqaHEzw+t7FN99UuRJUgEoixC+o6vU+F+DTfQkkejEOeFGf8NuF8HlQObh+sJE7hSp\n\tug1sinS5uOkgmarc6YcoyEZvpxYsQuQr+6llD7+g=","Date":"Tue, 1 Apr 2025 01:09:27 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 5/5] test: ipa: libipa: histogram: Add tests for small\n\tinter quantile mean ranges","Message-ID":"<20250331220927.GM14432@pendragon.ideasonboard.com>","References":"<20250324170803.103296-1-stefan.klug@ideasonboard.com>\n\t<20250324170803.103296-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250324170803.103296-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]