[{"id":33810,"web_url":"https://patchwork.libcamera.org/comment/33810/","msgid":"<174344456237.3394313.6422370515472755656@ping.linuxembedded.co.uk>","date":"2025-03-31T18:09:22","subject":"Re: [PATCH 3/5] test: ipa: libipa: histogram: Add tests for\n\tquantile() returning a fraction","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-24 17:07:38)\n> Add tests for quantile() returning a fractional value. These cases were\n> fixed in the last commit.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> test/ipa/libipa/histogram.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\n> index 220a329e33b3..b96626054af0 100644\n> --- a/test/ipa/libipa/histogram.cpp\n> +++ b/test/ipa/libipa/histogram.cpp\n> @@ -42,10 +42,19 @@ protected:\n> ASSERT_EQ(hist.quantile(1.0), 2.0);\n> ASSERT_EQ(hist.quantile(0.5), 1.0);\n> \n> + /* Test quantile in the middle of a bin. */\n> + ASSERT_EQ(hist.quantile(0.75), 1.5);\n> +\n> + /* Test quantile smaller than the smallest histogram step. */\n> + ASSERT_EQ(hist.quantile(0.001), 0.002);\n> +\n> ASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0);\n> ASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5);\n> ASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5);\n> \n> + /* Test quantile means that are in the middle of the bins */\n> + ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);\n> +\n\nReviewed-by: Kieran Bingham \n\n> return TestPass;\n> }\n> };\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 133E0C3213\n\tfor ;\n\tMon, 31 Mar 2025 18:09:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3936068988;\n\tMon, 31 Mar 2025 20:09:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC7C56897A\n\tfor ;\n\tMon, 31 Mar 2025 20:09:25 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10E6C725;\n\tMon, 31 Mar 2025 20:07:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZGqSEYGC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743444454;\n\tbh=V+JFRes3+Z2B97Mqazw8X0EIsCTSqoAu1AqZstEtvs4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZGqSEYGCrzLazMGQt6jQ6Rj62ni2I1TqVhX+4MO4NaNYpiLTgpge/amEOenftObPu\n\tNiJtH+rR893kw6GAkGhWPRCYYBLmuMxDmySulvYv5nVXkmESnkguesR4b8B3tStV/b\n\toOR3DDcEqZzCUg0p1s9W7qWGsE9XVDSl7jVgPNyY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250324170803.103296-4-stefan.klug@ideasonboard.com>","References":"<20250324170803.103296-1-stefan.klug@ideasonboard.com>\n\t<20250324170803.103296-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 3/5] test: ipa: libipa: histogram: Add tests for\n\tquantile() returning a fraction","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 19:09:22 +0100","Message-ID":"<174344456237.3394313.6422370515472755656@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33818,"web_url":"https://patchwork.libcamera.org/comment/33818/","msgid":"<20250331215637.GK14432@pendragon.ideasonboard.com>","date":"2025-03-31T21:56:37","subject":"Re: [PATCH 3/5] test: ipa: libipa: histogram: Add tests for\n\tquantile() returning a fraction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Mon, Mar 24, 2025 at 06:07:38PM +0100, Stefan Klug wrote:\n> Add tests for quantile() returning a fractional value. These cases were\n> fixed in the last commit.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> test/ipa/libipa/histogram.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\n> index 220a329e33b3..b96626054af0 100644\n> --- a/test/ipa/libipa/histogram.cpp\n> +++ b/test/ipa/libipa/histogram.cpp\n> @@ -42,10 +42,19 @@ protected:\n> \t\tASSERT_EQ(hist.quantile(1.0), 2.0);\n> \t\tASSERT_EQ(hist.quantile(0.5), 1.0);\n> \n> +\t\t/* Test quantile in the middle of a bin. */\n> +\t\tASSERT_EQ(hist.quantile(0.75), 1.5);\n> +\n> +\t\t/* Test quantile smaller than the smallest histogram step. */\n> +\t\tASSERT_EQ(hist.quantile(0.001), 0.002);\n> +\n> \t\tASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0);\n> \t\tASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5);\n> \t\tASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5);\n> \n> +\t\t/* Test quantile means that are in the middle of the bins */\n\ns/quantile/interquantile/\ns/bins/bins./\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);\n> +\n> \t\treturn TestPass;\n> \t}\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3BCFC3213\n\tfor ;\n\tMon, 31 Mar 2025 21:57:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17D4768985;\n\tMon, 31 Mar 2025 23:57:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 048EF68967\n\tfor ;\n\tMon, 31 Mar 2025 23:57:03 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-147-224-nat.elisa-mobile.fi\n\t[85.76.147.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 855F9703;\n\tMon, 31 Mar 2025 23:55:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dbIYRYEu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743458111;\n\tbh=peveyXHkZ0OGS59HOHLOO7X4kbS6HHnqneAQXYXJ5Pg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dbIYRYEuwm/Q0rtWmiqUc6nakJiEjqHGsIBh+uU0g60ygpDULY9QxM0zEzL1jK9Vz\n\ta0punnuwolsc6f7q0YJikHd9uOI8F2AcaDdtJukMWdlZRQJbR+FTu5miymhwHZqn48\n\twVKRQuNYZUzVIt4KM58GJTsMft6TSzfVXXmRNq7g=","Date":"Tue, 1 Apr 2025 00:56:37 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/5] test: ipa: libipa: histogram: Add tests for\n\tquantile() returning a fraction","Message-ID":"<20250331215637.GK14432@pendragon.ideasonboard.com>","References":"<20250324170803.103296-1-stefan.klug@ideasonboard.com>\n\t<20250324170803.103296-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250324170803.103296-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]