{"id":23004,"url":"https://patchwork.libcamera.org/api/patches/23004/?format=json","web_url":"https://patchwork.libcamera.org/patch/23004/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250324170803.103296-4-stefan.klug@ideasonboard.com>","date":"2025-03-24T17:07:38","name":"[3/5] test: ipa: libipa: histogram: Add tests for quantile() returning a fraction","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4b63c543c03753aa2f9a8fb9f3560b1ffd710a6f","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23004/mbox/","series":[{"id":5077,"url":"https://patchwork.libcamera.org/api/series/5077/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5077","date":"2025-03-24T17:07:35","name":"Fix histogram for some (corner) cases","version":1,"mbox":"https://patchwork.libcamera.org/series/5077/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23004/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23004/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26D91C3213\n\tfor ;\n\tMon, 24 Mar 2025 17:08:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0D5A6895E;\n\tMon, 24 Mar 2025 18:08:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D51268958\n\tfor ;\n\tMon, 24 Mar 2025 18:08:22 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:854:5bc6:b2a7:e242])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 873C4A8F;\n\tMon, 24 Mar 2025 18:06:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ADBiKAQL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742835995;\n\tbh=TSLreD3TRry1QHtl7vm4ovSrUPdYKLwxukx1k3nTb0o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ADBiKAQLvOzfV9+/3prRdmuN3hdTUcsnHLHE1GhTC7gg5Qqi3wxAQfu6vetxQrUd3\n\tj+0puwjqienQ9KkSfWScjy4E2eO1qXIFsIiHBJ4LYtDbR5DMeowXrzC+WOnvevRFPF\n\tkJzdbzlwV94CUYyPQik5i/CVHic2M+qcL5E2QfHs=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 3/5] test: ipa: libipa: histogram: Add tests for quantile()\n\treturning a fraction","Date":"Mon, 24 Mar 2025 18:07:38 +0100","Message-ID":"<20250324170803.103296-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250324170803.103296-1-stefan.klug@ideasonboard.com>","References":"<20250324170803.103296-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add tests for quantile() returning a fractional value. These cases were\nfixed in the last commit.\n\nSigned-off-by: Stefan Klug \n---\n test/ipa/libipa/histogram.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\nindex 220a329e33b3..b96626054af0 100644\n--- a/test/ipa/libipa/histogram.cpp\n+++ b/test/ipa/libipa/histogram.cpp\n@@ -42,10 +42,19 @@ protected:\n \t\tASSERT_EQ(hist.quantile(1.0), 2.0);\n \t\tASSERT_EQ(hist.quantile(0.5), 1.0);\n \n+\t\t/* Test quantile in the middle of a bin. */\n+\t\tASSERT_EQ(hist.quantile(0.75), 1.5);\n+\n+\t\t/* Test quantile smaller than the smallest histogram step. */\n+\t\tASSERT_EQ(hist.quantile(0.001), 0.002);\n+\n \t\tASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0);\n \t\tASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5);\n \t\tASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5);\n \n+\t\t/* Test quantile means that are in the middle of the bins */\n+\t\tASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);\n+\n \t\treturn TestPass;\n \t}\n };\n","prefixes":["3/5"]}