[{"id":3017,"web_url":"https://patchwork.libcamera.org/comment/3017/","msgid":"<20191114081448.GI7353@bigcity.dyn.berto.se>","date":"2019-11-14T08:14:48","subject":"Re: [libcamera-devel] [PATCH v2 04/24] libcamera: controls: Add\n\toperator== and operator!= to ControlRange","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-11-08 22:53:49 +0200, Laurent Pinchart wrote:\n> Allow comparision of control ranges by adding the required operators.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 9 +++++++++\n> src/libcamera/controls.cpp | 11 +++++++++++\n> 2 files changed, 20 insertions(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 42e6df7e613d..19075858fbba 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -112,6 +112,15 @@ public:\n> \n> \tstd::string toString() const;\n> \n> +\tbool operator==(const ControlRange &other) const\n> +\t{\n> +\t\treturn min_ == other.min_ && max_ == other.max_;\n> +\t}\n> +\tbool operator!=(const ControlRange &other) const\n> +\t{\n> +\t\treturn !(*this == other);\n> +\t}\n> +\n> private:\n> \tControlValue min_;\n> \tControlValue max_;\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 0c7cd449ad64..2c5c98633585 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -383,6 +383,17 @@ std::string ControlRange::toString() const\n> \treturn ss.str();\n> }\n> \n> +/**\n> + * \\fn bool ControlRange::operator==()\n> + * \\brief Compare ControlRange instances for equality\n> + * \\return True if the ranges have identical min and max, false otherwise\n> + */\n> +/**\n> + * \\fn bool ControlRange::operator!=()\n> + * \\brief Compare ControlRange instances for non equality\n> + * \\return False if the ranges have identical min and max, true otherwise\n> + */\n> +\n> /**\n> * \\typedef ControlIdMap\n> * \\brief A map of numerical control ID to ControlId\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DB636136F\n\tfor ;\n\tThu, 14 Nov 2019 09:14:49 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id q5so4266296lfo.10\n\tfor ;\n\tThu, 14 Nov 2019 00:14:49 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tp14sm1846873ljc.8.2019.11.14.00.14.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 14 Nov 2019 00:14:48 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=QTn8ju3Up2K88+suz4eIw6PPYdGte0jyYavbsxYtprw=;\n\tb=uNKFqnfZYaRk3HCFEhyo/Z9HtTUJQU+dCqrm8SG3zYiD9L8T9qs5AcSbJuS+FzhZgj\n\txNcIqMhfJdq+tqlBPK+ZiNwlmoUH5DrE5ttEOFMAHXRvLXqvunVDqhJzvZ6cwfbQ7xJn\n\tEVP0x3SADVRyLMzOjXqgbI63R4P61rpEKV+cJUu2K3z6jkoDAoCbeEbjeFwhhrfyb5yu\n\t9D0bSZOnOFECT76z9Gp7B13LXn/BMChfB6aZ4VnofIVnwShUoTMWZgJ7vVNt6GsNkV19\n\tcE6iXOFyDzJN2iHDH6wCjJge/fJ4kTb4VQNv2r1pEmkCLYAG5R+isq/l5Wrqrpx3VjhP\n\tcZwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=QTn8ju3Up2K88+suz4eIw6PPYdGte0jyYavbsxYtprw=;\n\tb=BBRNL8Nl7dQbK40j4LaF91OsJzfzPimElh1rJAwKrUWSH6h5a9m45n5XIO6kyG8Kmq\n\tLy/XIk1jPtim+F9alKKyGwZVR+0/QRsYXmtdCPB/MtHZXK60USNEJm+2SWM6C7lEawTQ\n\tWIYB+QcojO13gWXIp+B1OUH7zEdE0/jJRpG2E2ERdA/zNTc300w5cHvad6JCOy0qvwuw\n\tZBwIodxcslKGhEAsRZ209e460wCFbGkds+CjQQrfnPn9gvQdaqcb3+ymJgaYrHdZ9KOC\n\tdto14pVds5/7oKtUBf5S2AlbzRiad7F2HsJKRVq2Bffx6I8uEQyyl7EaAn3XYLU/rktw\n\tFI0Q==","X-Gm-Message-State":"APjAAAWZcPkOp/Qo4zsJwGbTjNnYHMl5f39Z04IYP63BtWpzj0euQsu+\n\tmoibVdE4SFAPmNYiaBihM2yl0w==","X-Google-Smtp-Source":"APXvYqySMHcREyAMPDSzMuANHXGDAII0zUt+Xnm5IKogDY9WfevM6LJ4GWRkn3Isg3TRCx5IryEH+g==","X-Received":"by 2002:ac2:5442:: with SMTP id d2mr5748622lfn.161.1573719288934;\n\tThu, 14 Nov 2019 00:14:48 -0800 (PST)","Date":"Thu, 14 Nov 2019 09:14:48 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191114081448.GI7353@bigcity.dyn.berto.se>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191108205409.18845-5-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 04/24] libcamera: controls: Add\n\toperator== and operator!= to ControlRange","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 14 Nov 2019 08:14:49 -0000"}},{"id":3024,"web_url":"https://patchwork.libcamera.org/comment/3024/","msgid":"<20191115160217.mqymsl5iu4knqzoz@uno.localdomain>","date":"2019-11-15T16:02:17","subject":"Re: [libcamera-devel] [PATCH v2 04/24] libcamera: controls: Add\n\toperator== and operator!= to ControlRange","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Nov 08, 2019 at 10:53:49PM +0200, Laurent Pinchart wrote:\n> Allow comparision of control ranges by adding the required operators.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/controls.h | 9 +++++++++\n> src/libcamera/controls.cpp | 11 +++++++++++\n> 2 files changed, 20 insertions(+)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 42e6df7e613d..19075858fbba 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -112,6 +112,15 @@ public:\n>\n> \tstd::string toString() const;\n>\n> +\tbool operator==(const ControlRange &other) const\n> +\t{\n> +\t\treturn min_ == other.min_ && max_ == other.max_;\n> +\t}\n\n(optional) empty line ?\n\n> +\tbool operator!=(const ControlRange &other) const\n> +\t{\n> +\t\treturn !(*this == other);\n> +\t}\n> +\n> private:\n> \tControlValue min_;\n> \tControlValue max_;\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 0c7cd449ad64..2c5c98633585 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -383,6 +383,17 @@ std::string ControlRange::toString() const\n> \treturn ss.str();\n> }\n>\n> +/**\n> + * \\fn bool ControlRange::operator==()\n> + * \\brief Compare ControlRange instances for equality\n> + * \\return True if the ranges have identical min and max, false otherwise\n> + */\n\nempty line?\n\n> +/**\n> + * \\fn bool ControlRange::operator!=()\n> + * \\brief Compare ControlRange instances for non equality\n> + * \\return False if the ranges have identical min and max, true otherwise\n> + */\n> +\n\nminor nits apart\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> /**\n> * \\typedef ControlIdMap\n> * \\brief A map of numerical control ID to ControlId\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01F196136F\n\tfor ;\n\tFri, 15 Nov 2019 17:00:16 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 8EF79240018;\n\tFri, 15 Nov 2019 16:00:15 +0000 (UTC)"],"Date":"Fri, 15 Nov 2019 17:02:17 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191115160217.mqymsl5iu4knqzoz@uno.localdomain>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"246v5u46wq6y4b2d\"","Content-Disposition":"inline","In-Reply-To":"<20191108205409.18845-5-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 04/24] libcamera: controls: Add\n\toperator== and operator!= to ControlRange","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 Nov 2019 16:00:16 -0000"}},{"id":3040,"web_url":"https://patchwork.libcamera.org/comment/3040/","msgid":"<20191118004756.GL4853@pendragon.ideasonboard.com>","date":"2019-11-18T00:47:56","subject":"Re: [libcamera-devel] [PATCH v2 04/24] libcamera: controls: Add\n\toperator== and operator!= to ControlRange","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Nov 15, 2019 at 05:02:17PM +0100, Jacopo Mondi wrote:\n> On Fri, Nov 08, 2019 at 10:53:49PM +0200, Laurent Pinchart wrote:\n> > Allow comparision of control ranges by adding the required operators.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/controls.h | 9 +++++++++\n> > src/libcamera/controls.cpp | 11 +++++++++++\n> > 2 files changed, 20 insertions(+)\n> >\n> > diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> > index 42e6df7e613d..19075858fbba 100644\n> > --- a/include/libcamera/controls.h\n> > +++ b/include/libcamera/controls.h\n> > @@ -112,6 +112,15 @@ public:\n> >\n> > \tstd::string toString() const;\n> >\n> > +\tbool operator==(const ControlRange &other) const\n> > +\t{\n> > +\t\treturn min_ == other.min_ && max_ == other.max_;\n> > +\t}\n> \n> (optional) empty line ?\n> \n> > +\tbool operator!=(const ControlRange &other) const\n> > +\t{\n> > +\t\treturn !(*this == other);\n> > +\t}\n> > +\n> > private:\n> > \tControlValue min_;\n> > \tControlValue max_;\n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index 0c7cd449ad64..2c5c98633585 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -383,6 +383,17 @@ std::string ControlRange::toString() const\n> > \treturn ss.str();\n> > }\n> >\n> > +/**\n> > + * \\fn bool ControlRange::operator==()\n> > + * \\brief Compare ControlRange instances for equality\n> > + * \\return True if the ranges have identical min and max, false otherwise\n> > + */\n> \n> empty line?\n\nEmpty lines added, thanks for catching this.\n\n> > +/**\n> > + * \\fn bool ControlRange::operator!=()\n> > + * \\brief Compare ControlRange instances for non equality\n> > + * \\return False if the ranges have identical min and max, true otherwise\n> > + */\n> > +\n> \n> minor nits apart\n> Reviewed-by: Jacopo Mondi \n> \n> > /**\n> > * \\typedef ControlIdMap\n> > * \\brief A map of numerical control ID to ControlId","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A62BD60C33\n\tfor ;\n\tMon, 18 Nov 2019 01:48:01 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CBFB540;\n\tMon, 18 Nov 2019 01:48:00 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574038081;\n\tbh=0PX2r2c7ag+Ghc7ocukv9q45ONvnPndUly/qV5xtxz8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GOfToM20dvMzl5qxQ7MT+u0H1D5OSM1gwXcmLraY1yAq3wS5aZQfFWVTNUWVXmk8c\n\tUF6Bev8YJHP6yiKt/7ndrWGGHDLOA8y44+tMVqnT2OzXpqsr5JzYf6l8pa6+cqRrMN\n\tFOSztzfMKJPolNpn1mD5K9toqIo1ASEEp7ul+BX8=","Date":"Mon, 18 Nov 2019 02:47:56 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118004756.GL4853@pendragon.ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>\n\t<20191108205409.18845-5-laurent.pinchart@ideasonboard.com>\n\t<20191115160217.mqymsl5iu4knqzoz@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191115160217.mqymsl5iu4knqzoz@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 04/24] libcamera: controls: Add\n\toperator== and operator!= to ControlRange","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 00:48:01 -0000"}}]