{"id":22997,"url":"https://patchwork.libcamera.org/api/patches/22997/?format=json","web_url":"https://patchwork.libcamera.org/patch/22997/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250320160521.301-1-laurent.pinchart@ideasonboard.com>","date":"2025-03-20T16:05:21","name":"pipeline: rpi: pisp: Fix uninitialized variable warning","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0037720cfe99839b5f002ad648333184b05bb143","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22997/mbox/","series":[{"id":5073,"url":"https://patchwork.libcamera.org/api/series/5073/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5073","date":"2025-03-20T16:05:21","name":"pipeline: rpi: pisp: Fix uninitialized variable warning","version":1,"mbox":"https://patchwork.libcamera.org/series/5073/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22997/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22997/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F5A6C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Mar 2025 16:05:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7E8768950;\n\tThu, 20 Mar 2025 17:05:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E796B617F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Mar 2025 17:05:44 +0100 (CET)","from pendragon.ideasonboard.com (unknown [157.231.223.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2792F220;\n\tThu, 20 Mar 2025 17:04:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LCMt72+M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742486641;\n\tbh=zTw5FLHhsbptv1+ocB+QFd8QA48xHEoVLzZKeVz2ehs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=LCMt72+M0sUfGq9mpzU5pUxWKvjVD43XpbSzhnjn+ZyiEHTCdFXY6QmEOXjkNmCrT\n\tFQsW+QHMnZ2n9DN4/SeBK0CfiOOCLP/EPHIvAwOUtx7jWIDQo3bnK3vBdbzE2cqrI3\n\tOpqXQDSHJr0z+EmAXVA3Qf4xX3xeA7KUO+LJAcBM=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck <naush@raspberrypi.com>","Subject":"[PATCH] pipeline: rpi: pisp: Fix uninitialized variable warning","Date":"Thu, 20 Mar 2025 18:05:21 +0200","Message-ID":"<20250320160521.301-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"gcc 13.3.0 from buildroot 2024.11.1 complains about an uninitialized\nvariable. This is a false positive as the cfe_ array can't be empty.\nNonetheless, it breaks builds, so initialize the variable to work around\nthe issue.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 841ef2b4bb08ba48470817ff1f838efcce377fee\n--\nRegards,\n\nLaurent Pinchart","diff":"diff --git a/src/libcamera/pipeline/rpi/pisp/pisp.cpp b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\nindex 0f9e332667c0..42ca7c80b10a 100644\n--- a/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n+++ b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n@@ -1700,7 +1700,7 @@ void PiSPCameraData::platformFreeBuffers()\n void PiSPCameraData::cfeBufferDequeue(FrameBuffer *buffer)\n {\n \tRPi::Stream *stream = nullptr;\n-\tint index;\n+\tint index = 0;\n\n \tif (!isRunning())\n \t\treturn;\n","prefixes":[]}