{"id":22993,"url":"https://patchwork.libcamera.org/api/patches/22993/?format=json","web_url":"https://patchwork.libcamera.org/patch/22993/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250319161152.63625-16-stefan.klug@ideasonboard.com>","date":"2025-03-19T16:11:20","name":"[v2,15/17] ipa: rkisp1: awb: Set rgb mean limits to 180","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"49ad638d2f50d4d15f9dba5830d3b9024d964aa3","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22993/mbox/","series":[{"id":5071,"url":"https://patchwork.libcamera.org/api/series/5071/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5071","date":"2025-03-19T16:11:05","name":"Some rkisp1 awb improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5071/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22993/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22993/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93E39C32FE\n\tfor ;\n\tWed, 19 Mar 2025 16:12:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49A0368970;\n\tWed, 19 Mar 2025 17:12:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 673836895B\n\tfor ;\n\tWed, 19 Mar 2025 17:12:41 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:760:e5ca:4814:99c7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BB2655A;\n\tWed, 19 Mar 2025 17:10:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oEoiL6Rs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742400658;\n\tbh=NxJ8FBTXkqXAEwUUlhcK1v+TxRRXWgFK/YjME/mdJFA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oEoiL6RseziHCvvxVDqPORS6BncQSePkienjIQa1hKVsbUz2+SJdGuP6GUNrJZBEs\n\tUeArT7PlSAnMMI4e5crlDsmvnttcIuWgmBMu1u9Dvw9xrNlOEN1iHx/lDo4MtvToTG\n\tBUITHFBGSIEsSp8Zfi56laoa9GmnquZRxanyIfTc=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 15/17] ipa: rkisp1: awb: Set rgb mean limits to 180","Date":"Wed, 19 Mar 2025 17:11:20 +0100","Message-ID":"<20250319161152.63625-16-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>","References":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set the mean limits to 180 to get reasonably good results from the rgb\nestimations. This is only for internal development as there is no code\npath to enable rgb estimations at runtime.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- None\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 149c6aa59c8d..324bc14b42a0 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -261,9 +261,9 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n \t\t * awb_ref_cr, awb_min_y and awb_ref_cb respectively. The other\n \t\t * values are not used, set them to 0.\n \t\t */\n-\t\tawbConfig->awb_ref_cr = 250;\n-\t\tawbConfig->min_y = 250;\n-\t\tawbConfig->awb_ref_cb = 250;\n+\t\tawbConfig->awb_ref_cr = 180;\n+\t\tawbConfig->min_y = 180;\n+\t\tawbConfig->awb_ref_cb = 180;\n \n \t\tawbConfig->max_y = 0;\n \t\tawbConfig->min_c = 0;\n","prefixes":["v2","15/17"]}