{"id":22982,"url":"https://patchwork.libcamera.org/api/patches/22982/?format=json","web_url":"https://patchwork.libcamera.org/patch/22982/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250319161152.63625-5-stefan.klug@ideasonboard.com>","date":"2025-03-19T16:11:09","name":"[v2,04/17] libcamera: vector: Add a Span based constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"41929d3f09d7e0a0ebad5b24ba82c0a15fed938e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22982/mbox/","series":[{"id":5071,"url":"https://patchwork.libcamera.org/api/series/5071/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5071","date":"2025-03-19T16:11:05","name":"Some rkisp1 awb improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5071/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22982/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22982/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A39CC32FE\n\tfor ;\n\tWed, 19 Mar 2025 16:12:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7A7D6895B;\n\tWed, 19 Mar 2025 17:12:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 987AF68950\n\tfor ;\n\tWed, 19 Mar 2025 17:12:08 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:760:e5ca:4814:99c7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1FF38FA;\n\tWed, 19 Mar 2025 17:10:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HQGEtgHn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742400625;\n\tbh=Wav+/7DNoCoKWjCuh5eKfA2krY3LS9nUcXcQ3tbPgbg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HQGEtgHncSgzwHAFvlib+/sZeOkooh1S3/wYl/Xg/iBdQepUC8RvLkaGRCYmEFfT5\n\tS8hVSYRatAuUhXNHPiM8CEGP0pKgI/JGn1kKb6iQc0M5/cQ/MHKRqummJnZiF10+fl\n\tugVU1TuMERPooxHNF31QvVkYwBcpKMzlSZyr+Xes=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 04/17] libcamera: vector: Add a Span based constructor","Date":"Wed, 19 Mar 2025 17:11:09 +0100","Message-ID":"<20250319161152.63625-5-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>","References":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that Matrix has a Span based constructor, add the same for Vector.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- Added this patch\n---\n include/libcamera/internal/vector.h | 12 ++++++++----\n src/libcamera/vector.cpp | 8 ++++++++\n 2 files changed, 16 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h\nindex a67a09474204..66cc5ac988c2 100644\n--- a/include/libcamera/internal/vector.h\n+++ b/include/libcamera/internal/vector.h\n@@ -40,10 +40,14 @@ public:\n \t\tdata_.fill(scalar);\n \t}\n \n-\tconstexpr Vector(const std::array &data)\n+\tVector(const std::array &data)\n \t{\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tdata_[i] = data[i];\n+\t\tstd::copy(data.begin(), data.end(), data_.begin());\n+\t}\n+\n+\tVector(const Span &data)\n+\t{\n+\t\tstd::copy(data.begin(), data.end(), data_.begin());\n \t}\n \n \tconst T &operator[](size_t i) const\n@@ -285,7 +289,7 @@ private:\n \t\treturn *this;\n \t}\n \n-\tstd::array data_;\n+\tstd::array data_{};\n };\n \n template\ndiff --git a/src/libcamera/vector.cpp b/src/libcamera/vector.cpp\nindex 85ca2208245a..435f2fc62f8b 100644\n--- a/src/libcamera/vector.cpp\n+++ b/src/libcamera/vector.cpp\n@@ -44,6 +44,14 @@ LOG_DEFINE_CATEGORY(Vector)\n * The size of \\a data must be equal to the dimension size Rows of the vector.\n */\n \n+/**\n+ * \\fn Vector::Vector(const Span &data)\n+ * \\brief Construct vector from supplied data\n+ * \\param data Data from which to construct a vector\n+ *\n+ * The size of \\a data must be equal to the dimension size Rows of the vector.\n+ */\n+\n /**\n * \\fn T Vector::operator[](size_t i) const\n * \\brief Index to an element in the vector\n","prefixes":["v2","04/17"]}