[{"id":33791,"web_url":"https://patchwork.libcamera.org/comment/33791/","msgid":"<174344052938.3394313.13929305295886170269@ping.linuxembedded.co.uk>","date":"2025-03-31T17:02:09","subject":"Re: [PATCH v2 03/17] libcamera: matrix: Add a Span based constructor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-19 16:11:08)\n> When one wants to create a Matrix from existing data, currently the only\n> way is via std::array. Add a Span based constructor to allow creation\n> from vectors and alike.\n> \n> Signed-off-by: Stefan Klug \n> \nSeems fine to me.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> include/libcamera/internal/matrix.h | 5 +++++\n> src/libcamera/matrix.cpp | 10 ++++++++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\n> index 2e7929e9060c..9b80521e3cb0 100644\n> --- a/include/libcamera/internal/matrix.h\n> +++ b/include/libcamera/internal/matrix.h\n> @@ -34,6 +34,11 @@ public:\n> std::copy(data.begin(), data.end(), data_.begin());\n> }\n> \n> + Matrix(const Span &data)\n> + {\n> + std::copy(data.begin(), data.end(), data_.begin());\n> + }\n> +\n> static constexpr Matrix identity()\n> {\n> Matrix ret;\n> diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\n> index e7e027225666..6dca7498cab3 100644\n> --- a/src/libcamera/matrix.cpp\n> +++ b/src/libcamera/matrix.cpp\n> @@ -41,6 +41,16 @@ LOG_DEFINE_CATEGORY(Matrix)\n> * number of rows and columns of the matrix (Rows x Cols).\n> */\n> \n> +/**\n> + * \\fn Matrix::Matrix(const Span &data)\n> + * \\brief Construct a matrix from supplied data\n> + * \\param[in] data Data from which to construct a matrix\n> + *\n> + * \\a data is a one-dimensional Span and will be turned into a matrix in\n> + * row-major order. The size of \\a data must be equal to the product of the\n> + * number of rows and columns of the matrix (Rows x Cols).\n> + */\n> +\n> /**\n> * \\fn Matrix::identity()\n> * \\brief Construct an identity matrix\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE0B8C323E\n\tfor ;\n\tMon, 31 Mar 2025 17:02:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9A9568985;\n\tMon, 31 Mar 2025 19:02:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3041E6897A\n\tfor ;\n\tMon, 31 Mar 2025 19:02:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 819A0725;\n\tMon, 31 Mar 2025 19:00:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iJamyRiF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743440420;\n\tbh=M+eUtiVM5O/du08ut3J1wiCZzeAx80WcXciECYNDNBU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=iJamyRiFpOIuYS6GBqJiqnLUjf4wm1a/oa/ontozfN0fnD2xK0UrQRsQLvEqzvR/0\n\t7L1dskkGl5ltWSJpe72wD6+of74OLx3Vpda0rK3DQQVg4Oi0lduJAUi0hLmXlNbijh\n\t/90w3tzDT6KroPi0OxPN2N1djggL1oc3kLyWDfzI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250319161152.63625-4-stefan.klug@ideasonboard.com>","References":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>\n\t<20250319161152.63625-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 03/17] libcamera: matrix: Add a Span based constructor","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Mar 2025 18:02:09 +0100","Message-ID":"<174344052938.3394313.13929305295886170269@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33825,"web_url":"https://patchwork.libcamera.org/comment/33825/","msgid":"<20250401010128.GQ14432@pendragon.ideasonboard.com>","date":"2025-04-01T01:01:28","subject":"Re: [PATCH v2 03/17] libcamera: matrix: Add a Span based constructor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Wed, Mar 19, 2025 at 05:11:08PM +0100, Stefan Klug wrote:\n> When one wants to create a Matrix from existing data, currently the only\n> way is via std::array. Add a Span based constructor to allow creation\n> from vectors and alike.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> include/libcamera/internal/matrix.h | 5 +++++\n> src/libcamera/matrix.cpp | 10 ++++++++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\n> index 2e7929e9060c..9b80521e3cb0 100644\n> --- a/include/libcamera/internal/matrix.h\n> +++ b/include/libcamera/internal/matrix.h\n> @@ -34,6 +34,11 @@ public:\n> \t\tstd::copy(data.begin(), data.end(), data_.begin());\n> \t}\n> \n> +\tMatrix(const Span &data)\n\nYou can pass the span by value.\n\nReviewed-by: Laurent Pinchart \n\n> +\t{\n> +\t\tstd::copy(data.begin(), data.end(), data_.begin());\n> +\t}\n> +\n> \tstatic constexpr Matrix identity()\n> \t{\n> \t\tMatrix ret;\n> diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\n> index e7e027225666..6dca7498cab3 100644\n> --- a/src/libcamera/matrix.cpp\n> +++ b/src/libcamera/matrix.cpp\n> @@ -41,6 +41,16 @@ LOG_DEFINE_CATEGORY(Matrix)\n> * number of rows and columns of the matrix (Rows x Cols).\n> */\n> \n> +/**\n> + * \\fn Matrix::Matrix(const Span &data)\n> + * \\brief Construct a matrix from supplied data\n> + * \\param[in] data Data from which to construct a matrix\n> + *\n> + * \\a data is a one-dimensional Span and will be turned into a matrix in\n> + * row-major order. The size of \\a data must be equal to the product of the\n> + * number of rows and columns of the matrix (Rows x Cols).\n> + */\n> +\n> /**\n> * \\fn Matrix::identity()\n> * \\brief Construct an identity matrix","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5461C323E\n\tfor ;\n\tTue, 1 Apr 2025 01:01:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 988A96897E;\n\tTue, 1 Apr 2025 03:01:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7674D62C66\n\tfor ;\n\tTue, 1 Apr 2025 03:01:53 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-147-224-nat.elisa-mobile.fi\n\t[85.76.147.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 684F711E5;\n\tTue, 1 Apr 2025 03:00:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LDvZKSNL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743469201;\n\tbh=6ZCiScMjH0hddQudlGssnc0VcNwq+wW8zJvGd5GUKoM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LDvZKSNLdhOGKz/FOggSRWv5XxAVJdcoXHzG3b8IuLrUTQBI216ek7hE7O3EGObCN\n\tpAJvW1N91uzg3mST5ATa+5zD/27fg0km/sXGa9TTI7Mm9LaC0LvORrdhE7FnIl/iYf\n\tRyMMPQXqWNQiwIabn63i2Zy/oW98gV0E353ymvNk=","Date":"Tue, 1 Apr 2025 04:01:28 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 03/17] libcamera: matrix: Add a Span based constructor","Message-ID":"<20250401010128.GQ14432@pendragon.ideasonboard.com>","References":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>\n\t<20250319161152.63625-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250319161152.63625-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]