[{"id":33686,"web_url":"https://patchwork.libcamera.org/comment/33686/","msgid":"<3898e25d-e007-40aa-90fb-22af252484e8@ideasonboard.com>","date":"2025-03-24T07:37:50","subject":"Re: [PATCH 1/2] ipa: rkisp1: agc: Fix metering modes","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 19/03/2025 16:01, Stefan Klug wrote:\n> The weights for a given metering mode are applied to the histogram data\n> inside the histogram statistics block. The AE statistics do not contain\n> any weights. Therefore the weights are honored when AgcMeanLuminance\n> calculates the upper or lower constraints, but ignored in the\n> calculation of the frame luminance. Fix that by manually applying the\n> weights in the luminance calculation.\n>\n> Fixes: 4c5152843a2a (\"ipa: rkisp1: Derive rkisp1::algorithms::Agc from AgcMeanLuminance\")\n> Signed-off-by: Stefan Klug \n> ---\n\nLooks good to me:\n\n\nReviewed-by: Daniel Scally \n\n> src/ipa/rkisp1/algorithms/agc.cpp | 13 ++++++++++---\n> src/ipa/rkisp1/algorithms/agc.h | 1 +\n> 2 files changed, 11 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 5a3ba0131cf1..101cad5d0893 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -439,15 +439,20 @@ void Agc::fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> */\n> double Agc::estimateLuminance(double gain) const\n> {\n> +\tASSERT(expMeans_.size() == weights_.size());\n> \tdouble ySum = 0.0;\n> +\tdouble wSum = 0.0;\n> \n> \t/* Sum the averages, saturated to 255. */\n> -\tfor (uint8_t expMean : expMeans_)\n> -\t\tySum += std::min(expMean * gain, 255.0);\n> +\tfor (unsigned i = 0; i < expMeans_.size(); i++) {\n> +\t\tdouble w = weights_[i];\n> +\t\tySum += std::min(expMeans_[i] * gain, 255.0) * w;\n> +\t\twSum += w;\n> +\t}\n> \n> \t/* \\todo Weight with the AWB gains */\n> \n> -\treturn ySum / expMeans_.size() / 255;\n> +\treturn ySum / wSum / 255;\n> }\n> \n> /**\n> @@ -515,6 +520,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> \tHistogram hist({ params->hist.hist_bins, context.hw->numHistogramBins },\n> \t\t [](uint32_t x) { return x >> 4; });\n> \texpMeans_ = { params->ae.exp_mean, context.hw->numAeCells };\n> +\tstd::vector &modeWeights = meteringModes_.at(frameContext.agc.meteringMode);\n> +\tweights_ = { modeWeights.data(), modeWeights.size() };\n> \n> \t/*\n> \t * Set the AGC limits using the fixed exposure time and/or gain in\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index 62bcde999fe3..7867eed9c4e3 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -55,6 +55,7 @@ private:\n> \t\t\t\t utils::Duration frameDuration);\n> \n> \tSpan expMeans_;\n> +\tSpan weights_;\n> \n> \tstd::map> meteringModes_;\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5F3BBD16B\n\tfor ;\n\tMon, 24 Mar 2025 07:37:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D86AB68951;\n\tMon, 24 Mar 2025 08:37:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 258DD61868\n\tfor ;\n\tMon, 24 Mar 2025 08:37:53 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5489455\n\tfor ;\n\tMon, 24 Mar 2025 08:36:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b2OAdX09\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742801766;\n\tbh=/twOZet91/6lfWvILhYeW5R6Eo0Hy/Y/vXf4MGPTCEM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=b2OAdX09qx1XgIGoQbZ1K31QRlB4YpZDmNuJoBIRUc3vaN72nIn5mLGpipfo8pY/J\n\tuepxWkDHb9js6FHsVg+bXrjPkPuCBmlwZKkdrnB+yNrNTfJkASCmR5bdpVPi3YUgsy\n\t/PaJxWJC3Aj0iWAnD8rT4rnm5ZQUroN4IE5pqTiE=","Message-ID":"<3898e25d-e007-40aa-90fb-22af252484e8@ideasonboard.com>","Date":"Mon, 24 Mar 2025 07:37:50 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] ipa: rkisp1: agc: Fix metering modes","To":"libcamera-devel@lists.libcamera.org","References":"<20250319160146.61751-1-stefan.klug@ideasonboard.com>\n\t<20250319160146.61751-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250319160146.61751-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33697,"web_url":"https://patchwork.libcamera.org/comment/33697/","msgid":"<174289792672.670680.9402975314057572515@ping.linuxembedded.co.uk>","date":"2025-03-25T10:18:46","subject":"Re: [PATCH 1/2] ipa: rkisp1: agc: Fix metering modes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-19 16:01:36)\n> The weights for a given metering mode are applied to the histogram data\n> inside the histogram statistics block. The AE statistics do not contain\n> any weights. Therefore the weights are honored when AgcMeanLuminance\n> calculates the upper or lower constraints, but ignored in the\n> calculation of the frame luminance. Fix that by manually applying the\n> weights in the luminance calculation.\n> \n> Fixes: 4c5152843a2a (\"ipa: rkisp1: Derive rkisp1::algorithms::Agc from AgcMeanLuminance\")\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 13 ++++++++++---\n> src/ipa/rkisp1/algorithms/agc.h | 1 +\n> 2 files changed, 11 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 5a3ba0131cf1..101cad5d0893 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -439,15 +439,20 @@ void Agc::fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> */\n> double Agc::estimateLuminance(double gain) const\n> {\n> + ASSERT(expMeans_.size() == weights_.size());\n> double ySum = 0.0;\n> + double wSum = 0.0;\n> \n> /* Sum the averages, saturated to 255. */\n> - for (uint8_t expMean : expMeans_)\n> - ySum += std::min(expMean * gain, 255.0);\n> + for (unsigned i = 0; i < expMeans_.size(); i++) {\n> + double w = weights_[i];\n> + ySum += std::min(expMeans_[i] * gain, 255.0) * w;\n> + wSum += w;\n> + }\n> \n> /* \\todo Weight with the AWB gains */\n> \n> - return ySum / expMeans_.size() / 255;\n> + return ySum / wSum / 255;\n> }\n> \n> /**\n> @@ -515,6 +520,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> Histogram hist({ params->hist.hist_bins, context.hw->numHistogramBins },\n> [](uint32_t x) { return x >> 4; });\n> expMeans_ = { params->ae.exp_mean, context.hw->numAeCells };\n> + std::vector &modeWeights = meteringModes_.at(frameContext.agc.meteringMode);\n\nWhere do the weights come from? Are they always guaranteed to be\navailable at this point ?\n\n> + weights_ = { modeWeights.data(), modeWeights.size() };\n> \n> /*\n> * Set the AGC limits using the fixed exposure time and/or gain in\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index 62bcde999fe3..7867eed9c4e3 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -55,6 +55,7 @@ private:\n> utils::Duration frameDuration);\n> \n> Span expMeans_;\n> + Span weights_;\n> \n> std::map> meteringModes_;\n> };\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75F69C0DA4\n\tfor ;\n\tTue, 25 Mar 2025 10:18:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97A1568951;\n\tTue, 25 Mar 2025 11:18:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD99E614E9\n\tfor ;\n\tTue, 25 Mar 2025 11:18:50 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15752E45;\n\tTue, 25 Mar 2025 11:17:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bNUhoTWY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742897823;\n\tbh=IQA4ehC7pWOm181LVsqoUe9ndmy7AlE0eKvNU8bz4vQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=bNUhoTWYgxofymAofLSqazm9p+tHQokWXnreLjT+s7VoAis9rSHmNwAtYw3t/3AA5\n\trKlGxhADWE/0MtygxvAOsG5TXdzpvB+Z9g4YnzkqKAHxkrTgz5vQDTmVKVK/NfYA5G\n\tYeHfMwnmx+Uy/A2AnjNe7jCXHLvJl/NoJyohqY1k=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250319160146.61751-2-stefan.klug@ideasonboard.com>","References":"<20250319160146.61751-1-stefan.klug@ideasonboard.com>\n\t<20250319160146.61751-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 1/2] ipa: rkisp1: agc: Fix metering modes","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Mar 2025 10:18:46 +0000","Message-ID":"<174289792672.670680.9402975314057572515@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33698,"web_url":"https://patchwork.libcamera.org/comment/33698/","msgid":"<174291077630.3394313.17705727626581864673@ping.linuxembedded.co.uk>","date":"2025-03-25T13:52:56","subject":"Re: [PATCH 1/2] ipa: rkisp1: agc: Fix metering modes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-03-25 13:46:12)\n> Hi Kieran,\n> \n> Thank you for the review.\n> \n> On Tue, Mar 25, 2025 at 10:18:46AM +0000, Kieran Bingham wrote:\n> > Quoting Stefan Klug (2025-03-19 16:01:36)\n> > > The weights for a given metering mode are applied to the histogram data\n> > > inside the histogram statistics block. The AE statistics do not contain\n> > > any weights. Therefore the weights are honored when AgcMeanLuminance\n> > > calculates the upper or lower constraints, but ignored in the\n> > > calculation of the frame luminance. Fix that by manually applying the\n> > > weights in the luminance calculation.\n> > > \n> > > Fixes: 4c5152843a2a (\"ipa: rkisp1: Derive rkisp1::algorithms::Agc from AgcMeanLuminance\")\n> > > Signed-off-by: Stefan Klug \n> > > ---\n> > > src/ipa/rkisp1/algorithms/agc.cpp | 13 ++++++++++---\n> > > src/ipa/rkisp1/algorithms/agc.h | 1 +\n> > > 2 files changed, 11 insertions(+), 3 deletions(-)\n> > > \n> > > diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> > > index 5a3ba0131cf1..101cad5d0893 100644\n> > > --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> > > +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> > > @@ -439,15 +439,20 @@ void Agc::fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> > > */\n> > > double Agc::estimateLuminance(double gain) const\n> > > {\n> > > + ASSERT(expMeans_.size() == weights_.size());\n> > > double ySum = 0.0;\n> > > + double wSum = 0.0;\n> > > \n> > > /* Sum the averages, saturated to 255. */\n> > > - for (uint8_t expMean : expMeans_)\n> > > - ySum += std::min(expMean * gain, 255.0);\n> > > + for (unsigned i = 0; i < expMeans_.size(); i++) {\n> > > + double w = weights_[i];\n> > > + ySum += std::min(expMeans_[i] * gain, 255.0) * w;\n> > > + wSum += w;\n> > > + }\n> > > \n> > > /* \\todo Weight with the AWB gains */\n> > > \n> > > - return ySum / expMeans_.size() / 255;\n> > > + return ySum / wSum / 255;\n> > > }\n> > > \n> > > /**\n> > > @@ -515,6 +520,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> > > Histogram hist({ params->hist.hist_bins, context.hw->numHistogramBins },\n> > > [](uint32_t x) { return x >> 4; });\n> > > expMeans_ = { params->ae.exp_mean, context.hw->numAeCells };\n> > > + std::vector &modeWeights = meteringModes_.at(frameContext.agc.meteringMode);\n> > \n> > Where do the weights come from? Are they always guaranteed to be\n> > available at this point ?\n> \n> The weights come from the tuning file. The libtuning agc module contains\n> hardcoded values for centre weighted, spot and matrix. If there are no\n> metering modes in the tuning file, a matrix mode is generated within\n> parseMeteringModes(). So yes, they are always available at this point.\n\nThen I'm happy:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Best regards,\n> Stefan\n> \n> > \n> > > + weights_ = { modeWeights.data(), modeWeights.size() };\n> > > \n> > > /*\n> > > * Set the AGC limits using the fixed exposure time and/or gain in\n> > > diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> > > index 62bcde999fe3..7867eed9c4e3 100644\n> > > --- a/src/ipa/rkisp1/algorithms/agc.h\n> > > +++ b/src/ipa/rkisp1/algorithms/agc.h\n> > > @@ -55,6 +55,7 @@ private:\n> > > utils::Duration frameDuration);\n> > > \n> > > Span expMeans_;\n> > > + Span weights_;\n> > > \n> > > std::map> meteringModes_;\n> > > };\n> > > -- \n> > > 2.43.0\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 679A8C3213\n\tfor ;\n\tTue, 25 Mar 2025 13:53:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3242A68955;\n\tTue, 25 Mar 2025 14:53:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79992600EB\n\tfor ;\n\tTue, 25 Mar 2025 14:52:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30312353;\n\tTue, 25 Mar 2025 14:51:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rKzS4mJJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742910672;\n\tbh=hH8bbNhAFBTzVrRMLxc6V/hhEEXKOR7YjQZJE7H2Tas=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=rKzS4mJJC17SlHuyeOtOaH7liW4ZXAz53i6Ek0Nf+anzyUvmmsEWgGXJQjNa70V0o\n\t6DAoYgzkBhVX06HBBAvfJEMz8YTeg4tiRlvGA35v9lP3/G55GrzjzvmkaTRGCqvDRZ\n\tJz5a9oi+RXodbqnKsEPSZiHMPth2fY2BVAkubd+o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<47aha3dsrunys2tddb75h6uwa534l4wzpi7ftw5eovsmvdczef@kn6zta33h3c6>","References":"<20250319160146.61751-1-stefan.klug@ideasonboard.com>\n\t<20250319160146.61751-2-stefan.klug@ideasonboard.com>\n\t<174289792672.670680.9402975314057572515@ping.linuxembedded.co.uk>\n\t<47aha3dsrunys2tddb75h6uwa534l4wzpi7ftw5eovsmvdczef@kn6zta33h3c6>","Subject":"Re: [PATCH 1/2] ipa: rkisp1: agc: Fix metering modes","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Stefan Klug ","Date":"Tue, 25 Mar 2025 13:52:56 +0000","Message-ID":"<174291077630.3394313.17705727626581864673@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]