{"id":22972,"url":"https://patchwork.libcamera.org/api/patches/22972/?format=json","web_url":"https://patchwork.libcamera.org/patch/22972/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250317181146.214160-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-17T18:11:46","name":"[RFC,v1] libcamera: controls: Generate macro for each control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e133fcda9c487c6485eaaab4e93abf8f18057a7c","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22972/mbox/","series":[{"id":5067,"url":"https://patchwork.libcamera.org/api/series/5067/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5067","date":"2025-03-17T18:11:46","name":"[RFC,v1] libcamera: controls: Generate macro for each control","version":1,"mbox":"https://patchwork.libcamera.org/series/5067/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22972/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22972/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB5A1C32F5\n\tfor ;\n\tMon, 17 Mar 2025 18:11:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A37868942;\n\tMon, 17 Mar 2025 19:11:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB3A168928\n\tfor ;\n\tMon, 17 Mar 2025 19:11:49 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 355F8D77\n\tfor ;\n\tMon, 17 Mar 2025 19:10:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N8uCkCnZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742235008;\n\tbh=aNHOAGYuJmfvbfF436YsE7rydi4KPA5GVfusMNzO+kY=;\n\th=From:To:Subject:Date:From;\n\tb=N8uCkCnZLymf0fY5+VGF+cyyL0OA0VqEsciNmjpZ1bAPDv0uv7izj5VFN61P/FH0j\n\tmkMQSpZyKI/oujKSNQMAN7RXuamHTxYATXZoy6bXBemuw5cbbtyCY6cdHVA6QAIb+V\n\tDwkO8B0Bj8+sVBeMTi7kLXS7N140G43dzJ4iJuy8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1] libcamera: controls: Generate macro for each control","Date":"Mon, 17 Mar 2025 19:11:46 +0100","Message-ID":"<20250317181146.214160-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Generate a macro in the form of LIBCAMERA_HAS_$VENDOR_$MODE_$NAME\nfor each control so that its existence can be checked easily\nand without extra version checks.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/control_ids.h.in | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\nindex 5d0594c68..8f037589d 100644\n--- a/include/libcamera/control_ids.h.in\n+++ b/include/libcamera/control_ids.h.in\n@@ -49,6 +49,7 @@ extern const std::array {{ctrl.n\n extern const std::map {{ctrl.name}}NameValueMap;\n {% endif -%}\n extern const Control<{{ctrl.type}}> {{ctrl.name}};\n+#define LIBCAMERA_HAS_{{vendor|upper}}_{{mode|upper}}_{{ctrl.name|snake_case|upper}}\n {% endfor -%}\n \n {% if vendor != 'libcamera' %}\n","prefixes":["RFC","v1"]}