[{"id":33617,"web_url":"https://patchwork.libcamera.org/comment/33617/","msgid":"","date":"2025-03-17T18:56:16","subject":"Re: [PATCH v1] apps: cam: Highlight default enumerator","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Mar 17, 2025 at 07:11:41PM +0100, Barnabás Pőcze wrote:\n> Print \"[default]\" after the default enumerator when listing controls.\n>\n> Example:\n>\n> $ cam -c 1 --list-controls\n> [...]\n> Control: [inout] libcamera::ExposureTimeMode:\n> - ExposureTimeModeAuto (0) [default]\n> - ExposureTimeModeManual (1)\n>\n> Signed-off-by: Barnabás Pőcze \n\nSeems like a nice idea\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/cam/camera_session.cpp | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index 9e9348277..8a555339c 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -8,6 +8,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n>\n> #include \n> @@ -173,6 +174,11 @@ void CameraSession::listControls() const\n> \t\t\tstd::cout << \"Control: \" << io.str()\n> \t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n> \t\t\t\t << std::endl;\n> +\n> +\t\t\tstd::optional def;\n> +\t\t\tif (!info.def().isNone())\n> +\t\t\t\tdef = info.def().get();\n> +\n> \t\t\tfor (const auto &value : info.values()) {\n> \t\t\t\tint32_t val = value.get();\n> \t\t\t\tconst auto &it = id->enumerators().find(val);\n> @@ -182,7 +188,10 @@ void CameraSession::listControls() const\n> \t\t\t\t\tstd::cout << \"UNKNOWN\";\n> \t\t\t\telse\n> \t\t\t\t\tstd::cout << it->second;\n> -\t\t\t\tstd::cout << \" (\" << val << \")\" << std::endl;\n> +\n> +\t\t\t\tstd::cout << \" (\" << val << \")\"\n> +\t\t\t\t\t << (val == def ? \" [default]\" : \"\")\n> +\t\t\t\t\t << std::endl;\n> \t\t\t}\n> \t\t}\n>\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7804C32FA\n\tfor ;\n\tMon, 17 Mar 2025 18:56:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C83E66894D;\n\tMon, 17 Mar 2025 19:56:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63C3D68928\n\tfor ;\n\tMon, 17 Mar 2025 19:56:20 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FD07352;\n\tMon, 17 Mar 2025 19:54:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GbAZADAc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742237678;\n\tbh=DGtCqPh8QWHAkb/biWkMJzBBQuIvym5RH4XNwd/7iuA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GbAZADAc9G04gqzcAdxsNVMKbgA8FVohNJIfn9WQKRIirrcfhbmcE5iYtO+msjWT0\n\t7m2KlF8ZOxo+Ym+Rx7Zp56QSyVHEq8C3Ff27mOBORZvyukQDTWEmJbIWKcnHsa1S/i\n\t6qGjspFZHvql3D4LCHZBwCIlVl+DI6oX/ojeD6BE=","Date":"Mon, 17 Mar 2025 19:56:16 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] apps: cam: Highlight default enumerator","Message-ID":"","References":"<20250317181141.214118-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250317181141.214118-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33620,"web_url":"https://patchwork.libcamera.org/comment/33620/","msgid":"<174224778818.110831.2190212488484511643@ping.linuxembedded.co.uk>","date":"2025-03-17T21:43:08","subject":"Re: [PATCH v1] apps: cam: Highlight default enumerator","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-17 18:11:41)\n> Print \"[default]\" after the default enumerator when listing controls.\n> \n> Example:\n> \n> $ cam -c 1 --list-controls\n> [...]\n> Control: [inout] libcamera::ExposureTimeMode:\n> - ExposureTimeModeAuto (0) [default]\n> - ExposureTimeModeManual (1)\n> \n> Signed-off-by: Barnabás Pőcze \n\nI like this!\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/cam/camera_session.cpp | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index 9e9348277..8a555339c 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -8,6 +8,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> \n> #include \n> @@ -173,6 +174,11 @@ void CameraSession::listControls() const\n> std::cout << \"Control: \" << io.str()\n> << id->vendor() << \"::\" << id->name() << \":\"\n> << std::endl;\n> +\n> + std::optional def;\n> + if (!info.def().isNone())\n> + def = info.def().get();\n> +\n> for (const auto &value : info.values()) {\n> int32_t val = value.get();\n> const auto &it = id->enumerators().find(val);\n> @@ -182,7 +188,10 @@ void CameraSession::listControls() const\n> std::cout << \"UNKNOWN\";\n> else\n> std::cout << it->second;\n> - std::cout << \" (\" << val << \")\" << std::endl;\n> +\n> + std::cout << \" (\" << val << \")\"\n> + << (val == def ? \" [default]\" : \"\")\n> + << std::endl;\n> }\n> }\n> \n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 838CBC32F5\n\tfor ;\n\tMon, 17 Mar 2025 21:43:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A07D568942;\n\tMon, 17 Mar 2025 22:43:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37CCE617F8\n\tfor ;\n\tMon, 17 Mar 2025 22:43:11 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D3BA352;\n\tMon, 17 Mar 2025 22:41:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NHBt+sgy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742247689;\n\tbh=/Fsbu6FgMl3MPdxU4iMN+hJquAKq8asGfiazSZRvS2c=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=NHBt+sgyP2IY9coh46Pva2iu7gC6D2y2BFKEuzb51PVVUieCBvWLtvMgZrczD9Gbb\n\tsWfS2PLfxTvAcrVRCFBvz/yx12gmyzEfoRGPksULEgwBjmpwjOIgof+rmULGhAmxVb\n\tOy2b81kpuU7oWnYlWOt6QtNH/FAc6/HkQehInUFw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250317181141.214118-1-barnabas.pocze@ideasonboard.com>","References":"<20250317181141.214118-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] apps: cam: Highlight default enumerator","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Mar 2025 21:43:08 +0000","Message-ID":"<174224778818.110831.2190212488484511643@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]