[{"id":33615,"web_url":"https://patchwork.libcamera.org/comment/33615/","msgid":"","date":"2025-03-17T18:51:33","subject":"Re: [PATCH v1] libcamera: media_device: Ignore `lockf()` return\n\tvalue","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Mar 17, 2025 at 07:11:34PM +0100, Barnabás Pőcze wrote:\n> When `_FORTIFY_SOURCE` is enabled, the `lockf()` function might be marked\n> with the `warn_unused_result` attribute, leading to compilation failure.\n> Fix that by explicitly ignoring the return value.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/media_device.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index d71dad74d..75abd91d7 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n>\n> @@ -164,7 +165,7 @@ void MediaDevice::unlock()\n> \tif (!fd_.isValid())\n> \t\treturn;\n>\n> -\tlockf(fd_.get(), F_ULOCK, 0);\n> +\tstd::ignore = lockf(fd_.get(), F_ULOCK, 0);\n> }\n>\n> /**\n> --\n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FD9FC32F5\n\tfor ;\n\tMon, 17 Mar 2025 18:51:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D951C68942;\n\tMon, 17 Mar 2025 19:51:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 061F3617F8\n\tfor ;\n\tMon, 17 Mar 2025 19:51:36 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68A81352;\n\tMon, 17 Mar 2025 19:49:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OF0uE4wu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742237394;\n\tbh=MBZG+3u/3aGA4KQwdx19/kN951bfxQfCI9zUukfuEi8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OF0uE4wuxVIIyiHi5u79fchjAauiCSEZOgGqKSzAddxvJg6uyJwb/v0NnJuJIVZQH\n\tUmbawDOnj6nn14RaGFJDEmvbtAot5apGLCTuIKjAHgzccCtR6M8rk7oNzVOCvPFLtN\n\tEITtEZbMFf4JxNiffDMQohxZ65lgcpFffEO9FnzA=","Date":"Mon, 17 Mar 2025 19:51:33 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: media_device: Ignore `lockf()` return\n\tvalue","Message-ID":"","References":"<20250317181134.214074-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250317181134.214074-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33621,"web_url":"https://patchwork.libcamera.org/comment/33621/","msgid":"<174224790416.110831.10419799444967844381@ping.linuxembedded.co.uk>","date":"2025-03-17T21:45:04","subject":"Re: [PATCH v1] libcamera: media_device: Ignore `lockf()` return\n\tvalue","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-03-17 18:11:34)\n> When `_FORTIFY_SOURCE` is enabled, the `lockf()` function might be marked\n> with the `warn_unused_result` attribute, leading to compilation failure.\n> Fix that by explicitly ignoring the return value.\n> \n> Signed-off-by: Barnabás Pőcze \n\nI didn't know about std::ignore.\n\nLooks appropriate here...\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/media_device.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index d71dad74d..75abd91d7 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -164,7 +165,7 @@ void MediaDevice::unlock()\n> if (!fd_.isValid())\n> return;\n> \n> - lockf(fd_.get(), F_ULOCK, 0);\n> + std::ignore = lockf(fd_.get(), F_ULOCK, 0);\n> }\n> \n> /**\n> -- \n> 2.49.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 761C4C32FA\n\tfor ;\n\tMon, 17 Mar 2025 21:45:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAC9068942;\n\tMon, 17 Mar 2025 22:45:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD51617F8\n\tfor ;\n\tMon, 17 Mar 2025 22:45:06 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02D65352;\n\tMon, 17 Mar 2025 22:43:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iPl1M6Wk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742247805;\n\tbh=QxqUwEBBYXszYwS7sj9DVnXHtdkROtmjS6ABiaAyZS8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=iPl1M6WkpgIyKUzuYDmgT6axm7dVh9G6w4YJZPeBa5PAlAQorcm/FY+dAkwdZs0g4\n\tKBvIHRgw7dmjDf7IEjo/xalTh5JF4JLQPYYNENHNs+El5xAWKJ9YxevZTDXHaxWRIQ\n\tCyNA+L+2H54boNSTUfGcehF909TUvQxBu056T+yU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250317181134.214074-1-barnabas.pocze@ideasonboard.com>","References":"<20250317181134.214074-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: media_device: Ignore `lockf()` return\n\tvalue","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Mar 2025 21:45:04 +0000","Message-ID":"<174224790416.110831.10419799444967844381@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]